[ERROR] NEED HELP!

Im not understanding whats the issue with this.

Code:

package me.legitsoulja.playerwarp;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
public class playerwarp extends JavaPlugin implements Listener
{
    String prefix = ChatColor.GRAY+"["+ChatColor.DARK_PURPLE+"PW"+ChatColor.GRAY+"] ";
    public void LoadConfiguration()
    {
        getConfig().options().copyDefaults(true);
        saveConfig();
    }
    @Override
    public void onEnable()
    {
        getLogger().info(">-=-={Loading Configuration}=-=-<");
        LoadConfiguration();
        getLogger().info(">-=-={Done Loading!}=-=-<");
        getServer().getPluginManager().registerEvents(this, this);
    }@Override public void onDisable(){}
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){}
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
    {
        if(sender instanceof Player)
        {
            Player player = (Player)sender;
            String pname = player.getName();
            String warpcount = getConfig().getString("player." + pname + ".warps");
            String name = args[1];
            String owner = player.getName();
            String token = getConfig().getString("player." + owner);
            int max = getConfig().getInt("maxcreate");
           
            if(label.equalsIgnoreCase("pwarp"))
            {
                player.sendMessage(prefix + "Hey, " + pname + ". You have, " + warpcount + " total warps");
                player.sendMessage(prefix + "/pwarp || Main Command");
                player.sendMessage(prefix + "/pwarp create || Create Player Warp!");
                player.sendMessage(prefix + "/pwarp delete || Delete Your Warp!");
                player.sendMessage(prefix + "/pwarp <warp_name> || Teleport to <warp_name>");
                if(player.hasPermission("pwarp.admin") | player.isOp())
                {
                    player.sendMessage(prefix + "/pwarp reload || Reloads Config");
                    return true;
                }
            }
            if(player.hasPermission("pwarp.create") | player.isOp())
            {
                if(token.equals(max))
                {
                    if(args[0].equalsIgnoreCase("create"))
                    {
                        World world = Bukkit.getWorld(getConfig().getString("warp." + name + ".world"));
                        Location loc = player.getLocation();
                        /**/
                        getConfig().set("warp." + name + ".world", world);
                        getConfig().set("player." + owner, getConfig().getInt("player." + owner) + 1);
                        getConfig().set("warp." + name + ".owner", owner);
                        getConfig().set("warp." + name + ".x", loc.getX());
                        getConfig().set("warp." + name + ".y", loc.getY());
                        getConfig().set("warp." + name + ".x", loc.getX());
                        /**/
                        player.sendMessage(prefix + name + ", Has been created! now do /pwarp " + name);
                        return true;
                    }
                }else
                {
                    player.sendMessage(prefix + "You have reached your max warp claim!");
                }
            }
            if(player.hasPermission("pwarp.delete") | player.isOp())
            {
                if(args[0].equalsIgnoreCase("delete"))
                {
                    if(getConfig().getString("warp." + name + ".owner").equals(owner) | player.isOp())
                    {
                        getConfig().set("warp." + name + ".world", null);
                        getConfig().set("warp." + name + ".owner", null);
                        getConfig().set("warp." + name + ".x", null);
                        getConfig().set("warp." + name + ".y", null);
                        getConfig().set("warp." + name + ".x", null);
                        player.sendMessage(prefix + "Warp, " + name + " Has been deleted!");
                    }else
                    {
                        player.sendMessage(prefix + "Your not allowed to delete a warp thats not yours!");
                    }
                }
            }else
            {
                player.sendMessage(prefix + "You have no permissions to delete a warp!");
            }
            if(player.hasPermission("pwarp.warp") | player.isOp())
            {
                if(args[0].equalsIgnoreCase("pwarp") && !args[1].equalsIgnoreCase(""))
                {
                    World world = Bukkit.getWorld("warp." + name + ".world");
                    int x = getConfig().getInt("warp." + name + ".x");
                    int y = getConfig().getInt("warp." + name + ".y");
                    int z = getConfig().getInt("warp." + name + ".z");
                   
                    Location location = new Location(world, x, y, z);
                   
                    player.teleport(location);
                    return true;
                }else
                {
                    return true;
                }
            }else
            {
                player.sendMessage(prefix + "You dont have permission to warp anywhere!");
            }
            if(args[0].equalsIgnoreCase("reload"))
            {
                reloadConfig();
                player.sendMessage(prefix + "Plugin reloaded!");
                System.out.println(prefix + "Plugin reloaded!");
            }
        }
        return false;
    }
}

 

mactown21 Whats on line 38?

 

mactown21 I counted the lines. Line 38 is

Code:java

String name = args[1];

Now when you say this after the onCommand() void, you are telling it to use args[1], regardless of whether or not it exists. You need an if statement to check if args[1] exists before you can use it.

Also, arrays start counting at zero. So in a command, lets say "/throw <player> <distance>", "throw" is the label, player is args[0], and distance is args[1].

 

mactown21 ArrayIndexOutOfBoundsException

You're assuming that args[1] is not null when you declare it to a variable.

Code:

String name = args[1];

Then you attempt to use it in a boolean expression.

Code:

if(args[0].equalsIgnoreCase("pwarp") && !args[1].equalsIgnoreCase(""))

I know what you're trying to do here. Instead, just check if:

Code:

args[1] != null

EDIT: bdubz4552 Ninja'd

 

bdubz4552 yea for example so for my name just get rid of that string and just change all the name variables to args[1]?
because /pwarp create args[1]

flaaghara and ok, i will just return the args if its null.

and so mainly everything is crashing because of the args right? flaaghara bdubz4552 Go Hard

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

mactown21
And yes, the args[] is the problem. Don't forget to start it on 0, not 1.

Code:java

package me.legitsoulja.playerwarp;
//Imports and all that other stuff
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
{
if(sender instanceof Player)
{
Player player = (Player)sender;
String pname = player.getName();
String warpcount = getConfig().getString("player." + pname + ".warps");
 
//This is what you should have.
if (args[1] != null) {
String name = args[1];
} else {
player.sendMessage(//some message about bad arguments);
}
 
String owner = player.getName();
String token = getConfig().getString("player." + owner);
int max = getConfig().getInt("maxcreate");
 
if(label.equalsIgnoreCase("pwarp"))
{
player.sendMessage(prefix + "Hey, " + pname + ". You have, " + warpcount + " total warps");
player.sendMessage(prefix + "/pwarp || Main Command");
player.sendMessage(prefix + "/pwarp create || Create Player Warp!");
player.sendMessage(prefix + "/pwarp delete || Delete Your Warp!");
player.sendMessage(prefix + "/pwarp <warp_name> || Teleport to <warp_name>");
if(player.hasPermission("pwarp.admin") | player.isOp())
{
player.sendMessage(prefix + "/pwarp reload || Reloads Config");
return true;
}
}
if(player.hasPermission("pwarp.create") | player.isOp())
{
if(token.equals(max))
{
if(args[0].equalsIgnoreCase("create"))
{
World world = Bukkit.getWorld(getConfig().getString("warp." + name + ".world"));
Location loc = player.getLocation();
/**/
getConfig().set("warp." + name + ".world", world);
getConfig().set("player." + owner, getConfig().getInt("player." + owner) + 1);
getConfig().set("warp." + name + ".owner", owner);
getConfig().set("warp." + name + ".x", loc.getX());
getConfig().set("warp." + name + ".y", loc.getY());
getConfig().set("warp." + name + ".x", loc.getX());
/**/
player.sendMessage(prefix + name + ", Has been created! now do /pwarp " + name);
return true;
}
}else
{
player.sendMessage(prefix + "You have reached your max warp claim!");
}
}
if(player.hasPermission("pwarp.delete") | player.isOp())
{
if(args[0].equalsIgnoreCase("delete"))
{
if(getConfig().getString("warp." + name + ".owner").equals(owner) | player.isOp())
{
getConfig().set("warp." + name + ".world", null);
getConfig().set("warp." + name + ".owner", null);
getConfig().set("warp." + name + ".x", null);
getConfig().set("warp." + name + ".y", null);
getConfig().set("warp." + name + ".x", null);
player.sendMessage(prefix + "Warp, " + name + " Has been deleted!");
}else
{
player.sendMessage(prefix + "Your not allowed to delete a warp thats not yours!");
}
}
}else
{
player.sendMessage(prefix + "You have no permissions to delete a warp!");
}
if(player.hasPermission("pwarp.warp") | player.isOp())
{
if(args[0].equalsIgnoreCase("pwarp") && !args[1].equalsIgnoreCase(""))
{
World world = Bukkit.getWorld("warp." + name + ".world");
int x = getConfig().getInt("warp." + name + ".x");
int y = getConfig().getInt("warp." + name + ".y");
int z = getConfig().getInt("warp." + name + ".z");
 
Location location = new Location(world, x, y, z);
 
player.teleport(location);
return true;
}else
{
return true;
}
}else
{
player.sendMessage(prefix + "You dont have permission to warp anywhere!");
}
if(args[0].equalsIgnoreCase("reload"))
{
reloadConfig();
player.sendMessage(prefix + "Plugin reloaded!");
System.out.println(prefix + "Plugin reloaded!");
}
}
return false;
}
}

 

bdubz4552 on line 82 should i keep this?
!args[1].equalsIgnoreCase(""))

 

mactown21 If args[1] does not exist, that will give an ArrayIndexOutOfBounds exception as well. My personal suggestion would be that if however many args you need are not present, you halt the method.

Code:java

public boolean onCommand(<insert parameters... Meh>) {
    if (args.length != 2) {
        sender.sendMessage("Learn to use yer arguments!");
        return true;
    }
    /**
      * Now as long as there are two arguments, this method will run.
      * If not, the method dies at the return.
    */
}