Solved MySQL: Syntax Error? I think not.

Hello,
After recently curing an error I had that prevented a certain part of a loop from running, it appears that that part in itself has an error. It seems that when it tries to log information to a MySQL database, it gives me some sort of error on line 112. I'm not sure what it means, because it looks perfectly fine to me. The line executes the logging of all the information. I'm pretty sure the info is correctly formatted. Any leads as to what I need to fix are appreciated.

Main Class:

Code:java

package me.Build_.Collective;
 
import code.husky.mysql.MySQL;
 
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.block.Block;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scheduler.BukkitScheduler;
 
 
 
//-----> Concluded Imports <-----\\
public class Main extends JavaPlugin {
    // -----> c-Logger and Plug-in <-----\\
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Main plugin;
    Statement tableSetup;
    Statement grabber;
    int logCount = Bukkit.getServer().getOnlinePlayers().length;
    // -----> Connection variable <-----\\
    Connection c;
 
    // -----> Disable Setup <-----\\
    @Override
    public void onDisable() {
        saveConfig();
        c = null;
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName()
                + " was successfully disabled. Goodbye!");
    }
 
    // -----> Enable Setup <-----\\
    @Override
    public void onEnable() {
        // -----> Config.<-----\\
        FileConfiguration config = getConfig();
 
        config.addDefault("Config.Logging.Interval", 15L);
        config.addDefault("Config.Database.hostname", "localhost");
        config.addDefault("Config.Database.port", "3306");
        config.addDefault("Config.Database.database", "minecraft");
        config.addDefault("Config.Database.user", "root");
        config.addDefault("Config.Database.password", "password");
 
        config.options().copyDefaults(true);
        saveConfig();
        // -----> Grab MySQL Credentials <-----\\
        final String dbHost = getConfig().getString("Config.Database.hostname", "localhost");
        final String dbPort = getConfig().getString("Config.Database.port", "3306");
        final String dbName = getConfig().getString("Config.Database.database", "minecraft");
        final String dbUser = getConfig().getString("Config.Database.user", "root");
        final String dbPass = getConfig().getString("Config.Database.password", "password");
        final MySQL MySQL = new MySQL(this, dbHost, dbPort, dbName, dbUser,
                dbPass);
        //-----> Setup Tables <-----\\
        c = MySQL.openConnection();
        try {
            getLogger().info("First try statement init.");
            tableSetup = MySQL.openConnection().createStatement();
            tableSetup
                    .execute("CREATE TABLE IF NOT EXISTS `LW` (`ID` INTEGER PRIMARY KEY NOT NULL, `ign` TEXT NOT NULL, `w` TEXT NOT NULL, `x` DOUBLE NOT NULL, `y` DOUBLE NOT NULL, `z` DOUBLE NOT NULL)");
            getLogger().info("First try statement complete.");
        } catch (SQLException e) {
            e.printStackTrace();
        }
        // -----> Main Enabler <-----\\
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion()
                + " was successfully enabled!");
 
        BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
        scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
            @Override
            public void run() {
                    // -----> Main Logger <-----\\
                    PreparedStatement log;
                    try {
                        getLogger().info("2nd try started.");
                        log = MySQL
                                .openConnection()
                                .prepareStatement(
                                        "INSERT INTO LW (`ign`, `w`, `x`, `y`, `z`) VALUES (?, ?, ?, ?, ?,);");
                        getLogger().info("2nd try finished.");
 
                        for (Player p : Bukkit.getOnlinePlayers()) {
                            Location loc = p.getLocation();
                            log.setString(1, p.getName());
                            log.setString(2, loc.getWorld().getName());
                            log.setNString(3,
                                    String.valueOf(loc.getX()));
                            log.setNString(4,
                                    String.valueOf(loc.getY()));
                            log.setNString(5,
                                    String.valueOf(loc.getZ()));
                            getLogger().info("Beginning log for" + p.getName());
                            log.execute();
                            getLogger().info("Data logged for " + p.getName());
                        }
 
                    } catch (SQLException e) {
                        e.printStackTrace();
                    }
            }
        }, 0L, 20L * getConfig().getLong("interval",15L));
    }
 
    // -----> Main Commands <-----\\
    @Override
    public boolean onCommand(CommandSender sender, Command cmd,
            String commandLabel, String[] args) {
        Player run = (Player) sender;
        World w = run.getWorld();
        if (commandLabel.equalsIgnoreCase("lw")) {
            if (args.length == 0) {
                run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                        + "-------" + ChatColor.GOLD + "]" + ChatColor.YELLOW
                        + " Location Watchdog " + "[" + ChatColor.GREEN
                        + "-------" + ChatColor.GOLD + "]");
                run.sendMessage(ChatColor.YELLOW
                        + " Location Watchdog is a plugin by Build_ that ");
                run.sendMessage(ChatColor.YELLOW
                        + " periodically logs all player locations. It can ");
                run.sendMessage(ChatColor.YELLOW
                        + " later show all the previous locations of a player. ");
                run.sendMessage(ChatColor.YELLOW
                        + " Help: /lw help - Thanks for using LW! ");
                run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                        + "--------------------------------" + ChatColor.GOLD
                        + "]");
            } else if (args.length == 1) {
                if (args[0].equals("help")) {
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.YELLOW
                            + " Commands: ");
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.DARK_RED
                            + " /lw - About Location Watchdog.");
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.DARK_RED
                            + " /lw get - See LW's Bukkit page.");
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.DARK_RED
                            + " /lw help - Shows this page.");
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.DARK_RED
                            + " /lw version - Check LW's installed version.");
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.DARK_RED
                            + " /lw check <player> - Show a players locations.");
                    run.sendMessage(ChatColor.GOLD
                            + "["
                            + ChatColor.GREEN
                            + "LW"
                            + ChatColor.GOLD
                            + "]"
                            + ChatColor.DARK_RED
                            + " /lw done <player> - Finish viewing player locations.");
                } else if (args[0].equals("get")) {
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.YELLOW
                            + " Bukkit Dev Page: " + ChatColor.DARK_RED
                            + "dev.bukkit.org/location-watchdog/");
                } else if (args[0].equals("version")) {
                    PluginDescriptionFile pdfFile = this.getDescription();
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.YELLOW
                            + " Installed Version: " + ChatColor.DARK_RED
                            + pdfFile.getVersion() + " by Build_.");
                } else if (args[0].equals("check")) {
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.YELLOW
                            + " Incorrect syntax! " + ChatColor.DARK_RED
                            + "/lw check <player>");
                } else {
                    run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                            + "LW" + ChatColor.GOLD + "]" + ChatColor.YELLOW
                            + " Error: " + ChatColor.DARK_RED
                            + "Unknown command!" + ChatColor.YELLOW
                            + " Try /lw help.");
                }
            } else if (args.length == 2) {
                if (args[0].equals("check")) {
                    if (run.hasPermission("lw.staff")) {
                        String target = args[1];
                        String world = run.getWorld().getName();
                        try {
                            grabber = c.createStatement();
                            ResultSet res = grabber
                                    .executeQuery("SELECT * FROM LW WHERE ign = '"
                                            + target
                                            + "' AND w = '"
                                            + world
                                            + "';");
                            if (res.first()) {
                                getLogger().info("Res.first for /lw check positive.");
                                while (res.next()) {
                                    getLogger().info("While start.");
                                    int x = res.getInt("x");
                                    int y = res.getInt("y");
                                    int z = res.getInt("z");
                                    run.sendMessage("X: " + x + ", Y: " + y
                                            + ", Z: " + z);
                                    run.sendBlockChange(
                                            new Location(w, x, y, z), 113,
                                            (byte) 0);
                                    run.sendBlockChange(new Location(w, x,
                                            y + 1, z), 89, (byte) 0);
                                    getLogger().info("While end.");
                                }
 
                                getLogger().info("While complete.");
 
                                run.sendMessage(ChatColor.GOLD + "["
                                        + ChatColor.GREEN + "LW"
                                        + ChatColor.GOLD + "]"
                                        + ChatColor.YELLOW
                                        + " Now viewing logged locations for: "
                                        + ChatColor.WHITE + target
                                        + ChatColor.YELLOW + " in the world: "
                                        + ChatColor.WHITE
                                        + run.getWorld().getName()
                                        + ChatColor.YELLOW + ".");
 
                            } else {
 
                                run.sendMessage(ChatColor.GOLD + "["
                                        + ChatColor.GREEN + "LW"
                                        + ChatColor.GOLD + "]"
                                        + ChatColor.YELLOW + " Error: "
                                        + ChatColor.WHITE + target
                                        + ChatColor.DARK_RED
                                        + " doesn't have any logged locations in this world!");
                                getLogger().info("None found, ln. 254");
 
                            }
                        } catch (SQLException e) {
                            e.printStackTrace();
                        }
                    } else {
                        run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                                + "LW" + ChatColor.GOLD + "]"
                                + ChatColor.YELLOW + " Error:"
                                + ChatColor.DARK_RED
                                + " You don't have permission!");
                    }
                } else if (args[0].equals("done")) {
                        String target = args[1];
                        String world = run.getWorld().getName();
                        try {
                            ResultSet un = grabber
                                    .executeQuery("SELECT * FROM LW WHERE ign = '"
                                            + target
                                            + "' AND w = '"
                                            + world
                                            + "';");
                            if (un.first()) {
                                while (un.next()) {
                                    getLogger().info("While start.");
                                    int x = un.getInt("x");
                                    int y = un.getInt("y");
                                    int z = un.getInt("z");
                                    Block b = w.getBlockAt(x, y, z);
                                    run.sendMessage("X: " + x + ", Y: " + y
                                            + ", Z: " + z);
                                    run.sendBlockChange(
                                            new Location(w, x, y, z),
                                            b.getTypeId(), (byte) b.getData());
                                    run.sendBlockChange(new Location(w, x,
                                            y + 1, z), b.getTypeId(), (byte) b
                                            .getData());
                                    getLogger().info("While end.");
                                }
 
                                run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN
                                        + "LW" + ChatColor.GOLD + "]"
                                        + ChatColor.YELLOW
                                        + " No longer viewing logged locations for: "
                                        + ChatColor.WHITE + target + ChatColor.YELLOW
                                        + " in the world: " + ChatColor.WHITE
                                        + run.getWorld().getName() + ChatColor.YELLOW
                                        + ".");
 
                            } else {
                                run.sendMessage(ChatColor.GOLD
                                        + "["
                                        + ChatColor.GREEN
                                        + "LW"
                                        + ChatColor.GOLD
                                        + "]"
                                        + ChatColor.YELLOW
                                        + " Error: "
                                        + ChatColor.DARK_RED
                                        + " That player doesn't have any logged locations in this world!");
                                getLogger().info("None, ln. 315");   
                            }
 
                        } catch (SQLException e) {
                            e.printStackTrace();
                        }
 
                }
            } else {
                run.sendMessage(ChatColor.GOLD + "[" + ChatColor.GREEN + "LW"
                        + ChatColor.GOLD + "]" + ChatColor.YELLOW + " Error: "
                        + ChatColor.DARK_RED + "Incorrect syntax!"
                        + ChatColor.YELLOW + " Try /lw help.");
            }
            return false;
        }
        return false;
    }
}

Errors:

Code:

4:07:58 PM [WARNING] com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1
4:07:58 PM [WARNING]    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
4:07:58 PM [WARNING]    at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
4:07:58 PM [WARNING]    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
4:07:58 PM [WARNING]    at java.lang.reflect.Constructor.newInstance(Unknown Source)
4:07:58 PM [WARNING]    at com.mysql.jdbc.Util.handleNewInstance(Util.java:407)
4:07:58 PM [WARNING]    at com.mysql.jdbc.Util.getInstance(Util.java:382)
4:07:58 PM [WARNING]    at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1052)
4:07:58 PM [WARNING]    at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3593)
4:07:58 PM [WARNING]    at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3525)
4:07:58 PM [WARNING]    at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1986)
4:07:58 PM [WARNING]    at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2140)
4:07:58 PM [WARNING]    at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2626)
4:07:58 PM [WARNING]    at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:2111)
4:07:58 PM [WARNING]    at com.mysql.jdbc.PreparedStatement.execute(PreparedStatement.java:1362)
4:07:58 PM [WARNING]    at me.Build_.Collective.Main$1.run(Main.java:112)
4:07:58 PM [WARNING]    at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftTask.run(CraftTask.java:58)
4:07:58 PM [WARNING]    at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
4:07:58 PM [WARNING]    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:635)
4:07:58 PM [WARNING]    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:283)
4:07:58 PM [WARNING]    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:583)
4:07:58 PM [WARNING]    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:489)
4:07:58 PM [WARNING]    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628)

GitHub with all code: https://github.com/TacticalCactupi/LW

Also, I can confirm a connection to the MySQL server.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

This doesn't seem quite right: (?, ?, ?, ?, ?,)

 

In MySQL, those are filled by the variables declared below it, as I was taught.

Lolmewn Oh wait, there's an extra comma. I'll remove that and see what happens.

Well, I'll be. That did it. I can't believe I was so stupid. Thanks for pointing that out. Now I've got a new set of errors, I'm afraid.

Code:

5:46:00 PM [WARNING] java.sql.SQLException: Field 'ID' doesn't have a default value
5:46:00 PM [WARNING]     at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1073)
5:46:00 PM [WARNING]     at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3593)
5:46:00 PM [WARNING]     at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3525)
5:46:00 PM [WARNING]     at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1986)
5:46:00 PM [WARNING]     at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2140)
5:46:00 PM [WARNING]     at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2626)
5:46:00 PM [WARNING]     at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:2111)
5:46:00 PM [WARNING]     at com.mysql.jdbc.PreparedStatement.execute(PreparedStatement.java:1362)
5:46:00 PM [WARNING]     at me.Build_.Collective.Main$1.run(Main.java:112)
5:46:00 PM [WARNING]     at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftTask.run(CraftTask.java:58)
5:46:00 PM [WARNING]     at org.bukkit.craftbukkit.v1_7_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
5:46:00 PM [WARNING]     at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:635)
5:46:00 PM [WARNING]     at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:283)
5:46:00 PM [WARNING]     at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:583)
5:46:00 PM [WARNING]     at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:489)
5:46:00 PM [WARNING]     at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Build_and_Break
Set ID to be auto increment

 

Build_and_Break Your table has an 'ID' field but no default value. I'm guessing you want to make this auto_increment not_null primary_key?

 

I thought primary keys were automatic. How would I go about making it so each log entry would have a primary key besides adding the field in table setup?

Oh, okay. Thanks, I'll try that.

Hmm,

5:59:20 PM [WARNING] com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AUTO INCREMENT NOT NULL PRIMARY KEY, `ign` TEXT NOT NULL, `w` TEXT NOT NULL, `x`' at line 1

It doesn't like the way I wrote AUTO INCREMENT NOT NULL PRIMARY KEY, but that's how I assigned variables to every other statement.

Every other variable, correction. Sorry, my edit button never works.

Solved it! Thanks for the help on the other stuff, guys.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.