Cannot rename item in DelayedTask

I've no idea why this doesn't work. I just want to rename item in player after they right-click air with a delay.

Action.LEFT_CLICK_AIR is working! but RIGHT_CLICK_AIR is not
What should I do?

Code:java

@EventHandler
public void onInteract(PlayerInteractEvent e){
    if(e.getAction() == Action.RIGHT_CLICK_AIR){
        final Player p = e.getPlayer();
        final ItemStack is = p.getItemInHand();
        final ItemMeta im = is.getItemMeta();
 
        Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
 
            @Override
            public void run() {
                im.setDisplayName("&cYEAH :D");
                is.setItemMeta(im);
                p.sendMessage("ItemMeta set!");
            }
        }, 20);
    }
}

 

I think its public void Runnable. Im not for sure since i dont work with bukkut scheduals

 

mactown21
It's definitely public void run()

cadenzatb
Try updating the player's inventory.

 

RAFA_GATO_FOFO ok i wassnt for sure, and

mactown21
Add player.updateInventory(); right under where the meta changes

 

@RAFA_GATO_FOFO
@mactown21

I tried it and not thing changes.

Code:java

@EventHandler
public void onInteract(PlayerInteractEvent e){
if(e.getAction() == Action.RIGHT_CLICK_AIR){
p.updateInventory();
final Player p = e.getPlayer();
final ItemStack is = p.getItemInHand();
final ItemMeta im = is.getItemMeta();
 
Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
 
@Override
public void run() {
im.setDisplayName("&cYEAH :D");
is.setItemMeta(im);
p.updateInventory();
p.sendMessage("ItemMeta set!");
}
}, 20);
}
}

ps. if I hold "BOW" or "SWORD" and right-clice it actually works! (I think both of them work because they have an animation when you right-click it) but all other items are still not working.

 

cadenzatb try

Code:java

@EventHandler(ignoreCancelled=true)

If I recall correctly RIGHT_CLICK_AIR had some thing with being cancelled by default.

 

@fireblast709
Unfortunately, it still not works.

But I figured something out.
I think I have to use this

Code:java

e.getPlayer().setItemInHand(is);

instead of just edit old itemstack and it does work !
But, I have to deal with few other problem such as if player change item-slot or drop-item.

Thanks everyone btw

 

cadenzatb Also, your code didn't check to make sure a player had an item in their hand... that's a problem.