How to return ItemStack for player item held in hand

Code:java

package io.github.aguy867.Guns;
 
import org.bukkit.Material;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.Player;
import org.bukkit.entity.Projectile;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.util.Vector;
 
public class Main extends JavaPlugin implements Listener{
    @Override
    public void onEnable() { //What to do on server load/reload
        getLogger().info("Guns is enabled. All clear for take off!");
        PluginManager pm = getServer().getPluginManager();
        pm.registerEvents(this, this);
        }
 
    @Override
    public void onDisable() { //What to do on server unload/reload
      getLogger().info("Guns is disabled. Bye!");
 
    }
 
    public ItemStack getItemInHand(Player p){
        return p.getItemInHand();
    }
 
 
    String Pistolg = "Pistol";
 
    ItemStack Pistol = new ItemStack(Material.BOW, 1); //Load items
 
    ItemMeta pistolm = Pistol.getItemMeta();
 
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event){
        pistolm.setDisplayName(Pistolg);
 
        Pistol.setItemMeta(pistolm);
        Player p = event.getPlayer();
        p.getInventory().addItem(Pistol);
    }
 
  @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
        pistolm.setDisplayName(Pistolg);
 
        Pistol.setItemMeta(pistolm);
 
        Player p = event.getPlayer();
        if(event.getAction() == Action.RIGHT_CLICK_AIR){
 
        if (getItemInHand() == Pistol){// what can i put here cause this code isnt workiing
            getLogger().info("hi");
            int v = 2;
            final Vector direction = p.getEyeLocation().getDirection().multiply(v);
 
            Arrow tnt = p.getWorld().spawn(p.getEyeLocation().add(direction.getX(), direction.getY(), direction.getZ()), Arrow.class);
 
            tnt.setVelocity(direction);
        }
        }
    }
    /*
    @EventHandler
    public void onPlayerdamage(EntityDamageByEntityEvent event){
        Player damager = (Player) ((Projectile) event).getShooter();
        if (event.getDamager() instanceof Arrow)  {
        Arrow arrow = (Arrow) event.getDamager();
 
            if (arrow.getShooter() instanceof Player && damager.getItemInHand() == Pistol){
                event.setDamage(event.getDamage() + 2);
            }
 
 
    }
    }*/
    }
 

I cant seem to get the if statement to detect that the player is holding "Pistol". Anyone know a way how?

 

aguy867867 Try using .equals() instead of ==

 

DJSkepter This will check the durability and everything, see ItemStack.java starting from line 302.

First of all you should get rid of the redundant function getItemInHand. I would compare the material type and then the item name. Something like this:

Code:java

 
ItemStack itemInHand = p.getItemInHand();
if(itemInHand.getType() == Material.BOW && itemInHand.hasItemMeta() && itemInHand.getItemMeta().getDisplayName() .equals("Pistol") {
...
}
 

 

Thanks! It works now.