Disable PVP for players in an array list.

I have 2 teams, red and blue. I want to disable PVP for players in the same array list. Evrything I have tried has failed. Could someone help me out?

 

DoctorDark
*event.setCancelled(true);

 

Zix DoctorDark
Also check if player is hitting another player before cancelling the event, if you want to allow them to fight against mobs.

 

This isn't working :/

Code:java

    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
        Player player = (Player) event.getEntity();
        Player damager = (Player) event.getDamager();
        if(player instanceof Player){
        if (red.contains(player.getName()) && red.contains(damager.getName())){
 
            event.setCancelled(true);
 
        }
        if (blue.contains(player.getName()) && blue.contains(damager.getName())){
 
            event.setCancelled(true);
 
            }
        }
    }
}

 

Don't forget to register the event too

Code:java

@EventHandler
public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
if(event.getEntity() instanceof Player && event.getDamager() instanceof Player){
Player player = (Player) event.getEntity();
Player damager = (Player) event.getDamager();
 
if (red.contains(player.getName()) && red.contains(damager.getName())){
event.setCancelled(true);
} else if (blue.contains(player.getName()) && blue.contains(damager.getName())){
event.setCancelled(true);
}
}
}

 

Also how would I make this work with bows, as arrows are a separate entity

 

The arrow has a getShooter method. Get the ProjectileSource, check if it's a player, cast to a player if it is, and check the list.

Also, you do the instanceof check before casting, not after. If you do it after, it's redundant and you're going to get ClassCastExceptions all the time.

 

This isnt working :/

Code:java

    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event){   
        if(event.getEntity() instanceof Player && event.getDamager() instanceof Player){
            Player player = (Player) event.getEntity();
            Player damager = (Player) event.getDamager();
 
            if (red.contains(player.getName()) && red.contains(damager.getName())){
                event.setCancelled(true);
            } else if (blue.contains(player.getName()) && blue.contains(damager.getName())){
                event.setCancelled(true);
            }
        } else if(event.getEntity() instanceof Arrow && event.getDamager() instanceof Player){
            Entity arrow = event.getEntity();
            if(((Projectile) arrow).getShooter() instanceof Player){
                Player player = (Player) arrow;
                Player damager = (Player) event.getDamager();
                if (red.contains(player.getName()) && red.contains(damager.getName())){
                    event.setCancelled(true);
                } else if (blue.contains(player.
                        getName()) && blue.contains(damager.getName())){
                    event.setCancelled(true);
                }
            }
        }
    }

 

Bomp.

 

Any errors?

 

It is easier to use the Scoreboard teams.
Since they disable arrow/projectiles automatically.

 

Zix

Code:

else if(event.getEntity() instanceof Arrow && event.getDamager() instanceof Player)

So... if an Arrow is being damaged by a Player?

 

AdamQpzm
._.
Ill fix that, but i need to know why that code isnt working

In fact yea, ill just do that

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Zix
The code probabally wasn't working because of the issue that AdamQpzm pointed out...

 

Alright I am really confused and loosing my patience as I have been working on this for ages, I switched to using scoreboard teams and it still doesn't work.

Code:java

package me.Zix.BorderClans;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
import org.bukkit.scoreboard.Team;
 
public class BorderClans extends JavaPlugin implements Listener {
 
public void onEnable() {
 
getServer().getPluginManager().registerEvents(this, this);
getConfig().options().copyDefaults(true);
 
}
 
ArrayList<Player> red = new ArrayList<Player>(0);
ArrayList<Player> blue = new ArrayList<Player>(0);
 
 
 
@EventHandler
public void onPlayerjoin(PlayerJoinEvent event){
 
Player player = event.getPlayer();
 
if(player.hasPlayedBefore() == true){
 
ScoreboardManager manager = Bukkit.getScoreboardManager();
Scoreboard board = manager.getNewScoreboard();
Team r = board.registerNewTeam("red");
Team b = board.registerNewTeam("blue");
 
r.setAllowFriendlyFire(false);
b.setAllowFriendlyFire(false);
 
String redteam = "red";
String blueteam = "blue";
String team = getConfig().getString(player.getName() + ".team");
 
if(team == null){
if(red.size() == blue.size()){
 
String redconfig = "red";
this.getConfig().set(player.getName() + ".team", redconfig);
saveConfig();
 
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
} else {
if (red.size() < blue.size()){
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
String redconfig = "red";
this.getConfig().set(player.getName() + ".team", redconfig);
saveConfig();
 
} else if (blue.size() < red.size()){
b.addPlayer(player);
blue.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.BLUE + "Blue " + ChatColor.GRAY + "team!");
String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
player.setDisplayName(blueprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 11));
 
String blueconfig = "blue";
this.getConfig().set(player.getName() + ".team", blueconfig);
saveConfig();
}
}
} else if(team.equalsIgnoreCase(redteam)){
 
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
} else if(team.equals(blueteam)){
 
b.addPlayer(player);
blue.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.BLUE + "Blue " + ChatColor.GRAY + "team!");
String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
player.setDisplayName(blueprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 11));
 
} else if(team.equals(null)){
if(red.size() == blue.size()){
 
String redconfig = "red";
this.getConfig().set(player.getName() + ".team", redconfig);
saveConfig();
 
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
} else {
if (red.size() < blue.size()){
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
String redconfig = "red";
this.getConfig().set(player.getName() + ".team", redconfig);
saveConfig();
 
} else if (blue.size() < red.size()){
b.addPlayer(player);
blue.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.BLUE + "Blue " + ChatColor.GRAY + "team!");
String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
player.setDisplayName(blueprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 11));
 
String blueconfig = "blue";
this.getConfig().set(player.getName() + ".team", blueconfig);
saveConfig();
}
}
}
} else if(player.hasPlayedBefore() == false){
 
ScoreboardManager manager = Bukkit.getScoreboardManager();
Scoreboard board = manager.getNewScoreboard();
Team r = board.registerNewTeam("red");
Team b = board.registerNewTeam("blue");
 
r.setAllowFriendlyFire(false);
b.setAllowFriendlyFire(false);
 
if(red.size() == blue.size()){
 
String redconfig = "red";
this.getConfig().set(player.getName() + ".team", redconfig);
saveConfig();
 
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
} else if (red.size() < blue.size()){
r.addPlayer(player);
red.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.RED + "Red " + ChatColor.GRAY + "team!");
String redprefix = "§7[§4Red§7][§c-§7]§4 ";
player.setDisplayName(redprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 14));
 
String redconfig = "red";
this.getConfig().set(player.getName() + ".team", redconfig);
saveConfig();
 
} else if (blue.size() < red.size()){
b.addPlayer(player);
blue.add(player);
player.sendMessage(ChatColor.GRAY + "You have been put on " + ChatColor.BLUE + "Blue " + ChatColor.GRAY + "team!");
String blueprefix = "§7[§9Blue§7][§a+§7]§9 ";
player.setDisplayName(blueprefix + player.getName() + "§f");
player.getInventory().setHelmet(new ItemStack(Material.WOOL, 1, (short) 11));
 
String blueconfig = "blue";
this.getConfig().set(player.getName() + ".team", blueconfig);
saveConfig();
}
}
}
 
 
@EventHandler
public void onHelmetTouch(InventoryClickEvent event){
if(event.getSlot() == 39){
event.setCancelled(true);
}
}
}

 

Here body, i wrote this Listener for you It will cancel the Event if both are in team blue or both are not. I didnt include a red Team, because if you only have 2 Teams it is logical that everybody who isnt in team blue is in team red. If not, you can add simply a isReg() method and add the few if cases.

Much fun, Shmobi

Code:java

import java.util.ArrayList;
 
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
 
public class TeamHandler implements Listener {
 
private ArrayList<Player> teamBlue;
 
public TeamHandler(ArrayList<Player> playerTeamBlue) {
teamBlue = playerTeamBlue;
}
 
@EventHandler
public void onPlayerHitPlayer(EntityDamageByEntityEvent damageEvent) {
Entity e1 = damageEvent.getEntity();
Entity e2 = damageEvent.getDamager();
if (e1 != null && e1 instanceof Player && e2 != null && e2 instanceof Player) {
Player victom = (Player) e1;
Player damager = (Player) e2;
if (areInSameTeam(victom, damager)) {
damageEvent.setCancelled(true);
}
}
}
 
private boolean areInSameTeam(Player p1, Player p2) {
if (isBlue(p1)) {
if (isBlue(p2)) {
return true;
}
return false;
} else {
if (isBlue(p2)) {
return false;
}
return true;
}
}
 
private boolean isBlue(Player p) {
for (Player player : teamBlue) {
if (player.equals(p)) {
return true;
}
}
return false;
}
 
}
 

 

Still not working :/

 

Bamp.

 

Mabey EntityDamageEvent and check if the Player is on the same team.

 

Urg.
This is what I have got so far, still not working.

Code:java

    @EventHandler
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event){
        if(event.getDamager() instanceof Player && event.getEntity() instanceof Player){
 
            Player player = (Player) event.getEntity();
            Player damager = (Player) event.getDamager();
 
            if (red.contains(player.getName()) && red.contains(damager.getName())){
 
                event.setCancelled(true);
 
            }
 
            if (blue.contains(player.getName()) && blue.contains(damager.getName())){
 
                event.setCancelled(true);
            }
        } else {
            if(event.getDamager() instanceof Arrow){
                Projectile arrow = (Projectile) event.getDamager();
                Entity shooter = (Entity) arrow.getShooter();
                if(shooter instanceof Player){
 
                    if(red.contains(((Player) shooter).getName()) && red.contains(event.getEntity())){
                        event.setCancelled(true);
                    }
 
                    if(blue.contains(((Player) shooter).getName()) && blue.contains(event.getEntity())){
                        event.setCancelled(true);
                    }
 
                }
            }
        }
    }

 

Bomp, this is kind of urgent :S

 

Zix What isn't working exactly?

 

Azubuso Players in the same array list can still hurt eachother

 

Bampity bamp

 

Bermp

 

Then do some debug -.-
Add in every "if" a System.out.println and check your Console. Let it print your list and check if Players are in.
When there isn't any logical fail in it, then it might be a bug, so you need to debug it. Everyone needs to do it.