Solved What am I missing here?

Hey,

So I'm making a simple region select wand using flint as an item.

This first wandMeta() method returns the meta displayed below.

Code:java

    public static ItemMeta wandMeta(){
        ItemStack wand = new ItemStack(Material.FLINT);
        ItemMeta wandMeta = wand.getItemMeta();
        List<String> loreList = new ArrayList<String>();
        loreList.add(Core.TAG+"Use this to select your Arena");
        wandMeta.setDisplayName(Core.TAG+"Wand §8(Left/Right Click)");
        wandMeta.setLore(loreList);
        return wandMeta;
    }
 

This method will give a Flint to the player with the above method's meta.

Code:java

 
 
    public void giveWand(Player player){
        if(player.getInventory().firstEmpty() == -1){
            player.sendMessage(Core.TAG+"Your backpack is full!");
            return;
        }
        ItemStack wand = new ItemStack(Material.FLINT);
        wand.setItemMeta(wandMeta());
        player.getInventory().addItem(wand);
        player.sendMessage(Core.TAG+"Left Click to select Pos1");
        player.sendMessage(Core.TAG+"Right Click to select Pos2");
        return;
    }

But my issue is that when I check for the meta on the item like so it doesn't work:
(This is just a test command)

Code:java

        if (args[0].equalsIgnoreCase("test")){
            if (player.getInventory().getItemInHand().getItemMeta() == wandMeta()){
                player.sendMessage("This is a wand.");
                return true;
            }
            player.sendMessage("This is not a wand.");
            return true;
        }

It always says "This is not a wand". Any suggestions?

Regards.

 

Code:java

 if (player.getInventory().getItemInHand().getItemMeta().equals(wandMeta())){

Should work.

 

RAFA_GATO_FOFO As michiletsplay said, you'll want to use ItemMeta#equals() to compare the 2 ItemMetas (ItemMeta overrides Object#equals() and does a check on its components such as name, lore, enchants, and others)

 

You should also check if the item in hands item meta isn't null.

Code:java

if(player.getItemInHand().getItemMeta()!=null){

 

NonameSL I don't believe ItemStack#getItemMeta() can return null (see CraftItemStack), it will make a new instance if it doesn't exist when ItemStack#getItemMeta() is called.

 

michiletsplay
That works fine, thanks a lot!

NonameSL
If a player decides to add a name to a flint it'll have Item Meta even though it's not a wand, so that's not the optimal way to go for me. Only because I'm not using permissions as of now.

 

RAFA_GATO_FOFO
I think he meant as an extra check (first check if item meta is not null, then check if it's equal to your wand meta). But I think xTigerRebornx is also correct in saying that itemmeta can't be null.

 

I said ADD the boolean to the if's, not replace it. Plus, a flint or any itemstack always has itemmeta, the check is just if the item is null.

 

NonameSL
This was fixed on Saturday, what's with you.