PrepareItemCraftEvent Bug

When I try cancelling the PrepareItemCraftEvent, it throws me an error. This is my code:

Code:java

@EventHandler(priority = EventPriority.HIGH)
public void onCraft(PrepareItemCraftEvent e) {
final ItemStack[] mat = e.getInventory().getMatrix();
if (e.getInventory().getResult().equals(setName(new ItemStack(Material.BREAD), ChatColor.WHITE + "Superbread", null))) {
if (mat[4].getType() == Material.SEEDS && mat[4].getItemMeta().getDisplayName().equals("Superseeds")) {
e.getInventory().setResult(setName(new ItemStack(Material.BREAD), ChatColor.WHITE + "Superbread", null));
} else {
e.getInventory().setResult(null);
}
}
}
 

Please help!

(I also tried with

Code:java

e.getInventory.setResult(new ItemStack(Material.Air))

)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

did you READ the error? did you understand it? what about it didn't you understand?

 

This is my error: http://pastebin.com/ZCGqpsNW
I'm fairly new to plugin development and I don't know how to decipher errors well but I know the error comes from line 8 in the code I showed.

 

is that line 105 of EatListener.java? can you post the full stack trace when you change it to

Code:

new ItemStack(Material.AIR)

 

It's line 110 of the class.

 

your error is coming from line 105

 

Line 105 is this:

Code:java

if (mat[3].getType() == Material.SEEDS && mat[3].getItemMeta().getDisplayName().equals("Superseeds")

 

Code:

.getItemMeta().getDisplayName()

Both of these method calls can return null. you need to check for null first.

 

Thank you, it works now!

 

You should check out what hasItemMeta and getItemMeta actually do, if I read correctly it will only return null for an air ItemStack.

 

You're right, getItemMeta will create a new instance if there isn't one defined. doesn't matter if it's air or not, any Itemstack. still best to check hasItemMeta first.

 

https://github.com/Bukkit/CraftBukk...aftbukkit/inventory/CraftItemFactory.java#L63

 

I stand corrected. in that case a null check should be done, because an empty slot in the crafting grid would be considered air. (or would be null even before that)