Spam from PlayerMoveEvent

hello this works exactly but 1 problem got spammed! with Heres your Regeneration! how to set a timer or something?

Code:java

private ArrayList<UUID> woolPlayers = new ArrayList<UUID>();   
    @EventHandler
    public void woolmove (PlayerMoveEvent e) {
        Block under = e.getPlayer().getLocation().getBlock().getRelative(BlockFace.DOWN);
    if(under.getType().equals(Material.EMERALD_BLOCK)) {
            e.getPlayer().sendMessage(ChatColor.GREEN + "Heres your Regeneration!");
            e.getPlayer().addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, 300, 10));
        }else if (woolPlayers.contains(e.getPlayer().getUniqueId())) {
            woolPlayers.remove(e.getPlayer().getUniqueId());
            e.getPlayer().removePotionEffect(PotionEffectType.REGENERATION);

 

Seeing as giving him the potion-effect will hardly do anything noteworthy if he already has the effect, why don't you just check if he already has the effect?

 

yeah but that gives none spam the spam is : Heres your regeneration! DxDy

 

please post javadocs from playermove event here, i will point with big red letters to words you missed.

 

Add them to a "regening" array list that adds people when they get the regen and then before you send the message make sure they're not in it. Then you can use a bukkit runnable if you want to remove them so they can regen again.

 

I think he knows that playerMoveEvent triggers extremely often. He doesn't know how to prevent it, though.

 

Bobit
In most cases such things prevented by logical expressions, that does not belong to bukkit and belong to generic (not ever coding) knowlage about boolean logic.

 

maybe i can set a timer? and how to do that? RawCode Bobit JBoss925 RawCode

 

Schaakmatth just put all the code in that event inside this if clause;

Code:java

if(!p.hasPotionEffect(PotionEffectType.REGENERATION)) {
//All of the code for the MoveEvent here...
}

 

@Schaakmatth

Code:java

 if (e.getFrom().getBlockX() == e.getTo().getBlockX() &&
e.getFrom().getBlockY() == e.getTo().getBlockY() && e.getFrom().getBlockZ() ==
e.getTo().getBlockZ()) {
return;
}
 
 

In most cases break out the method only if the player has actually moved from one block to another. This makes a massive difference. But if your case GeorgeeeHD has the perfect answer fro you.

 

True it may be that it doesn't belong to bukkit, he still doesn't know, and it's not easy for him to figure out...
Personally, I think it belongs to coding though.

 

Check out http://wiki.bukkit.org/Scheduler_Programming for scheduling a task.