Getting a mob?

Idk why but when I do this

Code:java

 @EventHandler
public void onDamage(EntityDamageEvent e) {
if(e.getEntity().equals(EntityType.VILLAGER)) {
e.setCancelled(true);
}

I can still hit the villager BUT any other mobs like creeper cannot damage me or zombies,spiders,skeletons... etc.

Someone Help?

 

VictoryShot

Code:java

if (e.getEntity().getType() == EntityType.VILLAGER)

i've never done any work with Entities, so i'm not 100% sure if they have a getType() method.

But I know that you'll have to convert your .equals() method to ==

 

try using EntityDamageEntityEvent

Code:java

 
if (e.getEntity().getType() == EntityType.VILLAGER) {
}
[/suntax]

 

VictoryShot You can do what Europia79 and thecrystalflame suggested, but it would be easier just to do:

Code:java

if(e.getEntity() instanceof Villager){
}

 

Well that works but like non-friendly mobs cant attack me or damage.
http://gyazo.com/8082ce25a06cfab6da68ad2a51ac2ca4

 

What're you trying to accomplish?

 

Actually I'm fully aware of this but it is less efficient and it's better practise to do it our way instead and no it's not easier its around the same amount of work

 

Europia79 You're right that the problem was that he wasn't checking the type. However, while I defend the use of == as opposed to .equals(), the fact is .equals() also works so you don't "have to" use == instead of .equals()

thecrystalflame Is it actually less efficient? I haven't done or seen any tests to check that either way, have you? And if he wants to stop all damage to the villager, EntityDamageEvent would clearly be the better option.

VictoryShot Do you have any other plugins? If you do, are they interfering with it? If you don't or if they're not, is another part of your plugin interfering with it?

 

AdamQpzm

you bring up a good point... That another plugin could be interfering with his Event. I had this happen to me. I was able to fix it by changing the priority:

Code:java

@EventHandler (priority=EventPriority.HIGHEST)
public void onSomeEvent(SomeEvent e) {}