KitPvP kits issue

Discussion in 'Plugin Development' started by DMDO1599, Apr 29, 2014.

Thread Status:
Not open for further replies.
  1. Offline

    DMDO1599

    ok so the issue is that every time i do /pvp it works perfectly but when i do /ck or /archer OR /viper it wont work i need help and fast plz
    Code:java
    1. package me.DMDO1599.Listener;
    2.  
    3. import java.util.ArrayList;
    4. import java.util.HashMap;
    5. import java.util.List;
    6.  
    7. import me.DMDO1599.main;
    8.  
    9. import org.bukkit.ChatColor;
    10. import org.bukkit.Material;
    11. import org.bukkit.command.Command;
    12. import org.bukkit.command.CommandExecutor;
    13. import org.bukkit.command.CommandSender;
    14. import org.bukkit.enchantments.Enchantment;
    15. import org.bukkit.entity.Player;
    16. import org.bukkit.event.Listener;
    17. import org.bukkit.inventory.ItemStack;
    18. import org.bukkit.inventory.PlayerInventory;
    19.  
    20. public class Kits implements Listener, CommandExecutor{
    21.     List<String> usedkit =new ArrayList<String>();
    22.     public HashMap<String, String> kit = new HashMap();
    23.  
    24. private main plugin;
    25.  
    26.     public Kits(main instance){
    27.         this.plugin =instance;
    28.         this.plugin.getServer().getPluginManager().registerEvents(this, this.plugin);
    29.  
    30.     }
    31.  
    32. public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
    33.  
    34.         final Player p = (Player)sender;
    35.         final PlayerInventory pi = p.getInventory();
    36.         ItemStack dsword = new ItemStack(Material.DIAMOND_SWORD);
    37.         ItemStack isword = new ItemStack(Material.IRON_SWORD);
    38.         ItemStack ssword = new ItemStack(Material.STONE_SWORD);
    39.         ItemStack bow = new ItemStack(Material.BOW);
    40.  
    41.         if (cmd.getName().equalsIgnoreCase("pvp")){
    42.             if(usedkit.contains(p.getName())){
    43.                 p.sendMessage(ChatColor.RED + "You aready have a kit!");
    44.             }else{               
    45.             p.sendMessage(ChatColor.GOLD + "You got the PvP Kit!");
    46.             if(p.hasPermission("plusk.pvp")){
    47.                 usedkit.add(p.getName());
    48.                 pi.clear();
    49.                 dsword.addEnchantment(Enchantment.DAMAGE_ALL, 1);
    50.                 pi.addItem(dsword);
    51.                 pi.setHelmet(new ItemStack(Material.IRON_HELMET));
    52.                 pi.setChestplate(new ItemStack(Material.IRON_CHESTPLATE));
    53.                 pi.setLeggings(new ItemStack(Material.IRON_LEGGINGS));
    54.                 pi.setBoots(new ItemStack(Material.IRON_BOOTS));
    55.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    56.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    57.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    58.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    59.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    60.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    61.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    62.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    63.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    64.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    65.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    66.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    67.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    68.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    69.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    70.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    71.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    72.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    73.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    74.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    75.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    76.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    77.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    78.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    79.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    80.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    81.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    82.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    83.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    84.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    85.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    86.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    87.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    88.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    89.                 pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));   
    90.                 }
    91.             if (cmd.getName().equalsIgnoreCase("archer")){
    92.                 p.sendMessage("Test");
    93.                 if(usedkit.contains(p.getName())){
    94.                     p.sendMessage(ChatColor.RED + "You aready have a kit!");   
    95.                 }else{
    96.                 p.sendMessage(ChatColor.GOLD + "You got the Archer Kit!");
    97.                 if(p.hasPermission("plusk.archer")){
    98.                     usedkit.add(p.getName());
    99.                     pi.clear();
    100.                     bow.addEnchantment(Enchantment.ARROW_DAMAGE, 1);
    101.                     bow.addEnchantment(Enchantment.ARROW_INFINITE, 1);
    102.                     isword.addEnchantment(Enchantment.DAMAGE_ALL, 1);
    103.                     pi.addItem(dsword);
    104.                     pi.setHelmet(new ItemStack(Material.CHAINMAIL_HELMET));
    105.                     pi.setChestplate(new ItemStack(Material.LEATHER_CHESTPLATE));
    106.                     pi.setLeggings(new ItemStack(Material.LEATHER_LEGGINGS));
    107.                     pi.setBoots(new ItemStack(Material.IRON_BOOTS));
    108.                     pi.addItem(bow);
    109.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    110.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    111.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    112.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    113.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    114.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    115.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    116.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    117.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    118.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    119.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    120.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    121.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    122.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    123.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    124.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    125.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    126.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    127.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    128.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    129.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    130.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    131.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    132.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    133.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    134.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    135.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    136.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    137.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    138.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    139.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    140.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    141.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    142.                     pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));   
    143.                     }
    144.                 if (cmd.getName().equalsIgnoreCase("viper")){
    145.                     this.kit.put(p.getName(), "viper");
    146.                     if(usedkit.contains(p.getName())){
    147.                         p.sendMessage(ChatColor.RED + "You aready have a kit!");   
    148.                     }else{
    149.                     p.sendMessage(ChatColor.GOLD + "You got the Viper Kit!");
    150.                     if(p.hasPermission("plusk.viper")){
    151.                         usedkit.add(p.getName());
    152.                         pi.clear();
    153.                         ssword.addEnchantment(Enchantment.DAMAGE_ALL, 1);
    154.                         pi.addItem(ssword);
    155.                         pi.setHelmet(new ItemStack(Material.LEATHER_HELMET));
    156.                         pi.setChestplate(new ItemStack(Material.CHAINMAIL_CHESTPLATE));
    157.                         pi.setLeggings(new ItemStack(Material.IRON_LEGGINGS));
    158.                         pi.setBoots(new ItemStack(Material.GOLD_BOOTS));
    159.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    160.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    161.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    162.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    163.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    164.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    165.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    166.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    167.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    168.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    169.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    170.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    171.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    172.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    173.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    174.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    175.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    176.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    177.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    178.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    179.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    180.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    181.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    182.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    183.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    184.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    185.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    186.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    187.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    188.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    189.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    190.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    191.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    192.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));
    193.                         pi.addItem(new ItemStack(Material.MUSHROOM_SOUP));   
    194.                         }
    195.             if(cmd.getName().equalsIgnoreCase("ck")) {
    196.                 if(p.hasPermission("plusk.ck")){
    197.                 }else{   
    198.                     p.sendMessage(ChatColor.GOLD + "You have succesfully cleared your kit!");
    199.                     p.getInventory().clear();
    200.                     pi.setHelmet(new ItemStack(Material.AIR));
    201.                     pi.setChestplate(new ItemStack(Material.AIR));
    202.                     pi.setLeggings(new ItemStack(Material.AIR));
    203.                     pi.setBoots(new ItemStack(Material.AIR));
    204.                     usedkit.remove(p.getName());
    205.                 }
    206.             }
    207.         }
    208.     }
    209. }
    210. }}
    211. }
    212.         return false;}}
    213.  
     
    DMDO1599, Apr 29, 2014
    #1
  2. Offline

    The Fancy Whale

    You should really make a method for adding kits... but do you get an error?
     
    The Fancy Whale, Apr 29, 2014
    #2
  3. Offline

    Derpiee

    You have your if statements for the command checking in the if statement that checks if the command is pvp.
     
    Derpiee, Apr 29, 2014
    #3
  4. Offline

    WarderLolz

    Yep, you are checking if the command equals to "viper" / "ck" / "archer" in the if that checks if the command is "pvp". Also, when you check if the players as already a kit you should add a return statement after sending the message

    Code:java
    1. if(usedkit.contains(p.getName())){
    2. p.sendMessage(ChatColor.RED + "You aready have a kit!");
    3. return true;
    4. }


    Another thing, when giving the player soups you should use a for loop instead of 35 lines of code
    Code:java
    1. for(ItemStack i : p.getInventory().getContents())
    2. {
    3. if(i == null)
    4. p.getInventory().addItem(new ItemStack(Material.MUSHROOM_SOUP));
    5. }


    And whenever you do /viper your name is added to the hashmap again, even if you have a kit
     
    WarderLolz, Apr 30, 2014
    #4
Thread Status:
Not open for further replies.

Share This Page