Solved Getting a List from a seperate Class

Hi, I have this really annoying problem. You see, I can't seem to pass any information about an List<String> in one class to the other. I am trying to set it so that when a player places a sign with certain stuff on it, it sets the 3rd line to [sizeofplayersindungeon/maxplayers]. I can show the size of any List in that specific class, but not the size of the List in my seperate class. Here is my code:

Code:java

//Class with the SignChangeEvent(Dungeons)
@EventHandler
public void onSignChange(SignChangeEvent sign) {
    Player p = sign.getPlayer();
    String dName = sign.getLine(1);
    if (p.isOp()) {
        if (sign.getLine(0).equalsIgnoreCase("Dungeons"));
        sign.setLine(0, ChatColor.BOLD + "Dungeons");
        DungeonManager d = getDungeon(dName);
        sign.setLine(2,ChatColor.DARK_BLUE + "[" + d.getPlayers()".size + "/" + d.getMaxPlayers() + "]");
    }else{
 
    }
}

Then, I use this List and a few method to get its information in another class:

Code:java

//Other class with List and methods:
//List
private List<String> players;
//Methods:
}
        public void addPlayer(Player p) {
            String name = p.getName();
            players.add(name);
        }
        public void removePlayer(Player p) {
            String name = p.getName();
            players.remove(name);
        }
        public boolean hasPlayer(Player p) {
            if (getPlayers().contains(p.getName())) {
                return true;
            }else{
                return false;
            }
        }
 
public List<String> getPlayers() {
            return players;
        }

 

_Belknap_
Lol the List is Private it needs to be public for other classes to access it
so replace public with public static

 

ko47374737
Lol I already tried that but I'll try it again

Lol I am dying here I did this:

Code:java

public ArrayList<String> players;

Instead of this:

Code:java

ArrayList<String> players = new ArrayList<String>

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

_Belknap_

The getPlayers method will work fine for getting the list, looks like your error is line 10 in the event code.

You've put:

Code:java

sign.setLine(2,ChatColor.DARK_BLUE + "[" + d.getPlayers()".size + "/" + d.getMaxPlayers() + "]");

Instead, try:

Code:java

sign.setLine(2,ChatColor.DARK_BLUE + "[" + d.getPlayers().size() + "/" + d.getMaxPlayers() + "]");

Hope that helps.

 

This is bad advice.

@OP

You should provide a "getter" for your List: https://forums.bukkit.org/threads/using-a-string-in-different-classes.184140/#post-1916182

 

1Rogue
lol getPlayers() is my getter is there anything wrong with it that I can change?
gorbb
Lol sry that was a typo

 

Depends, if you really want to have control over the list, I would make it unmodifiable outside the class and create aggregate functions for adding/removing:

Code:java

private final List<String> players; //set how you like
 
public List<String> getPlayers() {
    return Collections.unmodifiableList(this.players);
}
 
public void addPlayer(String player) {
     this.players.add(player);
}
 
public boolean removePlayer(String player) {
    return this.players.remove(player);
}

 

Very, very bad idea. Do you even understand what static is?

 

Ugh...