Multiple Horses bug help please

I am getting so far with creating my own plugin and the plugin is to allow people to either choose with the saddle a white horse and when they dismount they get the item back or use the gold_record(music disk "13") which would give them a gray horse and when they dismount they get that back.

The error is when they use the gold_record and then dismount off the horse it gives them the saddle instead which then they can use to get the white horse instead please help.


The code is in a pastebin link:
http://pastebin.com/UP3urqQW

 

Use these event listeners ...Sorry about the formatting.

Code:java

@EventHandler
public void onPlayerInteractEvent(PlayerInteractEvent e) {
Player p = e.getPlayer();
 
//check for the item that was used.
if (e.getAction().equals(Action.RIGHT_CLICK_AIR) || e.getAction().equals(Action.RIGHT_CLICK_BLOCK)) {
if (p.getItemInHand() == new ItemStack(Material.SADDLE)) {
if (p.hasPermission("horse.use")) {
Horse h = (Horse) p.getWorld().spawnEntity(p.getLocation(), EntityType.HORSE);
h.setOwner(p);
h.getInventory().setSaddle(new ItemStack(Material.SADDLE, 1));
h.setCustomName(ChatColor.BOLD + "" + ChatColor.GOLD + p.getName() + "'s Horse.");
h.setCustomNameVisible(true);
 
p.getInventory().remove(Material.SADDLE);
}
}
else if (p.getItemInHand() == new ItemStack(Material.GOLD_RECORD)) {
if (p.hasPermission("grayhorse.use")) {
Horse h = (Horse) p.getWorld().spawnEntity(p.getLocation(), EntityType.HORSE);
h.setOwner(p);
h.getInventory().setSaddle(new ItemStack(Material.SADDLE, 1));
h.setCustomName(ChatColor.BOLD + "" + ChatColor.GOLD + p.getName() + "'s Horse.");
h.setCustomNameVisible(true);
h.setColor(Color.GRAY);
 
p.getInventory().remove(Material.GOLD_RECORD);
}
}
}
}
 
@EventHandler
public void removemount(VehicleExitEvent e){
Player p = (Player) e.getExited();
if (e.getVehicle() instanceof Horse) {
Horse h = (Horse) e.getVehicle();
if (h.getColor() == Color.WHITE) {
if (p.hasPermission("horse.use")) {
h.remove();
p.getInventory().addItem(new ItemStack(Material.SADDLE));
}
}
else if (h.getColor() == Color.GRAY) {
if (p.hasPermission("grayhorse.use")) {
h.remove();
p.getInventory().addItem(new ItemStack(Material.GOLD_RECORD));
}
}
}
}

 

Well first off, you do not have to have to separate VehicleExitEvent into two events like that, you can have both blocks of code in 1. Also when working with permissions you should understand that when you are op you have EVERY permission. So make sure you are not opped while testing. If permissions wasn't your issue, you do not have the @Eventhandler tag on your second VehicleExitEvent.

 

Even while using this code it still gives me the saddle instead of the gold_record when i dismount the gray horse so i don't know

I have took that into mind but the code Hsflxz gave me isn't working as it still gives me the wrong item on dismount on the gray horse.

 

ijakgamez I have just copied the exact code that he gave you and tested it and it works perfectly fine. This 100% an issue on your end with permissions.

Also a quick tip, add this after you have set all of the horse preferences:

Code:java

                    h.setPassenger(p);
 

It will automatically put you on the horse.(If that's what you would like of course.)

 

May I ask how you have your permissions setup so o can see where I am going wrong exactly

 

What permissions plugin do you use? I literally just created two groups with each permission node on them.

 

You need to store the information somewhere that tells what item they used to set the color. Using permissions is not the best idea because someone users may have multiple permissions. When multiple permissions happen the first one they have in the code will run no matter what and thats that.

1) User clicks horse with item.
2) Store info somewhere (global/static vars, yml, etc)
3) Perform the actions
4) User gets off horse
5) Check stored data
6) Act accordingly

Ignore this. I misread the code due to lack of indentions.

 

Shouldn't matter about permissions, the code is based off of the Color variable from the horse... If you have the permission for that Color, it'll drop the corresponding item.... By the way, ehen you register your permissions in plugin.yml, you can set default: op so you can take out the if (p.isOP()) checks

 

So sorry, misread the code due to lack of indentions.

I placed the code into Eclipse and got an error about the == operand on the color checks. I replaced with .equals() and the error went away. Might want to give that a try..

Code:java

 
if (h.getColor().equals(Color.WHITE)) {
 

 

i am using group manager

I tried only having two groups but that never worked I could not spawn them in at all when right clicking so I don't know what I have done

EDIT by Moderator: merged posts, please use the edit button instead of double posting.