EntityDamage Problem

There's a problem with my code (duh). I'm trying to get it so if you shoot a horse with an arrow and it has iron armor, the shot will be deflected. If the horse is wearing diamond armor, it can deflect arrows and fire will not effect it.

However, it's not detecting the damage the right way.

Code:javascript

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
 
package com.hand.Race;
 
import org.bukkit.Material;
import org.bukkit.Sound;
import org.bukkit.entity.Entity;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Horse;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.inventory.ItemStack;
 
/**
 *
 * @author Robert
 */
public class Damage implements Listener
{
    public static Main plugin;
    public Damage(Main ins)
    {
        Damage.plugin = ins;
    }
 
    @EventHandler
    public static void onDamage(EntityDamageEvent event)
    {
        Entity e = event.getEntity();
        Horse h = (Horse) event.getEntity();
        Player p = (Player) h.getPassenger();
        p.sendMessage("Notifier: Some entity was injured.");
 
        if(e.equals(EntityType.HORSE))
        {
            p.sendMessage("Notifier: A horse was injured.");
            if(h.getInventory().getArmor().equals(new ItemStack(Material.IRON_BARDING)) && event.getCause() == EntityDamageEvent.DamageCause.PROJECTILE)
            {
                p.playSound(p.getLocation(), Sound.ANVIL_LAND, 1, 1);                                                            
 
                event.setCancelled(true);
 
            }
            if(h.getInventory().getArmor().equals(new ItemStack(Material.DIAMOND_BARDING)))
            {
                if (event.getCause() == EntityDamageEvent.DamageCause.PROJECTILE || h.getFireTicks() != 0 || event.getCause() == EntityDamageEvent.DamageCause.FIRE_TICK) 
                {
                    p.playSound(p.getLocation(), Sound.ANVIL_LAND, 1, 1);
                    h.setFireTicks(0);
                    event.setCancelled(true);
                }
 
            }
 
        }        
    }
}
 

I only ever get the notifier for general entity damage if I set the horse on fire. I don't get the other notifier that's supposed to go off if a horse is damaged. Should I just use another event?
Thanks.

 

TheHandfish If I'm reading this correctly (Probably not, it's 11:30), but you're casting 'Horse' to the damaged entity before you check that it is a horse. And you're also assuming that there is a rider, which, in case there might not be, because the entity isn't even a horse! It wouldn't send the message if the rider was a null pointer exception.

 

ZapChance is right.

For the

Code:

if (e.equals(EntityType.HORSE)) {

Change it to:

Code:

if (e instanceof Horse) {

And make sure to cast

Code:

Horse h = (Horse) e.getEntity();

after you do the if statement for instanceof Horse.

Player p = (Player) h.getPassenger(); as well, put that after instanceof Horse if statement.

 

ZapChance and Qwahchees:

Thanks, but I'm still getting an error. I've traced it to:

Code:

EntityDamageEvent.DamageCause.PROJECTILE

I don't think that's being recognized when I shoot the horse with an arrow.

 

TheHandfish I believe your reason for that is that you're attempting to shoot the arrow at the horse and send a notification to the passenger, when there most likely isn't a passenger.

 

ZapChance:

I put in notifiers for when the horse is shot, and they show up. What do you suggest I do?

 

Switch to EntityDamageByEntityEvent

EntityDamageEvent.getEntity() - returns the attacker.

 

Blackveil:

Wait it does? I thought it returns the entity being damaged. o_o

Still getting issues. Ran a notifier to tell me what entity is harming the horse, and I get "ARROW" if I shoot it with a bow...

Code:

I have: if(a instanceof Arrow)

Where

Code:

Entity a = event.getDamager();

But it never goes with the instance that the entity is an arrow, even if it says the entity I'm shooting it with is an arrow...

Just to recap, here's what I've got.

Code:javascript

 
    public static void onDamage(EntityDamageByEntityEvent event)
    {
        Entity e = event.getEntity();
        //plugin.getServer().broadcastMessage("Notifier: Some entity was injured.");
 
        if (e instanceof Horse) 
        {
        Horse h = (Horse) e;
        Player p = (Player) h.getPassenger();
        Entity a = event.getDamager();
            plugin.getServer().broadcastMessage("Notifier: A horse was injured. " + a.getType());
 
            if(h.getInventory().contains(new ItemStack(Material.IRON_BARDING)) && a instanceof Arrow)
            {
                p.playSound(p.getLocation(), Sound.ANVIL_LAND, 1, 1);                                                            
            plugin.getServer().broadcastMessage("Notifier: Deflecting!");
 
                event.setCancelled(true);
 
            }
            if(!(a instanceof Arrow))
            {
                plugin.getServer().broadcastMessage("Wasn't an arrow!");
            }
            else
            {
                plugin.getServer().broadcastMessage("WAS an arrow!");
            }
            if(!h.getInventory().contains(new ItemStack(Material.IRON_BARDING)) && !h.getInventory().contains(new ItemStack(Material.DIAMOND_BARDING)))
            {
                plugin.getServer().broadcastMessage("Wasn't wearing horse armor!");
 
            }
            if(h.getInventory().contains(new ItemStack(Material.DIAMOND_BARDING)))
            {
                if (a instanceof Arrow || h.getFireTicks() != 0 || event.getCause() == EntityDamageEvent.DamageCause.FIRE_TICK) 
                {
                    p.playSound(p.getLocation(), Sound.ANVIL_LAND, 1, 1);
                    h.setFireTicks(0);
                    event.setCancelled(true);
                }
 
            }
 
        }        
    }
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.