RemoveItem/AddItem Glitch? Help

Code:java

package me.Darko111.Eagle;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class MainEagle extends JavaPlugin implements Listener {
    public void onEnable() {
        Bukkit.getServer().getPluginManager().registerEvents(this,this);
    }
    public void onDisable() {
 
    }
    ArrayList<String> cooldown = new ArrayList<String>();
    @EventHandler
    public void onPlayerRightClick(final PlayerInteractEvent e) {
        if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK) {
            if(e.getPlayer().getItemInHand().getType() == Material.FEATHER) {
                if(cooldown.contains(e.getPlayer().getName())) {
                    e.getPlayer().sendMessage(ChatColor.RED+"You're still too tired to fly.");
                }
                else {
                    e.getPlayer().sendMessage(ChatColor.AQUA+"You are now flying!");
                    e.getPlayer().setAllowFlight(true);
                    e.getPlayer().setFlying(true);
                    e.getPlayer().getInventory().remove(Material.FEATHER);
                    e.getPlayer().getInventory().addItem(new ItemStack(Material.FIREWORK_CHARGE,1));
                    cooldown.add(e.getPlayer().getName());
                    Bukkit.getScheduler().scheduleSyncDelayedTask(this,new Runnable()
                    {
                        public void run() {
                            cooldown.remove(e.getPlayer().getName());   
                        }
                    }
                    ,200);
                }
            }
            if(e.getPlayer().getItemInHand().getType() == Material.FIREWORK_CHARGE) {
 
                e.getPlayer().sendMessage(ChatColor.AQUA+"You are no longer flying!");
                e.getPlayer().setAllowFlight(false);
                e.getPlayer().setFlying(false);
                e.getPlayer().getInventory().remove(Material.FIREWORK_CHARGE);
                e.getPlayer().getInventory().addItem(new ItemStack(Material.FEATHER,1));
            }
        }
    }
}
 

I coded it so whenever I right click a feather, it allows me to fly, removes the feather, and adds a firework charge, and whenever I right click a firework charge, it stops the flying, removes the firework charge, and gives me the feather back.

Now the problem is:

Whenever I right click the feather, it doesn't get removed, the firework charge doesn't get added, and it says "You are now flying" and "You are no longer flying" at the same time..

I would really appreciate some help here .

 

Hey
I am not very good in Java or English, but I'll try to help you. I think problem is that when you click, it give you item and enable flying, thats okay, but then it checks for that item you just got and remove all that.
Just use "else" before checking if player has firework_charge..

 

That's because both if statements launch one after the other. You need to stop the function as soon as it finishes one or the other, or add an else statment. Currently, your code finds the feather, allows flight, removes feather, puts firework, detects firework, removes firework, stops flight and gives feather, all in one breath

 

Yah, try adding a return; statement at the end of each if statement to stop each if statement from overlapping each other like @Zethariel said.