Cauldrons problems

Ok, I want it so that after someone presses the cauldron with the bucket, it emptys the cauldron.

Code I have at the minute:

Code:java

if (player.getItemInHand().getType() == Material.BUCKET && event.getAction() == Action.RIGHT_CLICK_BLOCK && event.getClickedBlock().getType() == Material.CAULDRON) {
            Cauldron block = (Cauldron) event.getClickedBlock().getState().getData();
            if (block.isFull()) {
                player.getInventory().remove(new ItemStack(Material.BUCKET));
                player.getInventory().addItem(new ItemStack(Material.WATER_BUCKET));
                block.setData((byte) 0);
                player.updateInventory();
                return;
            } else {
                return;
            }
        }

It lets them fill the bucket but the cauldron does not empty.
Thanks in advance

 

callum.thepro

Have you experimented with different values for block.setData()? If I remember correctly, higher values may correspond to an empty cauldron, with 0 meaning full.

 

Hoolean callum.thepro Constants for what the values of empty and full are in the Cauldron class

 

xTigerRebornx

And so they are! Those should definitely be used preferably. Looking at that, it sure looks like 0 does mean empty.

However, callum.thepro , I think I know what the problem is. When doing Block.getState(), it gets a fixed snapshot of the Block, which will not be changed by modifications.

Try changing:

Code:

Cauldron block = (Cauldron) event.getClickedBlock().getState().getData();

to:

Code:

Cauldron block = (Cauldron) event.getClickedBlock().getData();

 

Hoolean Well, he needs the MaterialData from the BlockState to be able to cast it to a Cauldron, couldn't he just update the BlockState instead?

 

xTigerRebornx

Sorry, this line:

Code:

use block.getState() to get a snapshot state of a block which will not be modified.

...in the JavaDocs confused me, perhaps I should not be awake at this hour.

 

Hoolean I believe that is saying that the state will not be modified by Bukkit, but you are able to manipulate it and then apply an update

 

I cannot apply an update as I use the blocks data. Either that or it did not work. If I do not use .getData() then it simply breaks and gives me a classCastException

xTigerRebornx Hoolean Bump

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

callum.thepro You need to apply an update to set the changes you've done to that BlockState.
An idea for solving this could be setting the Block's type to air then back to Cauldron.

 

get location of clicked block(full cauldron), remove clicked block (full cauldron), put new cauldron there...

 

xTigerRebornx I have tried doing that, but for some reason, that does not work either. I thought that was strange.