Permissions System

Alright, so I'm working on my own permissions system. I haven't tested the script yet, but I want to see if there's anything I'm missing out of these two basic classes. Please be aware that I have it in my other scripts, but my Permissions Manager does exist too, I just have not put the code up.

Group.java

Show Spoiler Hide Spoiler

Code:java

/*
* This plugin is licensed and owned by (myself) Blackveil also as known as Blackveiled
* It is free to use, however no support nor database schemas are available
* from (myself) Blackveil, you are responsible for maintaining your server's database
* and keeping it up to date as new releases are given, and just to warn you again
* I do NOT offer support for this plugin, you must modify everything yourself to
* use it for your own experiments or Minecraft servers.
*/
 
package com.blackveiled.roc.permissions;
import com.blackveiled.roc.RealmOfConquest;
import com.blackveiled.roc.player.Character;
import java.util.UUID;
import java.util.HashMap;
import java.util.Map;
import java.util.List;
import java.util.ArrayList;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.command.CommandSender;
 
public class Group {
public String name = null;
public String prefix = null;
public String suffix = null;
public String error = null;
public Map<String, Permission> permissions = new HashMap<String, Permission>();
public List<String> groups = new ArrayList<String>();
public List<UUID> players = new ArrayList<UUID>();
/**s
* @param Name String value is required to set a name for the Group object.
*/
public Group(String Name) {
this.name = Name;
}
 
/**
* @return The name of the group you have selected. If the group you selected does not exist, you will receive a NullPointerException.
*/
public String getName() {
return this.name;
}
/**
* @return The plugin will verify if the player who executed the command is a part of this group and if the permission exists as well as if all the permissions requirements are fulfilled.
* @param s - CommandSender required
* @param node - Permission node required
*/
public boolean hasPermission(Player p, String node) {
// If player is an operator, they will automatically have permission for whatever they do.
if(p.isOp()) {
return true;
}// To avoid NullPointerException anyways, if no players are in the group then this will return false.
if(!this.players.isEmpty()) {
return false;
}
UUID uuid = p.getUniqueId();// Check if the player exists in the group. If they do, carry on.
if(!this.players.contains(uuid)) {
return false;
}
if(RealmOfConquest.Characters.containsKey(p.getName())) {
Character character = RealmOfConquest.Characters.get(p.getName());
if(character.permissions.containsKey(node)) {
Permission permission = character.permissions.get(node);
if(permission.getPermissionLevel()==true) {// If this permission is not set to any particular world, then return true.
if(permission.getPermissionWorld()==null) {
return true;
}// If the command sender is in the required world, then return true.
if(permission.getPermissionWorld().equalsIgnoreCase(p.getWorld().getName())) {
return true;
}
}
}
}
// Check if the group even has permissions to avoid NullPointerException
if(this.permissions.isEmpty()) {
return false;
}// Check if the permission node exists inside of the group's permissions.
if(this.permissions.containsKey(node)) {
Permission permission = this.permissions.get(node);
if(permission.getPermissionLevel()==true) {
// If this permission is not set to any particular world, then return true.
if(permission.getPermissionWorld()==null) {
return true;
}// If the command sender is in the required world, then return true.
if(permission.getPermissionWorld().equalsIgnoreCase(p.getWorld().getName())) {
return true;
}
}
}
// Check if the group even has groups to inherit permissions from.
if(!this.groups.isEmpty()) {
for(int i = 0; i < this.groups.size(); i++) {
String groupname = this.groups.get(i);
// Check if the server's global groups even contains the group inside.
if(PermissionManager.Groups.containsKey(groupname)) {
Group group = PermissionManager.Groups.get(groupname);
if(group.permissions.containsKey(node)) {
Permission permission = this.permissions.get(node);
if(permission.getPermissionLevel()==true) {
// If this permission is not set to any particular world, then return true.
if(permission.getPermissionWorld()==null) {
return true;
}// If the command sender is in the required world, then return true.
if(permission.getPermissionWorld().equalsIgnoreCase(p.getWorld().getName())) {
return true;
}
}
}
}
}
}
return false;
}
/**
* @return The plugin will verify if this whoever executed the command is a part of this group and if the permission exists as well as if all the permissions requirements are fulfilled.
* @param s - CommandSender required
* @param node - Permission node required
*/
public boolean hasPermission(CommandSender s, String node) {
// If player is an operator, they will automatically have permission for whatever they do.
if(s.isOp()) {
return true;
}// To avoid NullPointerException anyways, if no players are in the group then this will return false.
if(!this.players.isEmpty()) {
return false;
}
if(s instanceof Player) {
Player p = (Player) s;
UUID uuid = p.getUniqueId();// Check if the player exists in the group. If they do, carry on.
if(!this.players.contains(uuid)) {
return false;
}
if(RealmOfConquest.Characters.containsKey(p.getName())) {
Character character = RealmOfConquest.Characters.get(p.getName());
if(character.permissions.containsKey(node)) {
Permission permission = character.permissions.get(node);
if(permission.getPermissionLevel()==true) {
if(s instanceof Player) {// If this permission is not set to any particular world, then return true.
if(permission.getPermissionWorld()==null) {
return true;
}// If the command sender is in the required world, then return true.
if(permission.getPermissionWorld().equalsIgnoreCase(p.getWorld().getName())) {
return true;
}
}
}
}
}
}// Check if the group even has permissions to avoid NullPointerException
if(this.permissions.isEmpty()) {
return false;
}// Check if the permission node exists inside of the group's permissions.
if(this.permissions.containsKey(node)) {
Permission permission = this.permissions.get(node);
if(permission.getPermissionLevel()==true) {
if(s instanceof Player) {
Player p = (Player) s;// If this permission is not set to any particular world, then return true.
if(permission.getPermissionWorld()==null) {
return true;
}// If the command sender is in the required world, then return true.
if(permission.getPermissionWorld().equalsIgnoreCase(p.getWorld().getName())) {
return true;
}
}
}
}// Check if the group even has groups to inherit permissions from.
if(!this.groups.isEmpty()) {
for(int i = 0; i < this.groups.size(); i++) {
String groupname = this.groups.get(i);
// Check if the server's global groups even contains the group inside.
if(PermissionManager.Groups.containsKey(groupname)) {
Group group = PermissionManager.Groups.get(groupname);
if(group.permissions.containsKey(node)) {
Permission permission = this.permissions.get(node);
if(permission.getPermissionLevel()==true) {
if(s instanceof Player) {
Player p = (Player) s;// If this permission is not set to any particular world, then return true.
if(permission.getPermissionWorld()==null) {
return true;
}// If the command sender is in the required world, then return true.
if(permission.getPermissionWorld().equalsIgnoreCase(p.getWorld().getName())) {
return true;
}
}
}
}
}
}
}
return false;
}
/**
* @return An attempt will be made to add a permission to the group. A boolean value is returned if it was successfully added to the group.
* @param Permission Permission object is required to be added to the Group object.
*/
public boolean addPermission(Permission Permission) {
if(this.permissions.containsKey(Permission.getPermission())) {
this.error = "This group already has that permission!";
return false;
}
this.permissions.put(Permission.getPermission(), Permission);
this.error = "Successfully added permission to group!";
return true;
}
/**
* @return An attempt will be made to remove a permission to the group. A boolean value is returned if it was successfully removed from the group.
* @param Permission Permission object is required to be added to the Group object.
*/
public boolean removePermission(Permission Permission) {
if(this.permissions.containsKey(Permission.getPermission())) {
this.permissions.remove(Permission.getPermission());
this.error = "Successfully removed permission from group!";
return true;
}
this.error = "This group does not have those permissions!";
return false;
}
/**
* @return An attempt will be made to add a group to inherit permissions from. A boolean value is returned if it was successfully added to the group.
* @param Group Group object is required to add an inheritance.
*/
public boolean addGroup(String Group) {
if(this.groups.contains(Group)) {
this.error = "This group already inherits the selected group!";
return false;
}
if(PermissionManager.Groups.containsKey(Group)) {
this.groups.add(Group);
this.error = "Successfully added "+Group+" to "+this.getName()+"!";
return true;
}
this.error = "That group does not exist!";
return false;
}
/**
* @return An attempt will be made to remove a group inheritance. A boolean value is returned if it was successfully removed from the group.
* @param Group Group object is required to remove an inheritance.
*/
public boolean removeGroup(String Group) {
if(this.groups.contains(Group)) {
this.groups.add(Group);
this.error = "Successfully removed the group "+Group+" from group "+this.getName()+"!";
return true;
}
this.error = "That group does not exist inside of this group!";
return false;
}
/**
* @return Returns a string with the chat colors stripped from the original string. Null if no prefix has been set.
*/
public String getPrefix() {
String output = ChatColor.stripColor(this.prefix);
return output;
}
/**
* @return Returns a string with the chat colors stripped from the original string. Null if no suffix has been set.
*/
public String getSuffix() {
String output = ChatColor.stripColor(this.suffix);
return output;
}
/**
* @return Returns a string with the chat colors if the prefix has them. Null if no prefix has been set.
* [USER=13316]error[/USER] NullPointerException if a prefix has not been set.
*/
public String getFullPrefix() {
String output = ChatColor.translateAlternateColorCodes('&', this.prefix);
return output;
}
/**
* @return Returns a string with the chat colors if the suffix has them. Null if no suffix has been set.
*/
public String getFullSuffix() {
String output = ChatColor.translateAlternateColorCodes('&', this.suffix);
return output;
}
/**
* @return Returns a string of the last error message sent from the group class selected.
*/
public String getLastError() {
return this.error;
}
 
}
 

Permission.java

Show Spoiler Hide Spoiler

Code:java

/*
* This plugin is licensed and owned by (myself) Blackveil also as known as Blackveiled
* It is free to use, however no support nor database schemas are available
* from (myself) Blackveil, you are responsible for maintaining your server's database
* and keeping it up to date as new releases are given, and just to warn you again
* I do NOT offer support for this plugin, you must modify everything yourself to
* use it for your own experiments or Minecraft servers.
*/
 
package com.blackveiled.roc.permissions;
 
public class Permission {
public String name = null;
public String node = null;
public String world = null;
public boolean level = false;
 
 
 
public Permission(String node, boolean level) {
this.node = node;
this.level = level;
}
public Permission(String node, boolean level, String world) {
this.node = node;
this.level = level;
this.world = world;
}
public Permission(String name, String node, boolean level) {
this.name = name;
this.node = node;
this.level = level;
}
public Permission(String name, String node, boolean level, String world) {
this.name = name;
this.node = node;
this.level = level;
this.world = world;
}
/**
* @return The permission node of the permission you selected. Returns a string value, null if no node exists.
*/
public String getPermission() {
return this.node;
}
 
/**
* @return The name of the permission you have selected. Returns a string value, null if no name exists.
*/
public String getPermissionName() {
return this.name;
}
 
/**
* @return The permission level of the permission you selected. Returns a boolean value, true or false.
*/
public boolean getPermissionLevel() {
return this.level;
}
 
/**
* @return The world which the group has this permission in. Returns a string value, if null then this permission applies to all worlds.
*/
public String getPermissionWorld() {
return this.world;
}
 
public void setPermissionName(String name) {
this.name = name;
}
 
public void setPermissionNode(String node) {
this.node = node;
}
 
public void setPermissionLevel(boolean level) {
this.level = level;
}
 
public void setPermissionWorld(String world) {
this.world = world;
}
 
}

No comments? Lol.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

making method for every field and making fields public makes no sense

 

Well then. Thank you for no elaboration or providing anything constructive to this thread.

 

Blackveil
looks like you too smart and dont need any help.

but in such case, what reason of this thread?

 

There was no implied meaning underneath my response to what you said. I'm looking for advice to help better myself and if you're going to say there's no reason to do something, explain why.

 

you can explain here and now why you added set\get methods for public fields?

what reason for it?