Solved ArrayIndexOutOfBoundException with my minigame plugin!

Hey,
I decided to make a minigame plugin.A BowBash minigame and started to make my Arena.java and the ArenaManager.java I make two methods

Code:java

saveArena(Arena a)

and

Code:java

createArena(Location locRed, Location locBlue, String name)

it returns the created arena!Now when I do this

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
Player p = (Player)sender;
if(cmd.getName().equalsIgnoreCase("bb")){
if(args.length == 0){
return false;
}else{
if(args[0].equalsIgnoreCase("create")){
[B]manager.saveArena(manager.createArena(p.getLocation(), locBlue, args[1]));[/B]
return true;
}
if(args[0].equalsIgnoreCase("blau")){
locBlue = new Location(p.getLocation().getWorld(), p.getLocation().getX(), p.getLocation().getY(), p.getLocation().getZ());
}
return false;
}
}
return false;
}

I got an NullPointerException on the line 29(manager.saveArena(manager.createArena(p.getLocation(), locBlue, args[1])); )
I post now all classes and the error message!Sorry for my english because nobody is perfekt !

Arena.java

Code:java

package de.ki.ostylk.bowbashing;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Location;
import org.bukkit.entity.Player;
 
public class Arena {
private String name;
private Location locBlue;
private Location locRed;
private final int MAXPLAYER = 8;
List<String> playersRed;
List<String> playersBlue;
public Arena(String name, Location locBlue, Location locRed){
this.name = name;
this.locBlue = locBlue;
this.locRed = locRed;
playersRed = new ArrayList<String>();
playersBlue = new ArrayList<String>();
}
public String getName(){
return name;
}
public Location getLocRed(){
return locRed;
}
public Location getLocBlue(){
return locBlue;
}
public int getMaxPlayer(){
return MAXPLAYER;
}
public List<String> getRed(){
return this.playersRed;
}
public List<String> getBlue(){
return this.playersBlue;
}
public void addRed(Player p){
this.playersRed.add(p.getName());
}
public void addBlue(Player p){
this.playersBlue.add(p.getName());
}
}
 

ArenaManager.java

Code:java

package de.ki.ostylk.bowbashing;
 
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
 
 
public class ArenaManager {
private static ArenaManager am;
List<Arena> arenas = new ArrayList<Arena>();
public Map<String, Location> locs = new HashMap<String, Location>();
public ArenaManager(){}
public static ArenaManager getManager(){
if(am == null)
am = new ArenaManager();
return am;
}
public Arena createArena(Location locRed, Location locBlue, String name){
Arena a = new Arena(name, locBlue, locRed);
arenas.add(a);
return a;
}
public void saveArena(Arena a){
BowBash.cfg.set("Arena." + a.getName() + ".Red.X", a.getLocRed().getX());
BowBash.cfg.set("Arena." + a.getName() + ".Red.Y", a.getLocRed().getY());
BowBash.cfg.set("Arena." + a.getName() + ".Red.Z", a.getLocRed().getZ());
BowBash.cfg.set("Arena." + a.getName() + ".Red.Welt", a.getLocRed().getWorld().getName());
 
BowBash.cfg.set("Arena." + a.getName() + ".Blue.X", a.getLocBlue().getX());
BowBash.cfg.set("Arena." + a.getName() + ".Blue.Y", a.getLocBlue().getY());
BowBash.cfg.set("Arena." + a.getName() + ".Blue.Z", a.getLocBlue().getZ());
BowBash.cfg.set("Arena." + a.getName() + ".Blue.Welt", a.getLocBlue().getWorld().getName());
 
BowBash.cfg.set("Arena." + a.getName() + ".Name", a.getName());
}
public void loadArenas(){
for(String name : BowBash.cfg.getConfigurationSection("Arena").getKeys(false)){
 
String arenaName = BowBash.cfg.getString("Arena." + name + ".Name");
 
 
int xRed = BowBash.cfg.getInt("Arena." + name + ".Red.X");
int yRed = BowBash.cfg.getInt("Arena." + name + ".Red.Y");
int zRed = BowBash.cfg.getInt("Arena." + name + ".Red.Z");
String weltRot = BowBash.cfg.getString("Arena." + name + "Red.Welt");
Location locRed = new Location(Bukkit.getWorld(weltRot), xRed, yRed, zRed);
 
int xBlue = BowBash.cfg.getInt("Arena." + name + ".Blue.X");
int yBlue = BowBash.cfg.getInt("Arena." + name + ".Blue.Y");
int zBlue = BowBash.cfg.getInt("Arena." + name + ".Blue.Z");
String weltBlau = BowBash.cfg.getString("Arena." + name + "Blue.Welt");
Location locBlue = new Location(Bukkit.getWorld(weltBlau), xBlue, yBlue, zBlue);
 
Arena a;
a = new Arena(arenaName, locBlue, locRed);
arenas.add(a);
}
}
}
 

BowBash.java

Code:java

package de.ki.ostylk.bowbashing;
 
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class BowBash extends JavaPlugin{
static FileConfiguration cfg;
Location locBlue;
private ArenaManager manager = ArenaManager.getManager();
public void onEnable(){
manager.loadArenas();
this.saveConfig();
}
public void onDisable(){
this.saveConfig();
}
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
Player p = (Player)sender;
if(cmd.getName().equalsIgnoreCase("bb")){
if(args.length == 0){
return false;
}else{
if(args[0].equalsIgnoreCase("create")){
manager.saveArena(manager.createArena(p.getLocation(), locBlue, args[1]));
return true;
}
if(args[0].equalsIgnoreCase("blau")){
locBlue = new Location(p.getLocation().getWorld(), p.getLocation().getX(), p.getLocation().getY(), p.getLocation().getZ());
}
return false;
}
}
return false;
}
}
 

if needed the plugin.yml

Code:

name: BowBashing
author: ostylk
version: 1.0
main: de.ki.ostylk.bowbashing.BowBash
 
commands:
  bb:
    description: Hauptkommando
    usage: /bb <arg> <operation>

And the Exception

Code:

[08:47:56 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'bb'
in plugin BowBashing v1.0
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[cra
ftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:19
9) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at org.bukkit.craftbukkit.v1_7_R1.CraftServer.dispatchCommand(CraftServe
r.java:543) ~[craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.PlayerConnection.handleCommand(PlayerCon
nection.java:932) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java
:814) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.a(PacketPlayInChat.java
:28) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.handle(PacketPlayInChat
.java:47) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:146
) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.ServerConnection.c(SourceFile:134) [craf
tbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:6
55) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:2
50) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:5
45) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java
:457) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:6
17) [craftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
Caused by: java.lang.NullPointerException
        at de.ki.ostylk.bowbashing.ArenaManager.saveArena(ArenaManager.java:28)
~[?:?]
        at de.ki.ostylk.bowbashing.BowBash.onCommand(BowBash.java:29) ~[?:?]
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[cra
ftbukkit.jar:git-Bukkit-1.7.2-R0.2-35-gc449391-b3004jnks]
        ... 13 more

 

Would you please post the NullPointerException error message?

 

Oh I forgot xD!It's on the first post!

Anyone know it?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ostylk I dont think you declared BowBash in your arena manager. atleast i dont see it

 

@deivisxmWhat do you mean with declare?I got an ArrayIndexOutOfBoundException!

 

your issue as actually here:

Code:

BowBash.cfg.set("Arena." + a.getName() + ".Red.X", a.getLocRed().getX());

Which I suspect is related to "BowBash.cfg" never having been set.

He is accessing BowBash statically, it does not need to be declared in the ArenaManager class.

 

@ostylkin your error i see null pointer exception. i mean for example BowBash bb = new BowBash(); . Altrough since BowBash is main class i would rather do: private final BowBash bb;

 

BowBash.cfg.set("Arena." + a.getName() + ".Red.X", a.getLocRed().getX());

Try logging to console that a.getLocRed() to see if its null. I suspect that your error is trying to .getX() on a null object.

 

manager.saveArena(manager.createArena(p.getLocation(), locBlue, args[1]));
How about you try to use manager.createArena() before you use manager.saveArena(), now I don't know for sure, but I'm thinking you're getting your NullPointerException because you are saving AND creating an arena at the same time, these should be done seperately in my opinion.

 

Blackveil BillyGalbreath deivisxm Giant It works! I gave to the ArenaManager class the bowbash class as a reference

Code:java

public static ArenaManager getManager(BowBash instance){
        if(am == null)
            am = new ArenaManager();
        plugin = instance;
        return am;
    }

And replaced all BowBash.cfg with plugin.cfg! Then I wrote in the onEnable() method

Code:java

cfg = getConfig();

And in the onCommand method I saved the Arena object in a variable "a" and saved this!

Code:java

Arena a = manager.createArena(p.getLocation(), locBlue, args[1]);
                    manager.saveArena(a);

Now it works! Thx to all!