Solved Config Creating Duplicate entrys

Hello,

Im trying to add a player to a config. Here is what the config looks like:

PHP:

Leaderboard:
  '0':
    Name: Min3CraftDud1
    Wins: 2
    Loses: 2
  '1':
    Name: L0rdOfTheCraft
    Wins: 0
    Loses: 1

But now when I join the game (triggers method) it make duplicate entries and I cannot figure out how to get it to stop.

PHP:

Leaderboard:
  '0':
    Name: Min3CraftDud1
    Wins: 2
    Loses: 2
  '1':
    Name: L0rdOfTheCraft
    Wins: 0
    Loses: 1
  '2':
    Name: Min3CraftDud3
    Wins: 0
    Loses: 0
  '3':
    Name: Min3CraftDud3
    Wins: 0
    Loses: 0


Here is the code:

Code:java

    @EventHandler
    public void onLogin(PlayerLoginEvent e){
        Player p = e.getPlayer();
        try{Leaderboard.addToFile(p);}catch(Exception i){i.printStackTrace();}
    }
    public static void addToFile(Player p) throws IOException{
        File lbFile = new File(plugin.getDataFolder() + File.separator + "Leaderboard.yml");
        if(lbFile.exists()){
        FileConfiguration fc = YamlConfiguration.loadConfiguration(lbFile);
            for(int j=0;j<fc.getConfigurationSection("Leaderboard").getKeys(false).size();j++){
                String s = fc.getString("Leaderboard."+j+".Name");
                if(s.equals(p.getName()) || fc.getConfigurationSection("Leaderboard").contains(p.getName())){
                    return;
                }else{
                    for(int i=0;i<5000;i++){
                        if(!fc.contains("Leaderboard."+i)){
                            fc.set("Leaderboard."+i+".Name", p.getName());
                            fc.set("Leaderboard."+i+".Wins",0);
                            fc.set("Leaderboard."+i+".Loses",0);
                            fc.save(lbFile);
                            break;
                        }
                    }
                }
            }
 
        } 
    }

Thanks for the help.

 

Maybe this will work,
Change line 12 into:

 

2MBKindiegames Umm both of your posts are the same, and my line 12 and your suggestion are exactly the same...

Code:java

//My Line 12:
if(s.equals(p.getName()) || fc.getConfigurationSection("Leaderboard").contains(p.getName())){
//Your line 12:
if(s.equals(p.getName()) || fc.getConfigurationSection("Leaderboard").contains(p.getName())){

 

Sorry, that's me messing up (slow internet, double clicking )

What I ment to say was:

 

2MBKindiegames Nope same thing. Its really ticking me off, this is the only thing thats keeping me from releasing my plugin.

 

hubeb the config will never contain the name of the person on itself, as the path inside the config to a person is leaderboards.<number>.<name> not leaderboards.<name>

I would suggest using this

Code:java

public void configContainsPlayer(FileConfiguration fc, String player){
    ConfigurationSection cSection = fc.getConfigurationSection("LeaderBoard");
    for(String key : cSection.getKeys(false)){
        String name = cSection.getString(key + ".name");
        if(player.equals(name))
            return true;
    }
    return false;
}
 

 

Sgt_Tailor Nope did not work, but I got it working. I had the other for loop nested. Here is working code:

Code:java

    public static void addToFile(Player p) throws IOException{
        File lbFile = new File(plugin.getDataFolder() + File.separator + "Leaderboard.yml");
        if(lbFile.exists()){
        FileConfiguration fc = YamlConfiguration.loadConfiguration(lbFile);
            for(int j=0;j<fc.getConfigurationSection("Leaderboard").getKeys(false).size();j++){
                String s = fc.getString("Leaderboard."+j+".Name");
                if(s.equals(p.getName())){
                    return;
                }
            }
            for(int i=0;i<5000;i++){
                if(!fc.contains("Leaderboard."+i)){
                    fc.set("Leaderboard."+i+".Name", p.getName());
                      fc.set("Leaderboard."+i+".Wins",0);
                      fc.set("Leaderboard."+i+".Loses",0);
                      fc.save(lbFile);
                      break;
                }
            }
        }
    }