IllegalArgumentException: Plugin already initialized!

Hey there, it's me again.



I'm recently working on a plugin that hides players to provide something like a SilentHub.

I have three classes, a Main.java were i defined the commands, an EventListener.java that handles the PlayerJoinEvent and PlayerQuitEvent and a Hiders.java for the hiding- or showing-processes.


This is my Main.java: http://pastebin.com/NRWnPQVc
The commands /online and /private are just for debugging, you'll see the methods in Hiders.java.
This is my EventListener.java: http://pastebin.com/M043MusS
This is my Hiders.java: http://pastebin.com/1VAR8Zuj
This is my plugin.yml: http://pastebin.com/PEK5rstn


I'm not getting any errors, but when typing /hider in chat, there's always the output "Silent Hub: Enabled" so i guess i'm not even being added to the ArrayList<Player> online.
Also, nobody's hidden, but that seems legit if there's noone in the ArrayList.
/online and /private also have no output.




Hopefully someone knows the solution.



Yours sincerely,
Robin Bi


EDIT: Oh damn, that's an old title. Could someone please change it to "Add to ArrayList<Player> doesn't work"? *Being embarrassed*

 

You are actually creating a new Hider instance for every time you do something, so the list is always recreated.

"new Hiders();" will create a new Hider instance, this will be a new variable, a new hider, so to maintain the same list, just keep using the same Hiders.

To do that you:
On Main.java, do these changes (check diference)

Code:java

public class Main extends JavaPlugin implements CommandExecutor {
 
public Hiders hiders;
 
@Override
public void onEnable() {
getServer().getPluginManager().registerEvents(new EventListener(this), this);
getServer().getPluginCommand(<command here>).setExecutor(this); // don't know if this is necessary since you said commands were working
hiders = new Hiders();
}

On event listener

Code:java

private final Main plugin;
 
public EventListener(Main plugin) {
this.plugin = plugin;
// REPLACE ALL 'hiders variable' to plugin.hiders.<method here>
}

By doing this, you keep the same Hider instance, so you will: keep only one hiders on the memory, with only one list, methods, etc

 

Thanks a bunch for your answer
Adding and removing users who write /hider works now, but players are not hidden. And I have no fricking idea why...

I'd appreciate you watching my code again.



Yours sincerely,
Robin Bi

rfsantos1996 forgot to tag you and I'm not sure if you get the alert if i just edit my post.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Thanks for the tag, I didnt saw your comment.

Instead of a list of online players. I recommend you using "plugin.getServer().getOnlinePlayers()", I think you can replace every "online" (except the .add() and .remove() of course, that you need to delete) without causing any error.

With this change you can actually delete your EventListener.

I recommend you using if { } else { } on every command, this can help you finding bugs and any bug like forgoting a "return"

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
if(cmd.getName().equalsIgnoreCase("hider")) {
if(sender instanceof Player) {
if(sender.hasPermission("hiders.switch")) {
hiders.switchView((Player) sender);
sender.sendMessage("Switched!");
return true;
} else {
sender.sendMessage("No permission!");
return true;
}
} else {
sender.sendMessage("You're not a player! Sorry");
return true;
}
 
} else if(cmd.getName().equalsIgnoreCase("online")) {
for(Player online : getServer().getOnlinePlayers()) {
sender.sendMessage(online.getName());
}
sender.sendMessage(Integer.toString(getServer().getOnlinePlayers().size()));
return true;
 
} else if(cmd.getName().equalsIgnoreCase("switched")) {
for(Player silented : hiders.getWhoHaveSwitched()) { // ignore the 'silented', it was supposed to be switched but i'm lazy to rewrite
sender.sendMessage(silented.getName());
}
sender.sendMessage(Integer.toString(hiders.getWhoHaveSwitched().size()));
return true;
 
} else {
return false;
}
}
}

On hiders:

Code:java

ArrayList<Player> switched = new ArrayList();
 
public void switchView(Player player) {
if(switched.contains(player)) {
showPlayers(player);
switched.remove(player);
} else {
hidePlayers(player);
switched.add(player);
}
}
 
public void hidePlayers(Player toHideFrom) {
for(Player online : plugin.getServer().getOnlinePlayers()) {
toHideFrom.hidePlayer(online);
}
}
 
public void showPlayers(Player toShow) {
for(Player online : plugin.getServer().getOnlinePlayers()) {
if(!toShow.canSee(online)) {
toShow.showPlayer(online);
}
}
}
 
public void removePlayer(Player player) {
if(switched.contains(player)) {
switched.remove(player);
}
}
 
public ArrayList<Player> getWhoHaveSwitched() {
return switched;
}

Actually you need the EventListener:

Code:java

// on join
for(Player hideTo : plugin.hiders.getWhoHaveSwitched()) {
hideTo.hidePlayer(event.getPlayer()); // hide players who was supposed to be hidden
}
 
// on quit
hiders.removePlayer(event.getPlayer()); // if you don't do this, player will be saved on the list and won't be able to be removed from all RAM memory

 

rfsantos1996 To be honest, i really don't understand why i need

Code:java

hiders.removePlayer(event.getPlayer());

because the player should be deleted from the onlineList anyways, shouldn't he?

Also, Eclipse doesn't accept removePlayer(). Or did you mean

Code:java

plugin.hiders.privates.remove(p);

?


Whatever, huge thanks again There are so many nice people on this forums helping newbies like me <3



Yours sincerely,
Robin Bi

 

I mean

Code:java

plugin.hiders.privates.remove(p);

if you keep a player on a list, it won't be removed from the memory, the player will be offline but if you don't remove it from the list, he can't be deleted, search for "memory leak".

 

have you tried checking if another plugin's main class is called main?
that could be causing the problem.