Solved PlayerDeathEvent on Wolf Kill Not Working

I can't seem to find out what's wrong here, I want it to get the wolf owner and send them a message but it's not working.

Code:java

@EventHandler
    public void onWolfKill(PlayerDeathEvent e) {
        if (e.getEntity().getKiller() instanceof Wolf) {
            Wolf w = (Wolf) e.getEntity().getKiller();
            Player killer = (Player) w.getOwner();
            killer.sendMessage("It worked");
        }
    }

Anyone know why it's not doing anything? I am registering the event and there is no error in console :/

 

You should probably do EntityDeathEvent rather than Player Death Event. I don't know if it changes anything, though.

 

pigeontroll What difference would that make? I'll try it out though.

pigeontroll Same result, nothing happens. No error in console.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You are trying to send a message to the owner of the wolf it looks like.

Code:java

@EventHandler
    public void onWolfKill(PlayerDeathEvent e) {
        if (e.getEntity().getKiller() instanceof Wolf) {
            Wolf w = (Wolf) e.getEntity();
            Player p = w.getKiller();
            p.sendMessage("It Worked!");
        }
    }

Haven't tested it. I think it should work.

 

canemonster15 No, I'm looking for a Wolf that kills a Player than sending the Wolf's owner a message saying that their wolf killed someone. Here's my full code:

Code:java

@EventHandler
    public void onWolfKill(PlayerDeathEvent e) {
        if (e.getEntity().getKiller() instanceof Wolf) {
            Player killed = (Player) e.getEntity().getPlayer();
            Wolf w = (Wolf) e.getEntity().getKiller();
            Player killer = (Player) w.getOwner();
            if (!Main.spawn.contains(killer.getName()) && !Main.spawn.contains(killed.getName()) && Abilities.artemis.contains(killer.getName())) {       
                Yaml points = Main.getPlayerPoints(killer);
                points.increment("kills", 1);
                points.increment("points", 1);
                killer.sendMessage(Main.displayServer() + ChatColor.YELLOW + "Your dog killed " + killed.getName() + " and got you " + ChatColor.GOLD + "1" + ChatColor.YELLOW + " point!");
                killed.sendMessage(Main.displayServer() + ChatColor.YELLOW + "You were killed by " + killer.getName() + "'s dog!");
            }
        }
    }

 

Mr_Gibbles Print some debug before you do the check to see if they are in the lists, and use debug to see if any of them aren't giving the proper value

 

xTigerRebornx What do you mean? I took out the lists from the code and nothing happened still, so it has nothing to do with them.

 

Mr_Gibbles Can we see the full class and where you are registering the event at?

 

Full class:

Code:java

package me.Mr_Gibbles.McOitc;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.DyeColor;
import org.bukkit.Location;
import org.bukkit.entity.Arrow;
import org.bukkit.entity.EntityType;
import org.bukkit.entity.Player;
import org.bukkit.entity.Wolf;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.entity.ProjectileLaunchEvent;
 
public class Artemis implements Listener {
 
    Main main;
    public Artemis(Main main) {
        this.main = main;
    }
 
    public static ArrayList<String> arrowcooldown = new ArrayList<String>();
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onProjectileShoot(ProjectileLaunchEvent e) {
        if (e.getEntity() instanceof Arrow && e.getEntity().getShooter() instanceof Player) {
            final Player p = (Player) e.getEntity().getShooter();
            if (Abilities.artemis.contains(p.getName()) && !Main.spawn.contains(p.getName())) {
                if (!arrowcooldown.contains(p.getName())) {
                    arrowcooldown.add(p.getName());
                    Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(main, new Runnable() {
                        @Override
                        public void run() {
                            Arrow a = p.shootArrow();
                            a.setVelocity(p.getLocation().getDirection().multiply(2));
                        }
                    }, 2L);
                    Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(main, new Runnable() {
                        @Override
                        public void run() {
                            arrowcooldown.remove(p.getName());
                        }
                    }, 5L);
                }
            }
        }
    }
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onProjectileHit(EntityDamageByEntityEvent e) {
        if (e.getEntity() instanceof Player && e.getDamager() instanceof Arrow) {
            Arrow a = (Arrow) e.getDamager();
            if (a.getShooter() instanceof Player) {
                Player p = (Player) a.getShooter();
                Player killed = (Player) e.getEntity();
                if (Abilities.artemis.contains(p.getName()) && !Main.spawn.contains(p.getName())) {
                    Location loc = killed.getLocation();
                    final Wolf wolf = (Wolf) loc.getWorld().spawnEntity(loc, EntityType.WOLF);
                    wolf.setTamed(true);
                    wolf.setOwner(p);
                    wolf.setCollarColor(DyeColor.PINK);
                    wolf.setCustomNameVisible(true);
                    wolf.setCustomName(ChatColor.LIGHT_PURPLE + p.getName() + "'s Lil' Helper");
                    Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(main, new Runnable() {
                        @Override
                        public void run() {
                            if (wolf.isDead() == false) {
                                wolf.damage(20D);
                            }
                        }
                    }, 200L);
                }
            }
        }
    }
 
    @EventHandler
    public void onWolfKill(PlayerDeathEvent e) {
        if (e.getEntity().getKiller() instanceof Wolf) {
            Player killed = (Player) e.getEntity().getPlayer();
            Wolf w = (Wolf) e.getEntity().getKiller();
            Player killer = (Player) w.getOwner();
            if (!Main.spawn.contains(killer.getName()) && !Main.spawn.contains(killed.getName()) && Abilities.artemis.contains(killer.getName())) {       
                Yaml points = Main.getPlayerPoints(killer);
                points.increment("kills", 1);
                points.increment("points", 1);
                killer.sendMessage(Main.displayServer() + ChatColor.YELLOW + "Your dog killed " + killed.getName() + " and got you " + ChatColor.GOLD + "1" + ChatColor.YELLOW + " point!");
                killed.sendMessage(Main.displayServer() + ChatColor.YELLOW + "You were killed by " + killer.getName() + "'s dog!");
            }
        }
    }
}

Main class (where event is registered):

Code:java

public static void registerEvents(org.bukkit.plugin.Plugin plugin, Listener... listeners) {
        for (Listener listener : listeners) {
            Bukkit.getServer().getPluginManager().registerEvents(listener, plugin);
        }
    }
public void onEnable() {
//blah blah blah
registerEvents(this, new Artemis(this));
//blah blah blah
}

bumpeee

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

if (e.getEntity().getKiller() instanceof Wolf) {
}

The reason why this code wont work is because the method getkiller() belongs to the class LivingEntity which returns a Player object. So therefore in your code you are asking if a Player is an instance of Wolf and the answer is no.

 

agent6262 Hmm, than how could I get a player death from a wolf without using this?

Ok, I fixed it using

Code:java

EntityDamageEvent ede = killed.getLastDamageCause();
        if(ede instanceof EntityDamageByEntityEvent){
            EntityDamageByEntityEvent edbe = (EntityDamageByEntityEvent) ede;
            Entity wolf = edbe.getDamager();
            if(wolf instanceof Wolf){

instead of

Code:java

if (e.getEntity().getKiller() instanceof Wolf) {

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I have not tested this but this might work or something along this line

Code:java

if(e.getEntityType() instanceof EntityType.WOLF){
}