Solved Check if a command exists.

How to check if a command exists? I want to replace the default "Unknown command" message.

Thanks

 

GeorgeeeHD
I believe you would have to edit craftbukkit.jar for that.

 

GeorgeeeHD Gater12
In a PlayerCommandPreProcessEvent, cancel it to avoid the "unknown command" message and then send your own message to the player.

I'm unsure what is a good way of checking if a command exists, if possible.

 

This is totally irrelevant but George I'm a big sub on youtube lol

 

AoH_Ruthless i understand that, but not how to do it xD

 

Code:java

Command command = Bukkit.getServer().getPluginCommand("command");
if(command != null) {
// command is not null
}
else {
// command is null
}

 

Do i put this in a PlayerCommandPreprocessEvent or where? Also, do I replace "command" with anything or is it meant to be that? At the moment, I basically copied that to a PlayerCommandPreprocessEvent and it always runs what I put in the code

Code:java

Command command = Bukkit.getServer().getPluginCommand("command");
if(command != null) {
return;
} else {
e.setCancelled(true);
p.sendMessage("Hi");
}

It always messages me "Hi", even if the command is valid

 

GeorgeeeHD You have to actually put the command name in the getPluginCommand()...

Of course it's always gonna send "Hi", there is no command "command".

 

I think you misunderstood what I want. I want to be able to check if a player types something like /sdjfhskdhfj24!!sdfhsdf

Obviously, that is not a command. If they type that, it will say "Unknown command." I need to change that message. I can check every single possibility that they could type o_o

 

GeorgeeeHD Perhaps something like this?

Code:java

@EventHandler
public void onCmdPreProcess(PlayerCommandPreProcessEvent e) {
Command command = Bukkit.getServer().getPluginCommand(e.getCommand().toString());
if (command = null) {
e.setCancelled(true);
}
 

This may not work, just a theory. Haven't tested it.

Wizehh : DDDDDD Yay! xD I didn't even expect that to work! I guess you're welcome, and thanks for allowing me the good feeling of helping someone.

Edit: *facepalm* wait, you're not the one who posted this thread! xD But at least the guy who did post this thread will know it works.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

pookeythekid Isn't that basically what I just posted, or am I missing something?

And yes, GeorgeeeHD, I understood what you meant, and what I posted should solve your error, but you weren't using it right.

 

Wolfey It is, but you are missing a couple of things.
1. You used a specific string as an example, which was "command". You didn't go fetch the command that was being entered instead.
2. The code you posted didn't show that it was an EventHandler.
But otherwise, yes I pretty much repeated what you said. : P

Edit: Wait nvm it did, you have an e.setCancelled(true); in there.

 

This is what I changed yours to.

Code:java

@EventHandler
    public void onCmdPreProcess(PlayerCommandPreprocessEvent e) {
        Player p = e.getPlayer();
 
        Command command = Bukkit.getServer().getPluginCommand(e.getMessage());
 
        if (command == null) {
            e.setCancelled(true);
            p.sendMessage(prefix + "That is not a valid command!");
        }
 
    }

no matter what command i type, it messages the player "prefix + That is not a valid command"

 

GeorgeeeHD Well sir, it appears that you broke my method in attempt to fix it. xD
First off, change it back from "e.getMessage()" to "e.getCommand().toString()". Secondly, you should be getting an error if you haven't stated "prefix" as a variable earlier in your code, and if you have, then it would be impossible for it to say to you: "prefix + That is not a valid command".

 

prefix is a variable i have in my code, and e.getCommand() does not exist in the PlayerCommandPreprocessEvent

 

GeorgeeeHD Try using:

Code:

e.getMessage().substring(1);

 

Well I got it to work, the "/" at the beginning of commands messed it up. If you want the code, here it is:

Code:java

@EventHandler
    public void onCmdPreProcess(PlayerCommandPreprocessEvent e) {
 
        Player p = e.getPlayer();
 
        Command command = Bukkit.getServer().getPluginCommand(e.getMessage().toString().replace("/", ""));
 
        if(command != null) return;       
 
        e.setCancelled(true);
        p.sendMessage("That is not a valid command!");
 
    }

ninja'd xD That would work too I guess

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

GeorgeeeHD My method would only replace the first forward-slash, in case of there being forward-slashes later in the command arguments.

EDIT: Why did you perform toString() on a String?

 

Ahm on codename_B's under 50 lines challenge, a guy ( Zarko ) actually made this

His post:

 

tbh, i don't know, I just copied what someone wrote here earlier and worked off that, I removed it a bit later lol

 

Here it is Arcoz
http://dev.bukkit.org/bukkit-plugins/customunknowncommandmessage/

 

Ah, makes sense. Good job. Hope you like your new plugin now that you've solved its problems.

Someone tested it and said it worked perfectly...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

lol i dont know, there is defiantly no getCommand in PlayerCommandPreprocessEvent tho

 

I use
Command command = Bukkit.getServer().getPluginCommand(event.getMessage().substring(1));
and command == null all time(

 

GeorgeeeHD get the field commandmap in bukkit and check if the used command is inside the map

 

How to check of all commands if command exist?