Solved Dead Code - Plugin

Hi,

I am coding a plugin to try new things I have learned within the Bukkit API.

Please excuse the vulgarity of the plugin because I try to make the plugin seem funny to my friends and at the same time I test the new things I have learned.

The error I receive in the code is "Dead Code" which means that a chunk of my code does not run so it's considered "unused".

Here is the code:

Code:java

package me.dev.venexor;
 
import org.bukkit.Bukkit;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
class Command implements CommandExecutor
{
    public boolean onCommand(CommandSender sender, org.bukkit.command.Command cmd, String label, String[] args)
    {
        if (label.equalsIgnoreCase("mf") || label.equalsIgnoreCase("multifun"))
        {
            sender.sendMessage("§d§m--------------§8[§5 MultiFun §8]§d§m--------------");
            sender.sendMessage("§f- §b/mf §8: §aOpens up help menu!");
            sender.sendMessage("§f- §b/fuck §8: §aUse /fuck §f[§aname§f] §7| §f[§aall§f]"); 
            sender.sendMessage("§f- §b/blow §8: §aUse /blow §f[§aname§f] §7| §f[§aall§f]"); 
            sender.sendMessage("§f- §b/love §8: §aUse /love §f[§aname§f] §7| §f[§aall§f]"); 
            sender.sendMessage("§f- §b/anal §8: §aUse /anal §f[§aname§f] §7| §f[§aall§f]"); 
            sender.sendMessage("§d§m--------------§8[§5 MultiFun §8]§d§m--------------");         
        }
 
        else if(label.equalsIgnoreCase("fuck"))
        {
            Player p = (Player) sender;
            String player = p.getName();
            if(p.hasPermission("multifun.fuck"))
            {
                if(args.length == 1)
                {
                    if(args[0].equalsIgnoreCase("all"))
                    {
                        p.sendMessage("§8[§5MultiFun§8]§d You have fucked everyone online!");
                        for(Player online : Bukkit.getOnlinePlayers())
                        {
                            if(!online.getDisplayName().equalsIgnoreCase(player))
                            {
                                online.sendMessage("§8[§5MultiFun§8]§d You have been fucked by §a" + player + "§d!");
                                online.addPotionEffect(new PotionEffect(PotionEffectType.BLINDNESS, 200, 1));
                                online.addPotionEffect(new PotionEffect(PotionEffectType.CONFUSION, 200, 4));
                            }
                        }
                    }
 
                    else
                    {
                        Player t = Bukkit.getPlayer(args[0]);
                        String target = t.getName();
                        if(t != null)
                        {
                            if(target.equalsIgnoreCase(player))
                            {
                                p.sendMessage("§8[§5MultiFun§8]§d You cannot fuck yourself!");
                            }
                            else
                            {
                                p.sendMessage("§8[§5MultiFun§8]§d You have fucked §a" + target + "§d!");
                                t.sendMessage("§8[§5MultiFun§8]§d You have been fucked by §a" + player + "§d!");
                                t.addPotionEffect(new PotionEffect(PotionEffectType.BLINDNESS, 200, 1));
                                t.addPotionEffect(new PotionEffect(PotionEffectType.CONFUSION, 200, 4));
                            }
 
                        }
                        else
                        {
                            p.sendMessage("§8[§5MultiFun§8]§d You can only fuck players that are online!");
                        }
 
                    }
 
                }
 
 
                else
                {
                    p.sendMessage("§8[§5MultiFun§8]§d Use /fuck [player] [all]");             
                }
 
            }
 
            else
            {
                p.sendMessage("§8[§5MultiFun§8]§d You do not have permission to execute this command!");
            }
        }
        return false;
    }
}
 

The dead code is:

Code:java

  {
                            p.sendMessage("§8[§5MultiFun§8]§d You can only fuck players that are online!");
                        }

Although, I don't know why this chunk is seen as dead code because it is supposed to display an error message saying that the player the person tried to "fuck" is offline so they cannot "fuck" them.

I tested this plugin with the error message on the server and what I expected came out to be true - a Null Pointer Exception when I tried to do /fuck <name of offline player>.

I hope you can help me find my error and I hope you guys can again excuse the vulgar language and concepts.

 

Test if the player is null before getting their name. Also you might want to look at ChatColor. And the bukkit.getPlayer would be better as bukkit.getPlayerExact.

 

1. It's unreachable because you set a string equal to t.getName() before doing the null check on t. This means that if t is null you'll get a NullPointerException before getting to the if statement, which in turn means the if statement will never return false. Either a NullPointerException will be thrown or t will not be null.
2. You should really look in to using the ChatColor enum instead of raw color codes.

It took me forever to actually figure out what the problem was because I kept having random outbursts of laughter while reading the code. Seriously, what the /fuck are you writing? ಠ_ಠ

 

I used getPlayerExact before but I don't like it very much because it requires me to write the full name instead of a short name. And what is wrong with using § instead of ChatColor.<Color Name>? If that's what you're talking about?

UPDATE: The plugin now works flawlessly!
I give my thanks to Garris0n and xa112!