Get Mobs in front of a player, within the Line of Sight and within a certain distance

I have no clue how to do what I posted in the title. I have spent a few hours working on it, I've tried player.getLocation().getDirection() and I still cant get it. If anyone can help that would be greatly appreciated.

List of Requirements for my plugin:
1. Gets the players Line of Sight
2. If a mob is within the line of sight and within say 2 blocks execute code
3.Get the name of the mob
4. If there is more than one mob only select one.

My Code so far:

Code:java

 
// Gets the entity nearby the player and calls the remove method
@EventHandler
@SuppressWarnings("deprecation")
public void onLeftClick(PlayerInteractEvent event) {
Player p = event.getPlayer();
if (event.getAction() == Action.RIGHT_CLICK_AIR
|| event.getAction() == Action.RIGHT_CLICK_BLOCK){
if (p.isSneaking()) {
if (p.getItemInHand().getType() == Material.WEB){
if (p.getItemInHand().hasItemMeta()) {
if (p.getItemInHand().getItemMeta().hasDisplayName()) {
if (p.getItemInHand().getItemMeta()
.getDisplayName()
.contains("An empty animal trap")) {
 
for (Entity e : p.getNearbyEntities(3.0, 2.0,
3.0)) {
if(p.hasLineOfSight(e)){
System.out.println("LoS!");
}
for (Block b : p.getLineOfSight(null, 2)) {
if (b.getLocation().distance(
e.getLocation()) < 2) {
remove(e);
} else {
p.sendMessage(ChatColor.DARK_RED
+ "Test1");
}
}
}
}
}
}
}
}
}
}

Arche
Tagged you because you're knowledgeable, sorry if it annoys you

 

Code:

I dont know so much but it is e.remove(); Not remove(e);

 

It's his own method, I believe.

 

Ok sorry!

 

What seems to be wrong with what you have currently?

 

Barinade Norbu10 It removes every entity the player can see within 2 blocks instead of just one and when it fails to find any entities the message I want the player to get never sends

 

add "break;" after you remove an entity (break stops the current loop)

 

Barinade That stops the loop but I still get every entity around the player instead of just one that the player is looking at.

 

On a single left click?

• 
  
  if(p.hasLineOfSight(e)){
  System.out.println("LoS!");
  }
  
  Your should use e.remove(); in here, as the entity is within 3 blocks
  (Entity e : p.getNearbyEntities(3.0, 2.0,3.0))
  
  
  
  Edit: This fucking formatting is really starting to piss me off.

 

You need to break out of the loop in which you're iterating through the nearby entities. If you add break in the inner loop it will not have any visible effect on your code (though it makes it slightly more optimized).

Something like this would work

Code:java

 
boolean entRemoved = false;
for (Entity e : p.getNearbyEntities(3.0, 2.0, 3.0)) {
if(p.hasLineOfSight(e)){
System.out.println("LoS!");
}
for (Block b : p.getLineOfSight(null, 2)) {
if (b.getLocation().distance(
e.getLocation()) < 2) {
remove(e);
entRemoved = true;
break;
} else {
p.sendMessage(ChatColor.DARK_RED
+ "Test1");
}
if (entRemoved) {
break;
}
}
 

However, there's actually no need for two loops. This would work better.

Code:java

 
for (Entity e : p.getNearbyEntities(3.0, 2.0, 3.0)) {
if (p.hasLineOfSight(e)){
System.out.println("LoS!");
}
else {
continue;
}
if (p.getLocation().distance(e.getLocation()) <= 2.0) {
remove(e);
break;
}
}
 

EDIT: fixed code