Solved Bukkit not Recognizing Event

Hello! I am trying to make a Hobbit Inspired Sword, where when a player moves , and a a Monster is within a certain radius, the sword will have a enchantment glow, as well as send them a message. But something doesn't appear to be working. I believe it the the detecting of the monsters, as atleast the message should send to the player, but I can't figure it out.

Here is my code.

 

"This is a private paste. If you created this paste, please login to view it."

Please just paste your code here in [syntax=java][/syntax] tags. If you can't be bothered to do that, you'll find many people can't be bothered to help you.

 

Wow, I feel like an idiot , Here is my code:

Code:java

@SuppressWarnings("deprecation")
@EventHandler
public void onPlayerMove(final PlayerMoveEvent e) {
Player player = e.getPlayer();
if (player.getName().equals("philitup321")){
if (player.getName().equals("zombies24")){
 
 
getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable(){
public void run() {
 
Player player = e.getPlayer();
LivingEntity living = (LivingEntity) player;
if(player.getNearbyEntities(10, 10, 10).equals(EntityType.SKELETON) ){
if(player.getItemInHand().equals(Material.IRON_SWORD)) {
 
player.getInventory().setItemInHand(addGlow(player.getItemInHand()));
 
player.sendMessage(ChatColor.RED + " There are monsters nearby!!!");
player.playSound(player.getLocation(), Sound.AMBIENCE_CAVE, 1, 1);
}
}
 
 
}
 
 
 
}, 0, 1 * 20);
 
}
}
}

I can't win -.-

 

Why are you checking if the player's name is two different things?

 

You're checking if the player is philitup321 then if he is, you're checking if hes zombies24. which is impossible to be two names

adam beat me

 

What's with the repeating task? Your scheduling a new never-ending task in the most frequently called event in Bukkit. It's a wonder your server doesn't crash in the first few minutes.

 

Are you trying to check if the player is named either philitup321 or zombies24?

If so, you need to change your if statements to this:

Code:java

 
if (player.getName().equals("philitup321") || player.getName().equals("zombies24")) {
 

Like others have said, currently the way you have it your plugin checks if the player has two different names.

 

"}, 0, 1 * 20);" 1*20 will always return 20, so why not just write 20?

"LivingEntity living = (LivingEntity) player;" do you ever use this?

"if(player.getItemInHand().equals(Material.IRON_SWORD)) {" this should be
"if(player.getItemInHand().getType() == Material.IRON_SWORD) {"

Done looking for now, fix those and post results

 

adam753 Borlea fearless1333
Yes, sorry, I should have made that more clear, I am checking for both those players. Silly mistake on those lines by me.

Alshain01
Forgot that the PlayerMoveEvent happens every time the player moves, so ya, I now see that the repeating task part is unnecessary.

 

Is your code still not working after fixing that?

 

fearless1333 Barinade
This is what I have, and it still is not sending me any of the sounds, messages, etc.

Code:java

@EventHandler
public void onPlayerMove(PlayerMoveEvent e) {
Player player = e.getPlayer();
if (player.getName().equals("philitup321") || player.getName().equals("zombies24")) {
if(player.getNearbyEntities(10, 10, 10).equals(EntityType.SKELETON) ){
if(player.getItemInHand().getType() == Material.IRON_SWORD) {
player.getInventory().setItemInHand(addGlow(player.getItemInHand()));
player.sendMessage(ChatColor.RED + " There are monsters nearby!!!");
player.playSound(player.getLocation(), Sound.AMBIENCE_CAVE, 1, 1);
}
}
}
}

 

Try changing this

Code:Java

 
if(player.getNearbyEntities(10, 10, 10).equals(EntityType.SKELETON) ){
 

to this

Code:java

 
boolean skeleFound = false;
for (Entity entity : player.getNearbyEntities(10, 10, 10)) {
   if (entity.getType() == EntityType.Skeleton) {
      skeleFound = true;
      break;
   }
}
if (!skeleFound) {
   return;
}
 

 

fearless1333
Yes, that worked! Thank you!!