How would i check the metadata of a item

Okay so i am making a gun plugin and i need to check the name of the item first before i shoot anything but i have tried everything to get the metadata but it does not work so how would i go around about doing this

 

Code:java

ItemStack item = player.getItemInhand();
ItemMeta meta = item.getItemMeta();
String name = meta.getDisplayName();
 

^That will get the item meta and display name of the item in the player's hand. From there just test if(name.equalsIgnoreCase("whatever")){

Example of Usage:

Code:java

public void onClick(PlayerInteractEvent e){
Player p = e.getPlayer()
if(e.getAction() == Action.RIGHT_CLICK_AIR || e.getAction() == Action.RIGHT_CLICK_BLOCK){
if(p.getItemInHand().getType() == Material.APPLE){
ItemStack item = p.getItemInHand;
if(item.hasItemMeta()){
ItemMeta meta = item.getItemMeta();
if(meta.getDisplayName().equalsIgnoreCase("Doge")){
p.sendMessage("You have a Doge Apple");
}
}
}
}
}

Sends a player a message when they right click with an apple named "doge"

 

Code:

//coded in bukkit
ItemStack itemInHandOnEventOrSomething = player.getItemInHand();
if(itemInHandOnEventOrSomething.hasMteaData()){
  String name = itemInHandOnEventOrSomething.getItemMeta().getDisplayName();
  if(name.equalsIgnoreCase(ChatColor.stripColor("calebbfmv"))){
    System.out.println("calebbfmv is amazing");
  }
}

 

Code:java

@EventHandler
    public void RightClick(PlayerInteractEvent  e){
        Player p = (Player) e.getPlayer();
        ItemStack i = new ItemStack(Material.STICK);
        ItemMeta meta = i.getItemMeta();
        meta.setDisplayName("§5§l[§bBor Rifle§5§l]");
          Player player = e.getPlayer();
          if(e.getAction().equals(Action.LEFT_CLICK_AIR) && player.getItemInHand().getType() == Material.STICK){
              if(p.getItemInHand().getType() == Material.APPLE){
                  ItemStack item = p.getItemInHand();
                  if(item.hasItemMeta()){
                  if(meta.getDisplayName().equalsIgnoreCase("§5§l[§bBor Rifle§5§l]")){
                      p.getPlayer().launchProjectile(Snowball.class);
                  }else{
 
                  }
                  }
                  }
                  }else{
 
                  }
                }
 
    }

Now it wont do anything on left click

 

ChromeHD__
Please for the love of God do ChatColor.stripColor("name");
Also, try doing a .contains instead of .equals

 

calebbfmv

Code:

@EventHandler
    public void RightClick(PlayerInteractEvent  e){
        Player p = (Player) e.getPlayer();
        ItemStack i = new ItemStack(Material.STICK);
        ItemMeta meta = i.getItemMeta();
        meta.setDisplayName("§5§l[§bBor Rifle§5§l]");
          Player player = e.getPlayer();
          if(e.getAction().equals(Action.LEFT_CLICK_AIR) && player.getItemInHand().getType() == Material.STICK){
              if(p.getItemInHand().getType() == Material.APPLE){
                  ItemStack item = p.getItemInHand();
                  if(item.hasItemMeta()){
                  if(meta.getDisplayName().contains((ChatColor.stripColor(("§5§l[§bBor Rifle§5§l]"))))){
                      p.getPlayer().launchProjectile(Snowball.class);
                  }else{
                     
                  }
                  }
                  }
                  }else{
                     
                  }
                }
             
    }

i tried that dosent work

 

You don't need all of the color codes inside of the ChatColor.stripColor(), just do the String.

 

Code:java

@EventHandler
public void RightClick(PlayerInteractEvent e){
Player p = (Player) e.getPlayer();
ItemStack i = new ItemStack(Material.STICK);
ItemMeta meta = i.getItemMeta();
meta.setDisplayName("§5§l[§bBor Rifle§5§l]");
Player player = e.getPlayer();
if(e.getAction().equals(Action.LEFT_CLICK_AIR) && player.getItemInHand().getType() == Material.STICK){
if(p.getItemInHand().getType() == Material.APPLE){
ItemStack item = p.getItemInHand();
if(i.hasItemMeta()){
if(meta.getDisplayName().contains((ChatColor.stripColor(("[Bor Rifle]"))))){
p.getPlayer().launchProjectile(Snowball.class);
}else{
 
}
}
}
}else{
 
}
}
 
}

this dosent work either

 

Try adding some Debug lines

 

calebbfmv does it look like there is anything wrong with the code

 

ChromeHD__
Then there is something wrong with the item in your hand.
EDIT:
You never set the ItemMeta of the Itemstack

 

Well, it looks like on line 8, you're checking to see if the type of item in the player's hand is a stick, then on line 9 you're checking if it is a apple. So it's definitely gonna fail there.

 

Omg I can't believe I didn't see that haha I will check it out in the morning and post back Wolfey calebbfmv

DogeDev Wolfey i have tried everything it dosent work is there any working code out there

Here is my stacktrace

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ChromeHD__ getItemInHand can return null if there is no item in the hand.

Code:java

if(e.getAction().equals(Action.LEFT_CLICK_AIR) && player.getItemInHand() != null && player.getItemInHand().getType() == Material.STICK) {

 

Code:java

@EventHandler
    public void RightClick(PlayerInteractEvent  e){
        Player p = (Player) e.getPlayer();
        ItemStack i = new ItemStack(Material.STICK);
        ItemMeta meta = i.getItemMeta();
        if(p.getItemInHand().getType() == Material.STICK){
        if(e.getAction().equals(Action.RIGHT_CLICK_AIR)){
 
                  ItemStack item = p.getItemInHand();
                if(item.hasItemMeta()){
                if(meta.getDisplayName().equalsIgnoreCase((ChatColor.stripColor(("[Bor Rifle]"))))){
 
                      e.getPlayer().launchProjectile(EnderPearl.class);
                  }else{
                      p.sendMessage("debug");
                  }
                }
        }
        }
    }
}

new stack trace it creates it on right click

 

Read my last post, your still running getType() on null.

EDIT: Also, there is no need to cast (Player) event.getPlayer(). It's already a player.

 

Alshain01

Code:java

 if(meta.getDisplayName().equalsIgnoreCase((ChatColor.stripColor(("[Bor Rifle]"))))){

it appears on that line

 

Ok, you have more than one error then. You still need to check that they have something in your hand or your going to get an NPE anyway.

As for THAT line, getDisplayName can also be null.

 

Code:java

if(meta.getDisplayName().equalsIgnoreCase((ChatColor.stripColor(("[Bor Rifle]")))) && meta.getDisplayName() != null ){

i put the !=null on the getitem in hand and that above and its still saying that line Alshain01

Someone please help this has been annoying me for ages

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

ChromeHD__ hmm.. Define it as a single color, and just try to get that ChatColor.

 

You put it in the wrong place, your order of operations is using it prior to checking it.

Code:java

if(meta.getDisplayName() != null && meta.getDisplayName().equalsIgnoreCase(ChatColor.stripColor("[Bor Rifle]"))){

&& is a short circuit operator, meaning if the first condition is false, the second one never gets evaluated. That prevents the NPE.

 

Alshain01 Now i am not getting anything no stack trace no error

 

Right, because there is no display name (hence the reason you were getting a Null Pointer Exception).

 

Teaching people to do this probably isn't the best, as they might get confused if the colors happen to matter for what they're doing.

That said, use the ChatColor enum instead of the selection symbol codes.

 

Alshain01 but it still wont shoot the enderperal

 

Because you designed it so that if it did not have that Display Name, it wouldn't shoot the ender pearl. Does your stick have that display name set?

 

Alshain01 Yes when they use the command to spawn it in it sets the display name

 

ChromeHD__ Ok, I need the full code. Both a re-post of this updated method AND that command handler.

 

Alshain01 i will send you it in a pm

 

Just post it here.