Why do my commands not work (multiple commands with multiple arguments)

The commands /effectsigns & /effectsigns help work but not the /effectsigns help speed why?

Code:java

package me.mat.effectsigns;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.fusesource.jansi.Ansi.Color;
 
public class Main extends JavaPlugin {
 
 
    String Prefix = ChatColor.GREEN + "[" + ChatColor.AQUA + "EffectSigns" + ChatColor.GREEN + "]";
 
 
    public void onEnable() {
 
        System.out.println("EffectSigns Enabled");
 
        PluginManager pm = getServer().getPluginManager();
 
        pm.registerEvents(new PlayerListener(), this);
        pm.registerEvents(new SignListener(), this);
        pm.registerEvents(new BasicEvents(), this);
 
 
    }
 
 
    public void onDisable() {
 
        System.out.println("EffectSigns Disabled");
 
    }
 
 
    public boolean onCommand(CommandSender sender, Command command, String name, String[] args) {
        Player player = (Player) sender; {
        if(command.getName().equalsIgnoreCase("effectsigns")) {
            if(args.length == 0) {
 
            player.sendMessage(Prefix + ChatColor.DARK_AQUA + " [" + ChatColor.AQUA + "V 0.1" + ChatColor.DARK_AQUA + " ]"
            + ChatColor.GREEN +
                    " This Plugin Was Created by Mat" + ChatColor.DARK_AQUA + " / " + ChatColor.YELLOW + "yewtree8");
 
 
            return true;
            }
        }
 
        if(command.getName().equalsIgnoreCase("effectsigns")) {
            if(args.length == 1) {
                if(args[0].equalsIgnoreCase("help")) {
                    player.sendMessage(Prefix + ChatColor.GREEN + " Commands:" );
                    player.sendMessage(Prefix + ChatColor.GOLD + " /EffectSigns "
                    + ChatColor.LIGHT_PURPLE + "Gives Plugin Info & Version");
                    player.sendMessage(Prefix + ChatColor.GOLD + "/EffectSigns help" + ChatColor.LIGHT_PURPLE + " Shows This Menu");
                }
            }
 
 
 
 
 
            return true;
        }
        if(command.getName().equalsIgnoreCase("effectsigns")) {
            if(args.length == 1) {
                if(args[0].equalsIgnoreCase("help")) {
                    if(args[1].equalsIgnoreCase("speed")) {
                    if(player.hasPermission("effectsigns.command.speed"))  {
                        player.sendMessage(Prefix + ChatColor.DARK_RED + "-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|");
                        player.sendMessage(Prefix + ChatColor.DARK_AQUA + " Creating A Speed Sign");
                        player.sendMessage(Prefix + ChatColor.DARK_RED + "-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|");
                        player.sendMessage(Prefix + ChatColor.GOLD + " [ES]");
                        player.sendMessage(Prefix + ChatColor.GOLD + "Speed");
                        player.sendMessage(Prefix + ChatColor.DARK_RED + "-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|");
                        player.sendMessage(Prefix + ChatColor.RED + "You Must Have The Permission " + ChatColor.GREEN + "effectsigns.admin.speed");
                    } else {
                        player.sendMessage(Prefix + ChatColor.RED + " You Do Not Have The Permission" + ChatColor.GREEN + "effectsigns.command.speed");
                    }
 
                }
                }   
            }
 
 
 
 
        }
 
        return true;
 
        }
 
    }
 
}
 

Pretty confused

 

yewtree8
You're checking for too few arguments with (args.length == 1) Remember in programming arrays always start with 0. So change (args.length == 2) and /effectsigns help speed should work.


Scratch that, you're writing the code wrong. You don't need to create a new if statement for the same command, just check for different args under it.

 

args.length is always 1 ahead of getting the argument. so /effectsigns help speed is args.length == 2 but to get speed you would do args[1];

 

Brendyn Todd changed it to if(args.length == 2) but still no change?

 

yewtree8
I posted to soon, I've changed my post. You don't need to create a new if statement for a command to create each set arguments for the same command. You can just start a new (args.length == X) and check it that way.

 

Brendyn Todd can you edit my code then? i think i get what you mean but i'm not sure?

 

Notice how I don't use if(command.getName().equalsIgnoreCase("effectsigns") more than once. All you need to do is add a new if statement for if(args.length == X).
(May need reformatted, did without IDE)

Code:java

 
public boolean onCommand(CommandSender sender, Command command, String name, String[] args) {
Player player = (Player) sender; {
 
if(command.getName().equalsIgnoreCase("effectsigns")) {
if(args.length == 0) {
 
player.sendMessage(Prefix + ChatColor.DARK_AQUA + " [" + ChatColor.AQUA + "V 0.1" + ChatColor.DARK_AQUA + " ]"
+ ChatColor.GREEN +
" This Plugin Was Created by Mat" + ChatColor.DARK_AQUA + " / " + ChatColor.YELLOW + "yewtree8");
}
}
 
if(args.length == 1) {
if(args[0].equalsIgnoreCase("help")) {
player.sendMessage(Prefix + ChatColor.GREEN + " Commands:" );
player.sendMessage(Prefix + ChatColor.GOLD + " /EffectSigns "
+ ChatColor.LIGHT_PURPLE + "Gives Plugin Info & Version");
player.sendMessage(Prefix + ChatColor.GOLD + "/EffectSigns help" + ChatColor.LIGHT_PURPLE + " Shows This Menu");
}
}
}
 
if(args.length == 2) {
if(args[0].equalsIgnoreCase("help")) {
if(args[1].equalsIgnoreCase("speed")) {
if(player.hasPermission("effectsigns.command.speed")) {
player.sendMessage(Prefix + ChatColor.DARK_RED + "-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|");
player.sendMessage(Prefix + ChatColor.DARK_AQUA + " Creating A Speed Sign");
player.sendMessage(Prefix + ChatColor.DARK_RED + "-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|");
player.sendMessage(Prefix + ChatColor.GOLD + " [ES]");
player.sendMessage(Prefix + ChatColor.GOLD + "Speed");
player.sendMessage(Prefix + ChatColor.DARK_RED + "-|-|-|-|-|-|-|-|-|-|-|-|-|-|-|");
player.sendMessage(Prefix + ChatColor.RED + "You Must Have The Permission " + ChatColor.GREEN + "effectsigns.admin.speed");
} else {
player.sendMessage(Prefix + ChatColor.RED + " You Do Not Have The Permission" + ChatColor.GREEN + "effectsigns.command.speed");
}
 
}
}
}
return true;
}
 
}

 

Brendyn Todd I love you, like for you good sir

 

yewtree8
Guess it worked then, make sure to set this thread to solved so others don't waste their time.