name and enchant a stick (help)

OK i had a little help with an error i had doing this (only my second plugin)

here is what i have so far:

Code:java

package me.rebz.snowball;
 
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.entity.Snowball;
 
    public class Main extends JavaPlugin implements Listener {
        public void onEnable(){
            Bukkit.getServer().getPluginManager().registerEvents(this, this);
        }
 
        public Main Main;
 
        @EventHandler(ignoreCancelled = false, priority = EventPriority.MONITOR)
        public void onStick(PlayerInteractEvent event){
            Player player = event.getPlayer();
 
            if(player.getInventory().getItemInHand().getType() == Material.STICK){
                if(event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK){
                    player.launchProjectile(Snowball.class);
                }
            }
 
        }
 
    }

do i had an idea and i know how to do some of it:

What i want to do is, when a player types in /snowgun it will give them an enchanted (knockback II stick named idk.... lets go with 'snow gun'

This way a normal stick wouldn't launch snowballs i can do the command part as far as.. command gives them the stick.

How would i go about doing this the naming and enchanting and normal sticks not being 'snow gun'

 

@Rebz01 you can give the ItemStack a custom name, and you can do ItemStack.addUnsafeEnchantments
(Since adding it so a stick is not legit)

Than make a check on the interact part, the name and enchants.

 

added the part where i need to type in a command to get the stick (i did google assistance with the name & enchant before posting here)

Code:java

package me.rebz.snowball;
 
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.entity.Snowball;
 
public class Main extends JavaPlugin implements Listener {
public void onEnable(){
Bukkit.getServer().getPluginManager().registerEvents(this, this);
}
 
public Main Main;
public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
if(CommandLabel.equalsIgnoreCase("snowgun")){
if (!(sender instanceof Player)){
sender.sendMessage("Don't be a noob you're not a player!");
return true;
}
else{
 
@EventHandler(ignoreCancelled = false, priority = EventPriority.MONITOR)
public void onStick(PlayerInteractEvent event){
Player player = event.getPlayer();
 
if(player.getInventory().getItemInHand().getType() == Material.STICK){
if(event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK){
player.launchProjectile(Snowball.class);
}
}
 
}
 
}

Although on the else 'else{' the '{' is flagged:
Syntax error, insert "}" to complete Block
Syntax error, insert "}" to complete MethodBody
Syntax error, insert "}" to complete Statement
Syntax error, insert "else Statement" to complete BlockStatements

So lol clearly im missing something there too.

 

@Rebz01
Tips:
1. Why would you use the MONITOR priority?
2. No need to have the "ignorecancelled = false".
3. Wheres your code for giving the snowgun?
4. Please learn proper grammer, kthx.

 

I'm not sure how to do this the knockback isn't important just yet though, a stick that isn't a gun shouldn't throw snowballs is my first hurdle

1. one of my friends told me to add that line, i know it works without
2. removed the whole line. ty
3. code is added in the second paste
4. off topic and unnecessary (grammar*)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

RebzO1
1. So what are you doing to give the player the snowgun?
2. Do you even know what that line does?

 

Mrawesomecookie
1. player will type /snowgun to get it
2. no clue i assumed he knew lol

As i have no prior plugin/coding experience i threw what i have together by watching and reading bukkit tuts

 

Then you probably should not be making Bukkit plugins right now. Try watching a good tutorial series on Bukkit.

 

Mrawesomecookie
Yes maybe so
But who are you to tell anyone they shouldn't do something...
I learn by creating smaller projects and work up.

If i need help i am not afraid to ask.
This is the second time you posted something pointless on my thread, if you have no intention of offering advice pls get your post count up elsewhere.

I still have the issue of not knowing how to name a stick 'snowgun' and making it so that a normal stick does not throw snowballs

this is what i have so far:

Code:java

package me.rebz.snowball;
 
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.entity.Snowball;
 
    public class Main extends JavaPlugin implements Listener {
        public void onEnable(){
            Bukkit.getServer().getPluginManager().registerEvents(this, this);
        }
 
        public Main Main;
        public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
        if(CommandLabel.equalsIgnoreCase("snowgun")){
            if (!(sender instanceof Player)){
                sender.sendMessage("Don't be a noob you're not a player!");
                return true;
            }
            else{
 
        public void onStick(PlayerInteractEvent event){
            Player player = event.getPlayer();
 
            if(player.getInventory().getItemInHand().getType() == Material.STICK){
                if(event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK){
                    player.launchProjectile(Snowball.class);
                }
            }
        }
        }

still have this issue too:
the 'else{' the '{' is flagged:
Syntax error, insert "}" to complete Block
Syntax error, insert "}" to complete MethodBody
Syntax error, insert "}" to complete Statement
Syntax error, insert "else Statement" to complete BlockStatements

any help or positive criticism would be appreciated
regards
rebz

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

RebzO1
If you want to change the item's name use something like this:

Code:java

is.getItemMeta().setDisplayName(ChatColor.RED + "SnowGun");

Also, I have not looked at my post count since I signed up to this forum.

 

Mrawesomecookie ok i think i added that in the correct place

Mrawesomecookie
i still don't know where i went wrong the syntax error is stopping me compiling the plugin to test
the 'else{' the '{' is flagged:
Syntax error, insert "}" to complete Block
Syntax error, insert "}" to complete MethodBody
Syntax error, insert "}" to complete Statement
Syntax error, insert "else Statement" to complete BlockStatements


i have tried putting } in various places without any luck

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You are putting an event in a command method, without putting @EventHandler.
So you should add a } on line 28 (last code), and also @EventHandler before the onStick method.

 

ok ill try that now

MOMOTHEREAL
current code:

Code:java

package me.rebz.snowball;
 
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.entity.Snowball;
import org.bukkit.inventory.ItemStack;
 
public class Main extends JavaPlugin implements Listener {
public void onEnable(){
Bukkit.getServer().getPluginManager().registerEvents(this, this);
}
 
public Main Main;
public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
if(CommandLabel.equalsIgnoreCase("snowgun")){
if (!(sender instanceof Player)){
sender.sendMessage("Don't be a noob you're not a player!");
return true;
}
}
else{
 
@EventHandler public void onStick(PlayerInteractEvent event){
Player player = event.getPlayer();
 
if(player.getInventory().getItemInHand().getType() == Material.STICK){
if(event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK){
ItemStack is;
is.getItemMeta().setDisplayName(ChatColor.RED + "SnowGun");
player.launchProjectile(Snowball.class);
}
}
}
}

still getting errors on that { after else though
- Syntax error, insert "}" to complete Block
- Syntax error, insert "}" to complete MethodBody


*facedesk*

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Mrawesomecookie RebzO1 Stop. One, don't watch TheBCBroz, they teach bad and outdated methods, also, learn Java first, before you learn Bukkit.

 

Replace:

Code:

 public Main Main;
        public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
        if(CommandLabel.equalsIgnoreCase("snowgun")){
            if (!(sender instanceof Player)){
                sender.sendMessage("Don't be a noob you're not a player!");
                return true;
            }
            else{

With:

Code:

 public Main Main;
        public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
        if(CommandLabel.equalsIgnoreCase("snowgun")){
            if (!(sender instanceof Player)){
                sender.sendMessage("Don't be a noob you're not a player!");
                return true;
            } else{
                Player p = (Player) sender;
                ItemStack stick = new ItemStack(Material.STICK);
                ItemMeta im = stick.getItemMeta();
                im.setDisplayName("Snow Gun");
                stick.setItemMeta(im);
                stick.addEnchantment(Enchantment.KNOCKBACK, 2);
                p.setItemInHand(stick);
}

 

i can see what your code is doing however the addUnsafeEnchantment is flagged and when i click quickfix it says remove unsafe then its flagged again saying put unsafe back.

however i really appreciate your help this is the biggest step forward all day lol

xGamingDudex
forgot tahg for post above

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Sorry, my bad, just use the unsafe enchantment as this will ignore checking if the item is actually fit the enchantment. I'm using 1.74 R0.2 and doesn't get any flags, but if it tells you that it is deprecated or something like that then just ignore it, as long as it runs fine you shouldn't have to worry

 

xGamingDudex
No need for sorry i just learned somethin from you so even though im still stuck i can actually understand your changes.

stick.UnsafeEnchantment(Enchantment.KNOCKBACK, 2);

The method UnsafeEnchantment(Enchantment, int) is undefined for the type ItemStack

thats the error i get xGamingDudex

 

are you importing org.bukkit.inventory.ItemStack?

 

xGamingDudex

yes, when i comment out that line about enchantments i can type /snowgun and i get a stick that fires snowballs
unfortunately lol a normal stick does the same.

but yes org.bukkit.inventory.ItemStack is there

Code:java

package me.rebz.snowball;
 
//import net.minecraft.server.v1_7_R1.Enchantment;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.Bukkit;
//import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.EventHandler;
//import org.bukkit.event.EventPriority;
import org.bukkit.event.block.Action;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.entity.Snowball;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
    public class Main extends JavaPlugin implements Listener {
        public void onEnable(){
            Bukkit.getServer().getPluginManager().registerEvents(this, this);
        }
 
        public Main Main;
        public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
        if(CommandLabel.equalsIgnoreCase("snowgun")){
            if (!(sender instanceof Player)){
                sender.sendMessage("Don't be a noob you're not a player!");
                return true;
            } else{
                Player player = (Player) sender;
                ItemStack stick = new ItemStack(Material.STICK);
                ItemMeta im = stick.getItemMeta();
                im.setDisplayName("SnowGun");
                stick.setItemMeta(im);
//                snowgun.addUnsafeEnchantment(Enchantment.KNOCKBACK, 2);
                player.setItemInHand(stick);
            }
        }
        return false;
        }
        @EventHandler public void onStick(PlayerInteractEvent event){
            Player player = event.getPlayer();
 
            if(player.getInventory().getItemInHand().getType() == Material.STICK){
                if(event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK){
                    player.launchProjectile(Snowball.class);
                }
            }
        }
        }

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

stick.UnsafeEnchantment(Enchantment.KNOCKBACK, 2);
has to be:
stick.addUnsafeEnchantment(Enchantment.KNOCKBACK, 2);

Also, I strongly suggest to learn more Java before doing all of this.

 

I reccomend practicing by starting off small, making plugins for the basic commands "/teleport", "/heal", etc, and learning how to use arraylists and hashmaps; once you've mastered all that, you can start making more complex plugins.
Well, you don't have to do that, that's just my reccomendation

 

ok we have it working
we have an enchanted stick called snowgun that fires snowballzzzz
thank you guys
error was fixed by adding @eventhandler

Wizehh

i am in complete agreement i think i bit off more than i can chew here, making a stick fire snowballs was kinda easy but all the stuff i wanted to add was a bit much,

ill be taking a step backwards now and make sure i understand what im doing as im doing it..
the good thing abouth this thread is i understand why it now works and not what i was doing wrong but what i had missed.

thanks again guys
RebzO1

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Awesome, really glad I could help!

 

Wizehh
the only problem im having is a stick still fires snowballs whereas the snowgun has knockback2 and fires snowballs
the normal sticks shouldn't do anything

 

Use an if statement to check the display name/item meta of the item.

 

Wizehh i will look into that tommoz you have been a great help and myself and the players waiting for this appreciate it!

i have had too much to drink to see which line i type on at the moment

 

Sure, no problem.

 

Wizehh

plugin works as needed now

next projext starts now

 

RebzO1 Nice