Solved Giving players items glitch (with signs)

Hello, I am trying to give players items according to what class they are on, this is EXTREMELY buggy. For some reason when you click the sign, you get tp'd but about 70% of the time you see a blank inventory once you are tp'dand you have to click one of the armor slots for the inventory to update itself, I have absolutely no idea what is causing this and I have spent a large amount of time trying to figure it out.


I have possibly found the cause. When I have the 1st selected inventory slot, it gives the items, but any other, it gives the items but does not update the inventory!

Code:java

 @EventHandler
private void onPlayerInteract(PlayerInteractEvent e) {
Location lobby = new Location(Bukkit.getWorld("world"), 349, 67, 228);
Player player = e.getPlayer();
PlayerInventory pi = player.getInventory();
if (!(e.getAction() == Action.RIGHT_CLICK_BLOCK)) return;
if (e.getClickedBlock().getState() instanceof Sign) {
Sign s = (Sign) e.getClickedBlock().getState();
if (s.getLine(0).equalsIgnoreCase("§1[Knight]")) {
pi.clear();
player.sendMessage(ChatColor.GREEN + "You have been given the kit of an Knight");
player.sendMessage(ChatColor.GREEN + "You have been teleported to the lobby area!");
player.teleport(lobby);
pi.addItem(KSword);
if(Main.blue.contains(player)){
pi.setHelmet(creeperHelmet);
pi.setChestplate(BChest);
pi.setLeggings(BLeggings);
pi.setBoots(BBoots);
}else{
pi.setHelmet(Rhelm);
pi.setChestplate(RChest);
pi.setLeggings(RLeggings);
pi.setBoots(RBoots);
}
}
if (s.getLine(0).equalsIgnoreCase("§1[Archer]")) {
pi.clear();
player.sendMessage(ChatColor.GREEN + "You have been given the kit of an Archer!");
player.sendMessage(ChatColor.GREEN + "You have been teleported to the lobby area!");
player.teleport(lobby);
pi.addItem(ABow);
if(Main.blue.contains(player)){
pi.setHelmet(creeperHelmet);
pi.setChestplate(BChest);
pi.setLeggings(BLeggings);
pi.setBoots(BBoots);
}else{
pi.setHelmet(Rhelm);
pi.setChestplate(RChest);
pi.setLeggings(RLeggings);
pi.setBoots(RBoots);
}
}
}
}

There are no errors at all, like I said, sometimes you have to click for it to update, sometimes you don't.

 

RizzelDazz You need to update the player's inventory.

Code:java

player.updateInventory();

 

RizzelDazz Try setting the Interact event to cancelled before giving the players the items.

 

Yea figured that out, thanks.

 

*** OFF TOPIC ***​

​

You can type (CTRL + SHIFT + F) whilst having all you code selected to clean it up and make it look nicer ​

 

The only thing I don't like about that is the way it formats messages

 

You can also use CTRL + a to highlight everything then CTRL + i to format i
keeps the message one line

 

Thanks, learning new things everyday.

 

Happy to help

 

Anytime