Hide join message from player who joined?

I would like to set the join message for the player who joined to null, otherwise if it isn't the player, send everyone else the join message:

I have tried using:

Code:java

                        for (Player players : Bukkit.getOnlinePlayers()) {
 
                            if (!players.getName().equals(p.getName())) {
 
                                e.setJoinMessage(ChatColor.RED + "joinmsg");
 
                            }
 
                        }

Which didn't seem to work. Thanks!

 

Even though you're looping online players, you must check if the player is online. Example:

Code:java

 
    @EventHandler
    public void onPlayerLogin(PlayerLoginEvent) {
        Player player = event.getPlayer();
        for(Player aPlayer : Bukkit.getOnlinePlayers()) {
            if(aPlayer.isOnline()) {
                if(!(aPlayer.getName().equals(player.getName()))) {
                    aPlayer.sendMessage(player.getName() + " has joined the game!");
                }
            }
        }
    }
 

 

Why check that the player is online? As you can see, its Bukkit.getONLINEPlayers()

 

I'm not so sure about needing to check if a player is online. However, you may want to:

Code:java

e.setJoinMessage("");

You're re-setting the join message that's sent to all players with every time that's called in your current code. Setting that to "" means that the original functionality where the join message is broadcast to everyone is removed. Now no one would get notified. Then we need to notify those that need to be notified AKA everyone other than the newly logged in player.
in the for each, use:

Code:java

player.sendMessage(ChatColor.RED+ "joinmsg");

 

It's a good habit to do this. In some cases checking online players may involve you needing to check offline players; therefore you need to check if the offline player is online (which also works).

 

EDIT: I read your post wrong

 

It is not a good habit because it is inefficient.

 

Agreed. And you can never loop a offline player.

 

Bukkit.getOfflinePlayers

 

Louis1234567890987654321 Why would you need that? Only Bukkit uses that for deopping and stuff

elementalgodz11 e.setJoinMessage(null);

Done

 

I know we won't need that most of the time, i'm just saying that function exists.

 

It's not a good habit unless you are, for some reason, storing player objects after they've left, and you shouldn't be storing them in the first place.