Wont let me add a command to the main class?

Hey everyone, so when I type this method

Code:java

getCommand("gdeagles").setExecutor(new gDeagles());

I get an error at "setExecutor"
Here is my gDeagles class

Code:java

package me.niknea.EnhancedGuns;
 
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class gDeagles implements Listener, CommandExecutor
{
    @EventHandler
    public void onPlayerInteract (PlayerInteractEvent event)
    {
        Player player = event.getPlayer();
        if(player.getItemInHand().getType() == Material.GOLD_SPADE)
        {
            if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)
            {
            player.launchProjectile(Snowball.class);
            }
        }
    }
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onEntityDamage(EntityDamageByEntityEvent event) {
    if (event.getDamager() instanceof Snowball)
    {
        Snowball e = (Snowball) event.getDamager();
        if (e.getShooter() instanceof Player)
        {
            Player shooter = (Player) e.getShooter();
          if (shooter.getItemInHand().getType() == Material.GOLD_SPADE)
          {
              event.setDamage(4);
          }
        }
        }
      }
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
    {
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("gdeagles"))
        {
        ItemStack gspade = new ItemStack(Material.GOLD_SPADE);
        ItemMeta ak47meta = gspade.getItemMeta();
        ak47meta.setDisplayName(ChatColor.GOLD + "" + ChatColor.BOLD + "Golden Deagles");
        ArrayList<String> ak47lore = new ArrayList<String>();
        ak47lore.add(ChatColor.DARK_PURPLE + "This weapon deals 2 hearts per shot.");
        ak47meta.setLore(ak47lore);
        gspade.setItemMeta(ak47meta);
        player.getInventory().addItem(gspade);
        player.sendMessage(ChatColor.GOLD + "Here is your" + ChatColor.GREEN + "Golden Deagles" + ChatColor.GOLD + "!");
        }
        return true;
    }
}

Thanks again,
Niknea

 

Not sure if it helps, but I think you should put @Override ontop of your onCommand() method

 

Maulss Nope doesn't work.

 

Niknea
Where do you get this error, in your software (Compilation error) or when you actually enable the plugin?
If it's the compilation error, what error does it give you? Otherwise, what exception do you get in the console?

I've tested the code myself and it all works fine. It might be a silly thing to think about, but is there a chance that you have this:
getCommand("gdeagles").setExecutor(new gDeagles());
Set up outside of onEnable()?

 

Maulss Nope
Here is my main class

Code:java

package me.niknea.EnhancedGuns;
 
import org.bukkit.Bukkit;
import org.bukkit.event.Listener;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.java.JavaPlugin;
 
 
    public class Main extends JavaPlugin
    {
 
        private static Plugin plugin;
    @Override
        public void onEnable() {
            plugin = this;
            registerEvents(this, new Ak47(), new myCustomInventory(), new gDeagles());
            getCommand("ak47").setExecutor(new Ak47());
            getCommand("guns").setExecutor(new oMenu());
            getCommand("gdeagles").setExecutor(new gDeagles());
            getLogger().info("Enabling Enhanced Guns! Created by Niknea.");
 
        }
      @Override
        public void onDisable() {
          getLogger().info("Disabling Enhanced Guns! Created by Niknea.");
        }
 
        //Much easier then registering events in 10 different methods
        public static void registerEvents(org.bukkit.plugin.Plugin plugin, Listener... listeners) {
            for (Listener listener : listeners) {
                Bukkit.getServer().getPluginManager().registerEvents(listener, plugin);
            }
        }
 
        //To access the plugin variable from other classes
        public static Plugin getPlugin() {
            return plugin;
        }
 
 
 
 
    }
 
 

And here is the error I got on

Code:

setExecutor

.
"The method setExecutor in the type PluginCommand is not applicable for the arguments (gDeagles)"

Also my other two commands that I added to the main class work, it's just the gDeagle one that dosent.

 

Niknea
Can I see another one of your CommandExecutor classes?

 

Maulss

Code:java

package me.niknea.EnhancedGuns;
 
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class Ak47 implements Listener, CommandExecutor
{
 
@EventHandler
public void onPlayerInteract (PlayerInteractEvent event)
{
    Player player = event.getPlayer();
    if(player.getItemInHand().getType() == Material.WOOD_SPADE)
    {
        if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)
        {
        player.launchProjectile(Snowball.class);
 
        }
    }
}
@SuppressWarnings("deprecation")
@EventHandler
public void onEntityDamage(EntityDamageByEntityEvent event) {
if (event.getDamager() instanceof Snowball)
{
    Snowball s = (Snowball) event.getDamager();
    if (s.getShooter() instanceof Player)
    {
        Player shooter = (Player) s.getShooter();
      if (shooter.getItemInHand().getType() == Material.WOOD_SPADE)
      {
          event.setDamage(3);
      }
    }
    }
  }
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
{
    Player player = (Player) sender;
    if(cmd.getName().equalsIgnoreCase("ak47"))
    {
        ItemStack wspade = new ItemStack(Material.WOOD_SPADE);
        ItemMeta ak47meta = wspade.getItemMeta();
        ak47meta.setDisplayName(ChatColor.GOLD + "" + ChatColor.BOLD + "Ak47");
        ArrayList<String> ak47lore = new ArrayList<String>();
        ak47lore.add(ChatColor.DARK_PURPLE + "This weapon deals 1.5 hearts per shot.");
        ak47meta.setLore(ak47lore);
        wspade.setItemMeta(ak47meta);
        player.getInventory().addItem(wspade);
        player.sendMessage(ChatColor.GOLD + "Here is your" + ChatColor.GREEN + "Ak47" + ChatColor.GOLD + "!");
 
 
 
 
    }
 
 
    return true;
}
}
 

 

Niknea
Hmm, both work fine for me:

Make sure there isn't another class called gDeagles that is overriding that one.

EDIT: Just realized, that error pops up when you don't implement CommandExecutor in your Executor class. You have it implemented, which means there is a more than likely chance that there is another class called gDeagles in your plugin that is interfering with the other one (Which doesn't implement CommandExecutor).

 

I usually write getCommand ("blahblah").setExecutor(new blubub, this);

Try that.

[EDIT]

Sorry, i need to learn how to read the whole posts before posting

 

Maulss Nope, no other class named gDeagles

Maulss I renamed the class to Deagles and I don't get an error, however now the command dosen't work. Any ideas?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Niknea
Renaming the class to Deagles actually proves you had something overriding it.
Nevertheless, do you get any stacktraces or some kind of debugging messages when you try to execute the command?

 

Maulss Nope, just says it's an unknown command

 

Niknea
Perhaps you forgot to add it to the plugin.yml?

 

Maulss Nope it's added

 

Niknea
I've never played around with commands in separate classes, so I'm not positive your method should work. Try executing all commands from the same CommandExecutor class. Don't forget to change the executors in the main class.

 

Maulss
Still dosen't work here is my new class I added the command.

Code:java

package me.niknea.EnhancedGuns;
 
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.entity.Snowball;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.Action;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class Ak47 implements Listener, CommandExecutor
{
 
@EventHandler
public void onPlayerInteract (PlayerInteractEvent event)
{
    Player player = event.getPlayer();
    if(player.getItemInHand().getType() == Material.WOOD_SPADE)
    {
        if (event.getAction() == Action.RIGHT_CLICK_AIR || event.getAction() == Action.RIGHT_CLICK_BLOCK)
        {
        player.launchProjectile(Snowball.class);
 
        }
    }
}
@SuppressWarnings("deprecation")
@EventHandler
public void onEntityDamage(EntityDamageByEntityEvent event) {
if (event.getDamager() instanceof Snowball)
{
    Snowball s = (Snowball) event.getDamager();
    if (s.getShooter() instanceof Player)
    {
        Player shooter = (Player) s.getShooter();
      if (shooter.getItemInHand().getType() == Material.WOOD_SPADE)
      {
          event.setDamage(3);
      }
    }
    }
  }
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
{
    Player player = (Player) sender;
    if(cmd.getName().equalsIgnoreCase("ak47"))
    {
        ItemStack wspade = new ItemStack(Material.WOOD_SPADE);
        ItemMeta ak47meta = wspade.getItemMeta();
        ak47meta.setDisplayName(ChatColor.GOLD + "" + ChatColor.BOLD + "Ak47");
        ArrayList<String> ak47lore = new ArrayList<String>();
        ak47lore.add(ChatColor.DARK_PURPLE + "This weapon deals 1.5 hearts per shot.");
        ak47meta.setLore(ak47lore);
        wspade.setItemMeta(ak47meta);
        player.getInventory().addItem(wspade);
        player.sendMessage(ChatColor.GOLD + "Here is your" + ChatColor.GREEN + "Ak47" + ChatColor.GOLD + "!");
 
 
 
 
    }
    else if(cmd.getName().equalsIgnoreCase("gdeagles"))
    {
    Player player1 = (Player) sender;
        ItemStack gspade = new ItemStack(Material.GOLD_SPADE);
    ItemMeta ak47meta = gspade.getItemMeta();
    ak47meta.setDisplayName(ChatColor.GOLD + "" + ChatColor.BOLD + "Golden Deagles");
    ArrayList<String> ak47lore = new ArrayList<String>();
    ak47lore.add(ChatColor.DARK_PURPLE + "This weapon deals 2 hearts per shot.");
    ak47meta.setLore(ak47lore);
    gspade.setItemMeta(ak47meta);
    player1.getInventory().addItem(gspade);
    player1.sendMessage(ChatColor.GOLD + "Here is your" + ChatColor.GREEN + "Golden Deagles" + ChatColor.GOLD + "!");
 
    return true;
}
    return true;
}
}
 

 

Niknea
Do all other commands work?

 

Maulss Yes

 

Niknea
Can I see your onEnable() and plugin.yml please?

 

Maulss

Code:java

 @Override
        public void onEnable() {
            plugin = this;
            registerEvents(this, new Ak47(), new myCustomInventory(), new Deagles());
            getCommand("ak47").setExecutor(new Ak47());
            getCommand("guns").setExecutor(new oMenu());
            getCommand("gdeagles").setExecutor(new Ak47());
            getLogger().info("Enabling Enhanced Guns! Created by Niknea.");
 
        }

Plugin.yml

Code:

name: Enhanced Guns
version: 1.0
main: me.niknea.EnhancedGuns.Main
description: Enhanced Guns!
 
commands:
  ak47:
      description: This command gives you the Ak47!
  guns:
      description: This command displays a menu with all the guns!
  gdeagles:
      description: This command gives you the Golden Deagles!
 

 

Niknea
Thanks. Can I also see your server log with you attempting all of the commands?

 

Not sure if this has anything to do with it, but don't issues arise from multiple implements?
Out of curiosity, try swapping the implementations or removing Listener completely and see what it does.

 

Maulss It won't be useful, it just says unknown command.

Wehttam664 That won't work as the ak47 class implements both yet everything works, besides the gdeagles.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

This error is pretty interesting...
Out of curiosity, try changing the label of the command. If it still doesn't work, try making that command a second argument of another one. This way we should ease in on the actual error

 

For debugging purposes, try creating the new gDeagles class as a variable, checking if that variable is an instance of CommandExecutor; printing something if false or calling the setExecutor if true. Can't hurt to try.

 

Maulss How would I try #2?

Wehttam664 Didn't work

Maulss I even made a new command and didn't work Any ideas?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Niknea
Repaste the class that isn't working

 

AoH_Ruthless

Code:java

package me.niknea.EnhancedGuns;
 
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
 
public class GoldenGet implements CommandExecutor
{
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args)
    {
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("gdeagles"))
        {
            ItemStack gspade = new ItemStack(Material.GOLD_SPADE);
            ItemMeta gmeta = gspade.getItemMeta();
            gmeta.setDisplayName(ChatColor.GOLD + "" + ChatColor.BOLD + "Golden Deagles");
            ArrayList<String> glore = new ArrayList<String>();
            glore.add(ChatColor.DARK_PURPLE + "This weapon deals 2 hearts per shot.");
            gmeta.setLore(glore);
            gspade.setItemMeta(gmeta);
            player.getInventory().addItem(gspade);
            player.sendMessage(ChatColor.GOLD + "Here is your" + ChatColor.GREEN + "Golden Deagles" + ChatColor.GOLD + "!");
 
        }
return true;
    }
}

 

Niknea
You should be returning false on line 32 .., and add a return true after line 29.
If you're doing similar things on other commands, fix them.

 

AoH_Ruthless
Still doesn't work.