Need Help with my First Plugin!

http://pastebin.com/0hmHrYAK

The plugin is meant to see if the player is blocking, and heal them.
For some reason, it doesn't. Please help!

 

ZaynTheGreat
You put your isBlocking() if statement in your onCommand method, yet you don't have anything referencing a command. Hope that makes sense.

 

You need to set p.setHealth(20), not 2.0 and deprecate it(hover the mouse over it and click deprecate ).

 

So, what do I do to fix it?

 

Remove your onCommand method.
And your if statement should be like this:

Code:java

 if(player.isBlocking()){
                        player.setHealth(20);
                        player.sendMessage("You have been healed!");
        }

Since blocking isn't a command, there is no need for the onCommand method. You would need to use a Listener for the code. Not sure how to do it myself :I

 

ZaynTheGreat You should not use the onCommand method because thats for commands and instead use a listener listening for the PlayerInteractEvent. Also, you should just set the player's health to his max health.

Code:java

@EventHandler
public void onPlayerBlock(PlayerInteractEvent e){
Player p = e.getPlayer();
if(player.isBlocking()){
player.setHealth(player.getMaxHealth());
player.sendMessage("You have been healed!");
}

 

Why would you deprecate it? Why wouldn't you give it support for when Bukkit updates and breaks plugins with ints?

 

Can you show me where to add that?

How do I define the player?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Oh lord.

 

Look, I'm new, I have no idea in regards to this stuff. Instead of just sighing and moving on, can you just help me please?

 

ZaynTheGreat

#LearnJava

An Event is it's own separate method that you can call. Just paste the code Developing gave you as an isolated method (Don't place it in your onEnable, onCommand, or any of that stuff). The following links may help you out some.
You also have to implement Listener and register the events (as the links detail).
http://wiki.bukkit.org/Plugin_Tutorial
http://wiki.bukkit.org/Event_API_Reference

 

I personally prefer deprecating. It's quicker and better.

 

I am sorry for being rude, but that statement contains extremely little logic.

 

It's quite alright. I'm at my cousins currently and I'm not thinking straight. I'll reply when I get home.