Solved Making a Toggle Command

Hello everyone,

I have been messing around with developing and made a flashlight plugin that I currently use on my server and was curious how would I make my command /flashlight on/off into a toggle command so the user can type /flashlight and it will toggle it on/off
I know how hashmaps and Arraylist work I just don’t know where to put them and where to add the command into since I haven’t been able to look at a good example of one.

Here is my current code:

Code:java

package com.hybrah;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
 
public class FlashlightPlus extends JavaPlugin {
 
    public void onEnable() {
        this.getConfig().options().copyDefaults(true);
            getServer().getPluginManager().disablePlugin(this);
            return;
        }     
        public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
            if(cmd.getName().equalsIgnoreCase("Flashlight") || cmd.getName().equalsIgnoreCase("flash") || cmd.getName().equalsIgnoreCase("fl")) {
 
                if (!(sender instanceof Player)) {
                    sender.sendMessage(ChatColor.RED + "Must be a player to exucute this command!");
                    return true;
                }
 
                if (!sender.hasPermission("flashlight.use")) {
                    sender.sendMessage(ChatColor.RED + "You do not have permission to perform this command!");
                    return true;
                }
 
                if(args.length <= 0){
 
                    sender.sendMessage(ChatColor.GREEN + "/flashlight on - Turns Flashlight ON!");
                    sender.sendMessage(ChatColor.GREEN + "/flashlight off - Turns Flashlight OFF!");
 
                    return true;
                }
 
                if (args.length == 1) {
 
                    if (sender instanceof Player) {
                        Player player = (Player) sender;
 
                        if(args[0].equalsIgnoreCase("on")) {
                            player.addPotionEffect(new PotionEffect(PotionEffectType.NIGHT_VISION, Integer.MAX_VALUE, 0));
                                sender.sendMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("FlashlightOnMsg")));
                                return true;
                        }
                        if(args[0].equalsIgnoreCase("off")) {
                            player.removePotionEffect(PotionEffectType.NIGHT_VISION);
                                sender.sendMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("FlashlightOffMsg")));
                        }
                    }
                }
            }
            return true;
    }
}
 

If anyone has a bit of code that displays how Toggle commands are used or wants to explain what bit of code to put there that would be great

Thanks in advance,

FallenYouth

 

Do this:

Code:java

    public final Set<String> flashlight = new HashSet<String>();

then check when they do the /flashlight command if they are within the flashlight hashmap, if they are remove them and do whatever, if they aren't add them and do whatever

 

FallenYouth You could also just do

Code:java

 
boolean active = false;
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label,
String[] args) {
 
if (cmd.getName().equalsIgnoreCase("Flashlight")
|| cmd.getName().equalsIgnoreCase("flash")
|| cmd.getName().equalsIgnoreCase("fl")) {
 
// ^^ Your other code ^^
 
if (sender instanceof Player) {
Player player = (Player) sender;
 
if (active == false) {
player.addPotionEffect(new PotionEffect(
PotionEffectType.NIGHT_VISION, Integer.MAX_VALUE, 0));
sender.sendMessage(ChatColor.translateAlternateColorCodes(
'&', getConfig().getString("FlashlightOnMsg")));
return true;
}
if (active == true) {
player.removePotionEffect(PotionEffectType.NIGHT_VISION);
sender.sendMessage(ChatColor.translateAlternateColorCodes(
'&', getConfig().getString("FlashlightOffMsg")));
}
}
}
return true;
}

 

AzubuSan Does this use a Hashmap and anything like that or is that the code to make it a toggle command?

 

FallenYouth That's all there is to it. It uses the

Code:java

boolean active = false;

to check if the users flashlight is active or not, if it is turn it off on command usage, is it false, turn it on instead.

EDIT: The code I posted is your code shortened to just for the purpose of showing what I mean, don't forget to add it back (In case your copying it).

 

There is no need to do this when you can just set aliases in the plugin.yml

 

AzubuSan Ah that makes a lot of sense, Thanks!

I will add it into my code and give it a test

 

FallenYouth Also, do what the_merciless said, instead of that jumble of ors just add aliases in your plugin.yml.
(Like so:

Code:

commands:
    flashlight:
      description: Toggles the flashlight
      usage: /<command>
      aliases: [fl,flashl,flight]

# Or whatever you want your aliases to be
)

 

AzubuSan Okay just got it all added and went to test it will turn the flashlight on but will not turn it off when enabled.

I have a feeling that it is not checking if the player has it enabled.

 

Code:

    List<String> flashlightEnabled = new ArrayList<String>();
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label,String[] args) {
 
        if (cmd.getName().equalsIgnoreCase("Flashlight") {
 
            if (sender instanceof Player) {
                Player player = (Player) sender;
 
                if (!flashlightEnabled.contains(player.getName())) {
                    player.addPotionEffect(new PotionEffect(PotionEffectType.NIGHT_VISION, Integer.MAX_VALUE, 0));
                    sender.sendMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("FlashlightOnMsg")));
                    flashlightEnabled.add(player.getName());
                    return true;
                }else{
                    player.removePotionEffect(PotionEffectType.NIGHT_VISION);
                    sender.sendMessage(ChatColor.translateAlternateColorCodes('&', getConfig().getString("FlashlightOffMsg")));
                    flashlightEnabled.remove(player.getName());
                    return true;
                }
            }
        }
        return true;
    }

 

FallenYouth Do what he said, more efficient. Sorry if mine didn't work!

 

Thank you everyone that helped I got it to work and added some more stuff to it