Code not working, need help!

Hello,

When i'm reloading my server the plugin gives this error in the console. When I enable the server there no errors and everything works fine. What goes wrong?

Code:

2013-10-16 18:48:32 [WARNING] [Project] Task #35 for Project v0.1 generated an exception
java.lang.IllegalArgumentException: Scoreboard cannot be null
    at org.apache.commons.lang.Validate.notNull(Validate.java:192)
    at org.bukkit.craftbukkit.v1_6_R3.entity.CraftPlayer.setScoreboard(CraftPlayer.java:1005)
    at me.mistachocolata.project.Main.update(Main.java:109)
    at me.mistachocolata.project.Main$1.run(Main.java:47)
    at org.bukkit.craftbukkit.v1_6_R3.scheduler.CraftTask.run(CraftTask.java:58)
    at org.bukkit.craftbukkit.v1_6_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
    at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:520)
    at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:240)
    at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:483)
    at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:415)
    at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)

My code:

Code:java

package me.mistachocolata.project;
 
import java.util.HashMap;
import java.util.logging.Logger;
 
import net.milkbowl.vault.economy.Economy;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.DisplaySlot;
import org.bukkit.scoreboard.Objective;
import org.bukkit.scoreboard.Score;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
 
public class Main extends JavaPlugin implements Listener {
    public static Main mainPlugin = null;
    public PlayerDataYAML yaml = new PlayerDataYAML();
    public Logger logger;
    public static Economy economy = null;
 
    public static HashMap<String, Scoreboard> playerScoreboards = new HashMap<String, Scoreboard>();
    public static HashMap<String, Score> ratingScore = new HashMap<String, Score>();
 
    public void onEnable() {
        mainPlugin = this;
 
        this.logger = this.getLogger();
        this.logger.info("Plugin has been enabled.");
 
        Bukkit.getPluginManager().registerEvents(this, this);
        Bukkit.getPluginManager().registerEvents(new PlayerDataYAML(), this);
        Bukkit.getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
 
        @Override
        public void run() {
            for (Player player:Bukkit.getOnlinePlayers()) {
                if (!playerScoreboards.containsKey(player.getName())) {
                        update (player);
                        set (player);
                }
            }
        }
        }, 0L, 50L);
    }
 
    public void onDisable() {
        this.logger.info("Plugin has been disabled.");
 
        for (Player p:Bukkit.getOnlinePlayers()) {
            Score scoreRating = (Score) ratingScore.get(p.getName().toLowerCase());
            int intRating = scoreRating.getScore();
            PlayerDataYAML.set(p.getName(), "Data.rating", String.valueOf(intRating));
 
        }
 
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
        String pname = player.getName().toLowerCase();
 
        if (!playerScoreboards.containsKey(pname)) {
            create(player, pname, "ServerName");
            set(player);
        }
    }
 
    @EventHandler
    public static void CreateOnLeave(PlayerQuitEvent ev) {
        Player player = ev.getPlayer();
        Score scoreRating = (Score) ratingScore.get(player.getName().toLowerCase());
        int intRating = scoreRating.getScore();
        PlayerDataYAML.set(player.getName(), "Data.rating", String.valueOf(intRating));
    }
 
    public static void create(Player player, String BoardName, String BoardDisplayName) {
        String pname = player.getName().toLowerCase();
 
        ScoreboardManager manager = Bukkit.getScoreboardManager();
        Scoreboard board = manager.getNewScoreboard();
 
        Objective objective = board.registerNewObjective(BoardName, "dummy");
 
        objective.setDisplaySlot(DisplaySlot.SIDEBAR);
        objective.setDisplayName(BoardDisplayName);
 
        //Score rating = objective.getScore(Bukkit.getOfflinePlayer(mainPlugin.getConfig().getString("name").replaceAll("(&([a-f0-9]))", "\u00A7$2")));
        Score rating = objective.getScore(Bukkit.getOfflinePlayer("Rating:"));
 
        rating.setScore(0);
 
        ratingScore.put(pname, rating);
 
        playerScoreboards.put(pname, board);
    }
 
    public static void update(Player player) {
        String pname = player.getName().toLowerCase();
        player.setScoreboard(playerScoreboards.get(pname));
 
        Score rating = ratingScore.get(pname);
 
        String strRating = (String) PlayerDataYAML.get(pname, "Data.rating");
        int intRating = Integer.valueOf(strRating);
        rating.setScore(intRating);
    }
 
    public static void set(Player player) {
        String pname = player.getName().toLowerCase();
        player.setScoreboard(playerScoreboards.get(pname));
    }
 
    public static void addScore(Player player, String ScoreType, int Score) {
        String pname = player.getName().toLowerCase();
 
        if (ScoreType.equals("rating")) {
            Score rating = ratingScore.get(pname);
            rating.setScore(rating.getScore() + Score);
        }
    }
 
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        if (label.equalsIgnoreCase("rating")) {
            Player player = (Player) sender;
 
            String pname = player.getName().toLowerCase();
            player.setScoreboard(playerScoreboards.get(pname));
            PlayerDataYAML.set(player.getName(), "Data.rating", String.valueOf(Integer.valueOf((String)
            PlayerDataYAML.get(player.getName(), "Data.rating")) + 1));
        }
        else if (label.equalsIgnoreCase("item")) {
            Player player = (Player) sender;
            Economy econ = null;
            RegisteredServiceProvider<Economy> economyProvider = getServer().getServicesManager().getRegistration(net.milkbowl.vault.economy.Economy.class);
 
            if (economyProvider != null) {
                econ = economyProvider.getProvider();
            }
 
            econ.depositPlayer(player.getName(), 5);
            player.getInventory().addItem(Items.leatherHelmetProt2);
        }
        return false;
    }
}
 

 

java.lang.IllegalArgumentException: Scoreboard cannot be null
Scoreboards null.. Did you create it?

 

map.get() returns null if the map doesn't contain that key, so you should check that playerScoreboards.contains(pname) before setting his scoreboard to it.

 

Code:java

 public static void set(Player player) {
if (!playerScoreboards.containsKey(player.getName())) {
String pname = player.getName().toLowerCase();
player.setScoreboard(playerScoreboards.get(pname));
}
}
 
public static void addScore(Player player, String ScoreType, int Score) {
String pname = player.getName().toLowerCase();
 
if (ScoreType.equals("rating")) {
Score rating = ratingScore.get(pname);
rating.setScore(rating.getScore() + Score);
}
}

Didnt make the fix, still the same error.

 

The other way round :0 You want to set his scoreboard if the map does contain his name

 

or get the value and do a null check, which would be more memory efficient.

Code:java

Object o = Map.get("key");
if (o != null) {
    // continue ...
}

Edit: This also helps in future cases with maps as well, because using .containsKey and a null check are two different things. .containsKey will return null if you put a null value into the map, but will still return true for containsKey.

 

1Rogue, How would I use this in my code? I dont quite really understand the Map stuff :s

 

get the value, then check if it is null.

 

1Rogue Which value? I dont understand the null checker at all. :\

 

Code:java

ObjectOfWhatYouAreGetting variableName = mapYouAreUsing.get("value of the key");
if (variableName != null) {
    // do code
} else {
    // the map returned null
}

 

Can anyone help me by fixing my code? I dont understand about the Map stuff at all, I tried alot of different things nothing works... :\

 

this should fix it:

use

Code:java

Scoreboard tempScoreboard = playerScoreboards.get(pname);
if (tempScoreboard != null) {
player.setScoreboard(tempScoreboard);
}
 

instead of

Code:java

player.setScoreboard(playerScoreboards.get(pname));
 

everytimes

 

@5pHiNxX This worked, thanks!