Coloured Message throwing errors?

From what I can see in my Stack traces, trying to send a line of colored text to a player in chat using the ChatColor method throws an error. If somemone could tell me what Im doing wrong, and how to fix it, that would be stellar!
The class throwing the problem and my log is below.

The Class throwing the error:

Code:java

import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.Plugin;
 
import me.crazeddude.bukkit.punisher.MAIN.PunisherLogger;
 
 
import me.crazeddude.bukkit.punisher.MAIN.Punisher;
import me.crazeddude.bukkit.punisher.util.CheckForAction;
import me.crazeddude.bukkit.punisher.util.CheckRules;
import me.crazeddude.bukkit.punisher.util.Config;
import me.crazeddude.bukkit.punisher.util.StrikeChecker;
 
@SuppressWarnings("unused")
public class PunishExecutor2 implements CommandExecutor{
private Punisher plugin;
public PunishExecutor2(Punisher punisher) {
// TODO Auto-generated constructor stub
}
@Override
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
if (cmd.getLabel().equalsIgnoreCase("Punish")){
sender.sendMessage("a");
String hp2 = " (For examples, use /Punish ex)";
if (Config.getConfig().getStringList("Dev-tools.De-Bug_Mode").contains("general")){sender.sendMessage("DEBUG: Got Past Label check.");}
if (sender.hasPermission(cmd.getPermission())|!(sender instanceof Player)){
if (Config.getConfig().getStringList("Dev-tools.De-Bug_Mode").contains("general")){sender.sendMessage("DEBUG: got past initial perm check.");}
if (args.length == 1){
if (Config.getConfig().getStringList("Dev-tools.De-Bug_Mode").contains("general")){sender.sendMessage("DEBUG: Got Past Args check for 1 arg!");}
if (args[0].equalsIgnoreCase("Reload")){
if (Config.getConfig().getStringList("Dev-tools.De-Bug_Mode").contains("general")){sender.sendMessage("DEBUG: got past arg 1 RELOAD check. Now in RELOAD code block.");}
if(sender.hasPermission(cmd.getPermission() + ".reload")){
if (Config.getConfig().getStringList("Dev-tools.De-Bug_Mode").contains("general")){sender.sendMessage("DEBUG: Passed RELOAD Permission check!");}
Config.reloadConfig();
}
// ---------------DONE EX
}else if(args[0].equalsIgnoreCase("ex")){
if (Config.getConfig().getStringList("Dev-tools.De-Bug_Mode").contains("general")){sender.sendMessage("DEBUG: Now In EX Code Block.");}
sender.sendMessage(ChatColor.AQUA + "==============Punisher Examples:==============");
sender.sendMessage(ChatColor.AQUA + "Reasons that require a Player/Number input are listed in" + ChatColor.RED + " Red " + ChatColor.AQUA + "Instead of" + ChatColor.GREEN + " Green" + ChatColor.AQUA + ".");
sender.sendMessage(ChatColor.GOLD + "Possible Reasons/Actions:");
sender.sendMessage(ChatColor.GREEN + "Reload,Ex," + ChatColor.RED + "Lookup,Remove,Add,List,Warn," + CheckRules.listtoString(Config.getConfig().getStringList("Rules.rulelist"), ","));
}
}else if (args.length >= 2){
// sender.sendMessage("DEBUG: Failed check for 1 arg, got past >=2 arg check!");
if (args[0].equalsIgnoreCase("Lookup")){
// sender.sendMessage("DEBUG: Now In Lookup Code Block, bast LOOKUP Arg check.");
if (sender.hasPermission(cmd.getPermission() + ".lookup")){
Player target = Bukkit.getServer().getPlayer(args[1]);
// sender.sendMessage("DEBUG: Past Lookup Perm Check!");
sender.sendMessage(ChatColor.GREEN + "Player " + ChatColor.GOLD + target.getName() + ChatColor.GREEN + " Currently Has " + ChatColor.GOLD + Integer.toString(StrikeChecker.getStrikes(target.getName())) + ChatColor.GREEN + " Strikes.");
plugin.log.info("Player " + sender.getName().toString() + " looked up strikes on player " + target.getName() + ".");
}else{
// sender.sendMessage("DEBUG: FAILED Lookup Perm Check!");
sender.sendMessage(cmd.getPermissionMessage());
}
}else if (args[0].equalsIgnoreCase("Remove")){
// sender.sendMessage("DEBUG: Passed Remove arg check 1");
if (sender.hasPermission(cmd.getPermission() + ".remove")){
// sender.sendMessage("DEBUG:pASSED remove Permission Check");
}else{
sender.sendMessage(cmd.getPermissionMessage());
}
// ADD - DONE.
}else if (args[0].equalsIgnoreCase("add")){
// sender.sendMessage("DEBUG: In Add Block");
if (sender.hasPermission(cmd.getPermission() + ".add")){
// sender.sendMessage("DEBUG:passed Add Perm Check");
int a = StrikeChecker.getStrikes(args[0].toString());
int max = Config.getConfig().getInt("Actions.maxPoints");
int b = 0;
try {
b = Integer.parseInt(args[1].toString());
} catch (NumberFormatException e) {
sender.sendMessage(ChatColor.RED + "Please Use a Positive Whole number" );
}
if (b >= max) {
sender.sendMessage(ChatColor.RED + "Number MUST be a Whole, Positive Number.");
}else if (b < 1) {
sender.sendMessage("Value Must be above 0.");
}else{
int c = a + b;
String d = CheckForAction.checkForActs(c);
if (c >= max){
Player target = Bukkit.getServer().getPlayer(args[0].toString());
if (!(target.isBanned())) {
try{
target.kickPlayer(ChatColor.AQUA + "You have Been Banned For Breaching the Server's Rules." + "\n" + ChatColor.RED + "Rules Breached: (FUNCTION STILL IN DEVELOPMENT.)");
target.setBanned(true);
sender.sendMessage(ChatColor.GREEN + "Player " + ChatColor.GOLD + target.getName().toString() + ChatColor.GREEN + " Has Been Kicked. (I forgot the function to ban.)");
}catch (Exception e){
e.printStackTrace();
}
}
else if (target.isBanned()){
sender.sendMessage(ChatColor.RED + "Player " + ChatColor.GOLD + target.getName().toString() + ChatColor.RED + "Is Already Banned.");
}
}
}
}else{
sender.sendMessage(cmd.getPermissionMessage() + hp2);
}
}else if (args[0].equalsIgnoreCase("List")){
// sender.sendMessage("DEBUG: In List Block");
if (sender.hasPermission(cmd.getPermission() + ".list")){
// sender.sendMessage("DEBUG: Passed List Perm Check");
sender.sendMessage(ChatColor.AQUA + "The List Feature is not yet implemented.");
}
 
}else if (args[0].equalsIgnoreCase("warn")){
// sender.sendMessage("DEBUG: In Warn Block");
sender.sendMessage(ChatColor.AQUA + "The Warn Feature is not yet implemented.");
}else{
sender.sendMessage(ChatColor.RED + "Invalid Action.");
}
}else{
// sender.sendMessage("DEBUG: Failed Arg Length Check.");
sender.sendMessage(ChatColor.DARK_RED + "It's Done Like This:");
sender.sendMessage(ChatColor.RED + cmd.getUsage() + hp2);
}
}else{
sender.sendMessage(ChatColor.RED + "Permission " + cmd.getPermission() + " Missing");
}
}
return false;
}
}
 

the Log:

2013-10-14 11:26:26 [INFO] Starting minecraft server version 1.6.2
2013-10-14 11:26:26 [INFO] Loading properties
2013-10-14 11:26:26 [INFO] Default game type: SURVIVAL
2013-10-14 11:26:26 [INFO] Generating keypair
2013-10-14 11:26:27 [INFO] Starting Minecraft server on *:25565
2013-10-14 11:26:27 [INFO] This server is running CraftBukkit version git-Bukkit-1.6.2-R1.0-b2879jnks (MC: 1.6.2) (Implementing API version 1.6.2-R1.0)
2013-10-14 11:26:27 [INFO] [Punisher] Loading Punisher v0.0.0.1.00
2013-10-14 11:26:27 [INFO] [Punisher] Enabling Punisher v0.0.0.1.00
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b=============================================================================================
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b=================================Punisher LOAD START=========================================
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b=============================================================================================
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b=================================LOADING COMMANDS============================================
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �bLoading The Punish Command...
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �bLoading The Howclose Command...
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �bCommands Loaded Successfully!
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b=============================================================================================
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �b======================================LOADING DATA===========================================
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �bVerifying Config...
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �bConfig Verified!
2013-10-14 11:26:27 [INFO] �a[�6Punisher�a]�f: �bConfig.yml Found!
2013-10-14 11:26:27 [INFO] Preparing level "world"
2013-10-14 11:26:27 [INFO] Preparing start region for level 0 (Seed: 8575415723044091288)
2013-10-14 11:26:28 [INFO] Preparing start region for level 1 (Seed: -4956242592001794844)
2013-10-14 11:26:28 [INFO] Preparing start region for level 2 (Seed: -4956242592001794844)
2013-10-14 11:26:28 [INFO] Server permissions file permissions.yml is empty, ignoring it
2013-10-14 11:26:28 [INFO] Done (1.368s)! For help, type "help" or "?"
2013-10-14 11:26:37 [INFO] You Must be a Player to use this command.
2013-10-14 11:26:37 [INFO] /Howclose
2013-10-14 11:26:41 [WARNING] Unexpected exception while parsing console command "punish"
org.bukkit.command.CommandException: Unhandled exception executing command 'punish' in plugin Punisher v0.0.0.1.00
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
at org.bukkit.craftbukkit.v1_6_R2.CraftServer.dispatchCommand(CraftServer.java:523)
at org.bukkit.craftbukkit.v1_6_R2.CraftServer.dispatchServerCommand(CraftServer.java:512)
at net.minecraft.server.v1_6_R2.DedicatedServer.ar(DedicatedServer.java:262)
at net.minecraft.server.v1_6_R2.DedicatedServer.t(DedicatedServer.java:227)
at net.minecraft.server.v1_6_R2.MinecraftServer.s(MinecraftServer.java:486)
at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java:419)
at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:582)
Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_6_R2.command.ColouredConsoleSender cannot be cast to org.bukkit.entity.Player
at me.crazeddude.bukkit.punishSystem.commands.PunishExecutor3.onCommand(PunishExecutor3.java:30)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
... 8 more
2013-10-14 11:26:47 [INFO] CONSOLE: Stopping the server..
2013-10-14 11:26:47 [INFO] Stopping server
2013-10-14 11:26:47 [INFO] [Punisher] Disabling Punisher v0.0.0.1.00
2013-10-14 11:26:47 [INFO] �a[�6Punisher�a]�f: �bSaving Config...
2013-10-14 11:26:47 [INFO] Saving players
2013-10-14 11:26:47 [WARNING] DSCT: Socket closed
2013-10-14 11:26:47 [INFO] Saving worlds
2013-10-14 11:26:47 [INFO] Saving chunks for level 'world'/Overworld
2013-10-14 11:26:47 [INFO] Closing listening thread
2013-10-14 11:26:47 [INFO] Saving chunks for level 'world_nether'/Nether
2013-10-14 11:26:47 [INFO] Saving chunks for level 'world_the_end'/The End
2013-10-14 11:26:47 [INFO] Stopping server

 

You're casting the ColoredConsoleSender to a Player in the class PunishExecutor3 line 30.

 

Somewhere, not sure where yet, you're trying to cast sender to a player without making sure it's first a player. I can see you have some "instanceOf Player" statements in there, but somewhere you're missing one. The error shows line 30, but since you have comments and it's a runtime error that line won't be exact. Look around line 30.


I would also like to point out this line this is somethi:

Code:

 if (sender.hasPermission(cmd.getPermission())|!(sender instanceof Player)){

Remember, a single | is a bit-wise operator, you need to use ||.

 

Line 30 of PunishExecutor3 class.

EDIT: Ninja'd by TeeePeee

It's not looking for an instanceof. In his code he's casting ((ColoredConsoleSender) player).

He provided the wrong class file, that's why you're confused and not finding anything on line 30.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Ah, true, very true. Dangers of using Eclipse auto complete. He's also using a bit-wise inclusive or on line 31.

 

It doesn't matter, he provided the wrong class. So looking at the class he gave, and trying to decipher a stack trace which states it's in a different class, is not going to work very well.

 

^ This

 

That class is never called in runtime though...

 

Maybe it's a ghost? But still. You should fix it.

 

Thanks for your help!! however, to help solve this issue, I would like to mention that PunishExecutor3 is never called in runtime...

 

As I said

 

would it help to delete PunishExecutor3? it serves no purpose in runtime, as its a fragment of buggy code I completely re-wrote.

 

From your log, it appears that you type /Howclose from your console, which I'm assuming is meant to return how close a player is from being banned. You must not perform a check before you run that command, because you are trying to cast the console to a player ((Player)sender) when it's not applicable. Humor me and add an if statement before you cast stating if(sender instanceof Player) and see if that fixes it.

 

CD3
Yeah sure, delete it. But if there's something in that class you need, I'd suggest putting it in a notepad file or something, maybe pastebin or pastie?

If you delete it and you get errors in your code, then somewhere in your valid code, it was calling that class. Which is what I assume is happening.

 

k, doing that now.

 

I can't edit my posts so I'm forced to repost (silly bukkit forums). If you're not using PunishExecutor3 but haven't remove its instantiation in your main plugin class (getCommand("howclose").setExecutor(new PunishExecutor3())) it will still be listening for commands and react accordingly...

 

the Howclose command is a seprate command, and works.
this command is /punish, and it the Executor class is set to the class I gave.

 

Ah silly me, misread the server log for the command name :3.

Regardless, punish is being called in PunishExecutor3 and it's not checking if the sender is a player before casting. The computer only does exactly what you tell it to

 

ok WTH is going on...

I ran it with the changes, and this happened on Enable:

Code:

12:10:43 [INFO] ?a[?6Punisher?a]?f: ?bLoading The Punish Command...
12:10:43 [SEVERE] Error occurred while enabling Punisher v0.0.0.1.00 (Is it up to date?)
java.lang.NoClassDefFoundError: me/crazeddude/bukkit/punishSystem/commands/PunishExecutor3
    at me.crazeddude.bukkit.punisher.MAIN.Punisher.onEnable(Punisher.java:54)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:457)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:381)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.loadPlugin(CraftServer.java:282)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.enablePlugins(CraftServer.java:264)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.<init>(CraftServer.java:218)
    at net.minecraft.server.v1_6_R2.PlayerList.<init>(PlayerList.java:56)
    at net.minecraft.server.v1_6_R2.DedicatedPlayerList.<init>(SourceFile:11)
    at net.minecraft.server.v1_6_R2.DedicatedServer.init(DedicatedServer.java:106)
    at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java:391)
    at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:582)
Caused by: java.lang.ClassNotFoundException: me.crazeddude.bukkit.punishSystem.commands.PunishExecutor3
    at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
    at org.bukkit.plugin.java.PluginClassLoader.findClass0(PluginClassLoader.java:80)
    at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:53)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
    ... 12 more

when the line eclipse said this :

Code:java

this.getCommand("Punish").setExecutor(new me.crazeddude.bukkit.punishSystem.commands.PunishExecutor2(this));

thats true

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Line 54 of your onEnable();

I'm guessing that's the line Eclipse highlighted?

 

The ClassLoader sometimes gets confused when you reload after updating the plugin jar.

Just try stopping and restarting the server.

 

yes, it is.

But if it was getting confused, it should happen consistently, should it?

making a github repository for this.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Consistently if you reload after making changes to the plugin jar in a class that's being used. For example, if you were to run a scheduled task, update the runnable and export the jar, your console would throw an error every time that class executed.

 

TeeePeee
Always remember to quote/reply or tag a player when replying.

CD3
Well, I've never really experienced any plugins doing that, but it is possible. Try again? If it happens consistently then there's probably another problem hanging around.

 

ok... The weird part is I cant see Colored console sender in any of the classes.

 

CD3
Well it said it was in the PunishExecutor3 class... but you said you deleted it right?

Are you still getting the same stacktraceeven after shutting the server down and starting it again?

 

yes, I am. Maybe renameing 2 to 3 will work?

 

CD3
That might just make more problems than it solves... Link to the gitHub repo?

 

yes.

Github is up

https://github.com/EpicraftMC/punisher

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

CD3
Line 49 of your onEnable() method calls the PunishExecutor3 class.