Checking if the item in hand is a specific potion

The title says it all

e.g. I want to find out if the player is holding a 'Water' potion

 

So Like mundane potion, Awkward potion, thick potion?

 

YAH!

Wait, would this do it?

Code:java

Potion wBottle = new Potion(PotionType.WATER);
                if(p.getItemInHand().equals(wBottle))

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Not sure water wuld but mundane and thick should work like that

 

Hmm... Eclipse hasn't complained so hopefully it will work!

 

If it works, say so.

Might Help people down the road =)

 

did you figure it out?
also, i don't only want to check the potion, but also set the item in hand to be a certain potion.

 

Yes, see the code in the post above!

 

but how would i set that item to his hand?

 

player.getInventory().setItemInHand(args)

 

don't work. can't set an potion to be an item. error:
The method setiteminhand(itemstack) in the type playerinventory is not applicable for the arguments(potion)
needs to be an itemstack.

 

setiteminhand(potion.toItemStack(0))

 

Ah, nice, thanks!

 

I tried to combine the checking if a player has a potion in their inventory with the making the potion something different when they left click:

Code:

public class potionswitcher implements Listener{
    @EventHandler
 
    public void potionchange(PlayerInteractEvent event){
        Player player = event.getPlayer();
        Action action = event.getAction();
        if (player.getItemInHand().getTypeId()==Material.POTION.getId()){
         
     
        if (action == Action.LEFT_CLICK_AIR){
            Potion poison = new Potion(PotionType.POISON,1);
            Potion harm = new Potion(PotionType.INSTANT_DAMAGE,2);
            Potion weakness = new Potion(PotionType.WEAKNESS,2);
            Potion regen = new Potion(PotionType.REGEN,1);
         
         
            if(player.getItemInHand().equals(poison)){
                player.setItemInHand(harm.toItemStack(1));
            }
         
            if(player.getItemInHand().equals(harm)){
                player.setItemInHand(weakness.toItemStack(1));
            }
         
            if(player.getItemInHand().equals(weakness)){
                player.setItemInHand(regen.toItemStack(1));
            }
 
Ect...

i was hoping this code would change the item in their hand to a different potion depending on which was in their hand. Eclipse gives me no errors, but when I try and run this in the game while say holding a non-splash, poison 1, potion, rather than changing it to a harm potion, it just stays there when i left click... see where i went wrong?

 

you need to make the 3 "if" statements to "else if" because other wise this happens:

bob has poison, left clicks, now bob has harm, then weakness then regen. All because the next if statements are fulfilled if the item in hand is changed then checked again. Another fix would be to replace all the player.getItemInHand() parts with a variable you create at the beggining, pHand = player.getItemInHand,
if(pHand.equals(something)){



something}.

 

Grave digger...

 

What do you mean by Grave Digger?

 

xa112

I think he means you dug up a thread that had been buried in the forums for 5 months untouched (metaphorically)