Solved Searching for nearby blocks?

I'm trying to search and see if there is a water or lava block within 20 blocks of the senders location If so, don't let them use the command. I have everything set up, just don't know how to search and see if there's a water or lava block nearby.

My code:

Code:java

package me.PimpDuck.AntiGlitch;
 
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
 
import org.bukkit.*;
import org.bukkit.block.Block;
import org.bukkit.command.*;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
 
public class AGCommands implements CommandExecutor, Listener{
Player player;
 
private List<Material> liquid = Arrays.asList(new Material[] {
Material.WATER,
Material.STATIONARY_WATER,
Material.LAVA,
Material.STATIONARY_LAVA
});
 
private List<String> block = Arrays.asList(new String[] {
"tpa",
"etpa",
"back",
"eback",
"tpahere",
"etpahere",
"tpyes",
"etpyes",
"sethome",
"esethome",
"tpaccept",
"etpaccept",
});
 
@EventHandler(priority = EventPriority.LOW)
public void blockCommand(PlayerCommandPreprocessEvent evt) {
Player player = evt.getPlayer();
Material material = player.getPlayer().getLocation().getBlock().getType();
String command = evt.getMessage();
command = command.split(" ")[0];
command = command.replace("/", "");
if(liquid.contains(material) && block.contains(command)){
evt.setCancelled(true);
player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
}
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String command, String[] args)
{
Player player = (Player) sender;
if(sender instanceof Player){
 
}else{
player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "Only in game players can use these commands!");
}
return false;
}
 
}
 

Anyone? :I

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

a 23 minute bump? have some patience.

There's nothing difficult about this, you have 3 axes, loop through all the blocks in the area until you find water or lava, its just 3 nested for loops:

Code:java

 
// let X, Y, Z be player postion and r be radius
for (int x = X-r; x < X+r; x++) {
    for (int z = Z-r; z < Z+r; z++) {
        for (int y = Y-r; y < Y+r;y++) {
            //if block at x,y,z is water or lava, break;
        }
    }
}
 

 

Sorry :I and okay, I'll try this.

metalhedd So would it look like this? Sorry, I'm very bad at for loops :/

Code:java

        @EventHandler(priority = EventPriority.LOW)
        public void blockCommand(PlayerCommandPreprocessEvent evt) {
            Player player = evt.getPlayer();
            Material material = player.getPlayer().getLocation().getBlock().getType();
            String command = evt.getMessage();
            command = command.split(" ")[0];
            command = command.replace("/", "");
        // let X, Y, Z be player postion and r be radius
            for (int x = X-r; x < X+r; x++) {
                for (int z = Z-r; z < Z+r; z++) {
                    for (int y = Y-r; y < Y+r;y++) {
            if(liquid.contains(material) && block.contains(command)){
                evt.setCancelled(true);
                player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
            }
        }
      }
    }
  }    

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You never defined liquid or block, so I don't know if your check will work. and you never defined, or initialized X, Y or Z to the players current coordinates, so the code won't even compile. but if you fix those 2 issues it should work.

 

metalhedd I did? I didn't show my whole code, sorry.

Code:java

public class AGCommands implements CommandExecutor, Listener{
    Player player;
 
 
    private List<Material> liquid = Arrays.asList(new Material[] {
            Material.WATER,
            Material.STATIONARY_WATER,
            Material.LAVA,
            Material.STATIONARY_LAVA
            });
 
        private List<String> blockCommands = Arrays.asList(new String[] {
            "tpa",
            "etpa",
            "back",
            "eback",
            "tpahere",
            "etpahere",
            "tpyes",
            "etpyes",
            "sethome",
            "esethome",
            "tpaccept",
            "etpaccept",
            });
 
        @EventHandler(priority = EventPriority.LOW)
        public void blockCommand(PlayerCommandPreprocessEvent evt) {
            Location loc = player.getLocation();
            Player player = evt.getPlayer();
            Material material = player.getPlayer().getLocation().getBlock().getType();
            String command = evt.getMessage();
            command = command.split(" ")[0];
            command = command.replace("/", "");
        // let X, Y, Z be player postion and r be radius
            for (int x = X-r; x < X+r; x++) {
                for (int z = Z-r; z < Z+r; z++) {
                    for (int y = Y-r; y < Y+r;y++) {
            if(liquid.contains(material) && blockCommands.contains(command)){
                evt.setCancelled(true);
                player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
            }
        }
      }
    }
  }
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String command, String[] args)
    {
        Player player = (Player) sender;
        if(sender instanceof Player){
 
        }else{
            player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "Only in game players can use these commands!");
        }
        return false;
    }
 
}
 

 

Ok, that shows 'liquid', but the rest of the variables are still undefined. (X, Y and Z)

 

How would I do that? replace X with loc.getX() ?

metalhedd ^

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

yes. and you'll have to replace r with an actual value too.

 

So r would be the distance? metalhedd

 

yep

 

I have a feeling I'm doing this wrong. Should one of these be the block, metalhedd ?

Code:java

          for (int x = (int) (loc.getX()-20); x < loc.getX()+20; x++) {
                for (int z = (int) (loc.getZ()-20); z < loc.getZ()+20; z++) {
                    for (int y = (int) (loc.getY()-20); y < loc.getY()+20;y++) {

 

That looks fine to me... Your 2nd paste doesn't even have a variable called 'block' you renamed it to 'blockCommands' when you repasted the full code.

 

PimpDuck

Another method that may work is getting the player's location, adding values to it and getting the block at the exact coords.

Code:

Location playerloc = player.getWorld().getLocation();
 
// X, Y, Z 
Location radius = playerloc.add(0.00D, 0.00D, 0.00D);

But it will only work for the exact radius.

 

metalhedd Well, I thought that might be confusing. Because I changed it to "blockCommand" because that's the commands I want to block. I didn't mean that as the material block.

 

Ok, then, no, the block itself shouldn't be anywhere in those lines, what you have there is a loop of every x,y,z coordinate in a 20 block radius of the player. inside the loop, you just need to check if the block at that location matches your criteria.

 

metalhedd How would I do that?

metalhedd

Code:

if(liquid.contains(material) && blockCommands.contains(command)){
                evt.setCancelled(true);
                player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
            }

this checks if the player is in the water or lava trying the command.

EdenCampo The other way I was trying seems to not be working. How would I set this way up?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

PimpDuck I've handed you every piece of code you need to solve the problem, and I even walked you through putting it together. At some point you need to do something yourself. You've got 99% of the way there, now if you trace your code you'll see that the 'material' you're checking never changes because you only ever assign it a value once, before the loop starts. you need to set it each time though the loop, to the value of the material at x,y,z.

don't switch tactics now, EdenCampo's method will get you nowhere useful, read your code carefully, and try inserting some logging statements to see what's going on.

 

PimpDuck

Code:java

    int radius = 0;
 
    Location playerloc = player.getWorld().getLocation();
 
    while(radius < 300(for example))
    {
        Location radius = playerloc.add(radiusD, 0.00D, radiusD);
 
        Block block = Bukkit.getServer().getWorld(player.getWorld()).getBlockAt(playerloc);
 
        if(block.getType() == MATERIAL.WATER || block.getType() == MATERIAL.LAVA)
        {
            // do stuff?
        }
 
        radius++;
    }

 

Using this

Code:java

 
        @EventHandler(priority = EventPriority.LOW)
        public void blockCommand(PlayerCommandPreprocessEvent evt) {
            Location loc = player.getLocation();
            Player player = evt.getPlayer();
            Material material = player.getPlayer().getLocation().getBlock().getType();
            String command = evt.getMessage();
            command = command.split(" ")[0];
            command = command.replace("/", "");
        // let X, Y, Z be player postion and r be radius
            for (int x = (int) (loc.getX()-20); x < loc.getX()+20; x++) {
                for (int z = (int) (loc.getZ()-20); z < loc.getZ()+20; z++) {
                    for (int y = (int) (loc.getY()-20); y < loc.getY()+20;y++) {
            if(liquid.contains(material) && blockCommands.contains(command)){
                evt.setCancelled(true);
                player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
            }
        }
      }
    }
  }

doesn't seem to even do anything when they're in the water or out?

 

because you didn't listen to what I said:

#1) You need to set the 'material' variable INSIDE The loop. TO the material at location x,y,z
#2) add some debug logging so that you can provide more useful feedback than "Doesn't work". you could tell us exactly which line it gets to and where it fails to do what you expect, if you just add a couple of logger entries.

 

metalhedd Inside the loop like this?

Code:java

 @EventHandler(priority = EventPriority.LOW)
public void blockCommand(PlayerCommandPreprocessEvent evt) {
Location loc = player.getLocation();
Player player = evt.getPlayer();
String command = evt.getMessage();
command = command.split(" ")[0];
command = command.replace("/", "");
// let X, Y, Z be player postion and r be radius
for (int x = (int) (loc.getX()-20); x < loc.getX()+20; x++) {
for (int z = (int) (loc.getZ()-20); z < loc.getZ()+20; z++) {
for (int y = (int) (loc.getY()-20); y < loc.getY()+20;y++) {
Material material = player.getPlayer().getLocation().getBlock().getType();
if(liquid.contains(material) && blockCommands.contains(command)){
evt.setCancelled(true);
player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
}
}
}
}
}

 

No, you ignored the 2nd half of that point. you need to set 'material' TO the material at location x,y,z. you're setting it to the material at the players current location and checking that same material 8000 times.

 

metalhedd I'm not good with for loops at all >< I've been reading this over and over again for 10 mins... So do I like replace x,y, and z with material.lava or idk :/

 

Code:java

 
@EventHandler(priority = EventPriority.LOW)
public void blockCommand(PlayerCommandPreprocessEvent evt) {
    Location loc = player.getLocation();
    Player player = evt.getPlayer();
    String command = evt.getMessage();
    World world = loc.getWorld();
    command = command.split(" ")[0];
    command = command.replace("/", "");
    // let X, Y, Z be player postion and r be radius
    for (int x = (int) (loc.getX()-20); x < loc.getX()+20; x++) {
        for (int z = (int) (loc.getZ()-20); z < loc.getZ()+20; z++) {
            for (int y = (int) (loc.getY()-20); y < loc.getY()+20;y++) {
               Material material = world.getBlockAt(x,y,z).getType();
               if(liquid.contains(material) && blockCommands.contains(command)){
                   evt.setCancelled(true);
                   player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
               }
            }
        }
     }
}
 

 

metalhedd Ohhhh! Now I see what you mean xD I would have never understood that without seeing it though. Okay, that's done. I get a NPE on Location loc = player.getLocation();
? My error: http://pastebin.com/Sjp4NSye
My whole class:

Code:java

package me.PimpDuck.AntiGlitch;
 
import java.util.Arrays;
import java.util.List;
 
 
 
import org.bukkit.*;
import org.bukkit.command.*;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
 
public class AGCommands implements CommandExecutor, Listener{
    Player player;
 
    private List<Material> liquid = Arrays.asList(new Material[] {
            Material.WATER,
            Material.STATIONARY_WATER,
            Material.LAVA,
            Material.STATIONARY_LAVA
            });
 
        private List<String> blockCommands = Arrays.asList(new String[] {
            "tpa",
            "etpa",
            "back",
            "eback",
            "tpahere",
            "etpahere",
            "tpyes",
            "etpyes",
            "sethome",
            "esethome",
            "tpaccept",
            "etpaccept",
            });
 
        @EventHandler(priority = EventPriority.LOW)
        public void blockCommand(PlayerCommandPreprocessEvent evt) {
            Location loc = player.getLocation();
            Player player = evt.getPlayer();
            String command = evt.getMessage();
            World world = loc.getWorld();
            command = command.split(" ")[0];
            command = command.replace("/", "");
            // let X, Y, Z be player postion and r be radius
            for (int x = (int) (loc.getX()-20); x < loc.getX()+20; x++) {
                for (int z = (int) (loc.getZ()-20); z < loc.getZ()+20; z++) {
                    for (int y = (int) (loc.getY()-20); y < loc.getY()+20;y++) {
                      Material material = world.getBlockAt(x,y,z).getType();
                      if(liquid.contains(material) && blockCommands.contains(command)){
                          evt.setCancelled(true);
                          player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
                      }
                    }
                }
            }
        }
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String command, String[] args)
    {
        Player player = (Player) sender;
        if(sender instanceof Player){
 
        }else{
            player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "Only in game players can use these commands!");
        }
        return false;
    }
 
}
 

I understand how to read it and everything, I just don't know what I'm doing wrong to get this error.

 

the 'player' variable is null when you're assigning loc. switch the order of those 2 lines.

 

metalhedd Okay, it works. Is there a reason it's spamming me with the message? http://puu.sh/4sUJ6.png

 

you need to add a 'break' or 'return' statement inside the loop just after you cancel the event.

 

metalhedd I added it here, but it still does the same thing?

Code:java

          for (int x = (int) (loc.getX()-20); x < loc.getX()+20; x++) {
                for (int z = (int) (loc.getZ()-20); z < loc.getZ()+20; z++) {
                    for (int y = (int) (loc.getY()-20); y < loc.getY()+20;y++) {
                      Material material = world.getBlockAt(x,y,z).getType();
                      if(liquid.contains(material) && blockedCommands.contains(command)){
                          evt.setCancelled(true);
                          player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
                          break;
                      }
                    }
                }

Btw, when I try to return false it says I have to change from void to boolean?

 

use return instead of break. you don't need to return false. just return