Solved Not letting players use commands in water or lava

Hello, I need some help.

I coded a plugin to not let players use certain commands in lava or water or lava but it's doing that, but doing it in water and lava but also on land? any help.
What it's doing on land and water and lava. I want it on water and lava, but not land: http://puu.sh/4sh7h.png
My code:

Code:java

package me.PimpDuck.ACCommandDisable;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    Logger log = Logger.getLogger("Minecraft");
 
    @Override
    public void onEnable(){
        log.info("[ACCommandDisable] has been enabled!");
    }
 
    @Override
    public void onDisable(){
        log.info("[ACCommandDisable] has been disabled!");
    }
 
    @Override
      public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
      {
          Player player = (Player) sender;
          if(sender instanceof Player){
              Material m = player.getPlayer().getLocation().getBlock().getType();
              if(cmd.getName().equalsIgnoreCase("tpahere") || cmd.getName().equalsIgnoreCase("etpahere") || cmd.getName().equalsIgnoreCase("back") || cmd.getName().equalsIgnoreCase("eback") || cmd.getName().equalsIgnoreCase("tpa") || cmd.getName().equalsIgnoreCase("etpa") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
                  player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
                  return false;
              }
          }
        return false;
      }
}
 

UPDATE: The only command it seems to be blocking only in water is etpa. But when it blocks it in the water and they do it on land, nothing happens.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You need to learn how operators work.
try this.

Code:java

 
if((cmd.getName().equalsIgnoreCase("tpahere") || cmd.getName().equalsIgnoreCase("etpahere") || cmd.getName().equalsIgnoreCase("back") || cmd.getName().equalsIgnoreCase("eback") || cmd.getName().equalsIgnoreCase("tpa") || cmd.getName().equalsIgnoreCase("etpa")) && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
 

 

If I'm correct you have it where if your in lava or water "You can't use this command here!"
Correct me if im wrong .-.

 

Code:

if(cmd.getName().equalsIgnoreCase("tpahere") || cmd.getName().equalsIgnoreCase("etpahere") || cmd.getName().equalsIgnoreCase("back") || cmd.getName().equalsIgnoreCase("eback") || cmd.getName().equalsIgnoreCase("tpa") || cmd.getName().equalsIgnoreCase("etpa") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){

I believe the && operator has a higher precedence than ||, which means the material is only being taken into account when the command name is etpa. To fix this, you should put a single pair of brackets around all the commands in this statement, so that they will all be considered as one thing to the left of the &&, if you see what I mean. (what tommycake50 said)

Code:

if((cmd.getName().equalsIgnoreCase("tpahere") || cmd.getName().equalsIgnoreCase("etpahere") || cmd.getName().equalsIgnoreCase("back") || cmd.getName().equalsIgnoreCase("eback") || cmd.getName().equalsIgnoreCase("tpa") || cmd.getName().equalsIgnoreCase("etpa")) && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){

On a sidenote, it seems like you're trying to block commands from other plugins from working here? This probably won't work. Your onCommand method will only get called if the command is registered in your plugin.yml, and even if you do that it will still be sent to all plugins with it registered, and you can't stop those from handling it.

 

tommycake50 adam753 doubleboss00
I have changed my code to:

Code:java

package me.PimpDuck.ACCommandDisable;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
Logger log = Logger.getLogger("Minecraft");
 
@Override
public void onEnable(){
log.info("[ACCommandDisable] has been enabled!");
}
 
@Override
public void onDisable(){
log.info("[ACCommandDisable] has been disabled!");
}
 
public void commandBlock(Player player){
player.sendMessage(ChatColor.DARK_RED + "Error: " + ChatColor.RED + "You can't use this command here!");
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
{
Player player = (Player) sender;
if(sender instanceof Player){
Material m = player.getPlayer().getLocation().getBlock().getType();
if(cmd.getName().equalsIgnoreCase("tpahere") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
commandBlock(player);
}
if(cmd.getName().equalsIgnoreCase("etpahere") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
commandBlock(player);
}
if(cmd.getName().equalsIgnoreCase("tpa") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
commandBlock(player);
}
if(cmd.getName().equalsIgnoreCase("etpa") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
commandBlock(player);
}
if(cmd.getName().equalsIgnoreCase("back") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
commandBlock(player);
}
if(cmd.getName().equalsIgnoreCase("eback") && (m == Material.STATIONARY_WATER || m == Material.WATER || m == Material.STATIONARY_LAVA || m == Material.LAVA)){
commandBlock(player);
}
}
return false;
}
}
 

and this seems to be fixing my problem but still, when I'm outside of the water or lava it still doesn't do anything?

 

PimpDuck As I said above, the commands you're trying to stop the player from using all belong to other plugins, and you can't just intercept them and stop them from working (especially not by sending the player a message, which is all you're doing here.) The command will still be sent to the other plugin, and it will still handle it the same way.

 

What is your plugin doing anyway it seems to me that its doing nothing

 

adam753 So, is this impossible???

 

That probably lies in the commandBlock method, Can we see it?

 

tommycake50 That's all my code right there???

 

Oh im an idiot xD.
Does it work to actually block the command?

 

tommycake50 Yes it blocks the command in lava and water now. But when I'm on land it does absolutely nothing? Is it because of what that one guy said about how these commands are apart of another plugin?

 

It's possible, Can we see your plugin.yml?

 

Okay. and my plugin.yml:

Code:

name: ACCommandDisable
main: me.PimpDuck.ACCommandDisable.Main
version: 1.0
commands:
  tpahere:
  etpahere:
  back:
  eback:
  tpa:
  etpa:

tommycake50 ^

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yeah ok so use a nested if.
pseudo

Code:

if(command = "command"){
    if(dissallowedmaterials.contains(material)){
        return false;
    }else{
        getServer().getPluginManager().getPlugin("plugin").onCommand(sender, command, label, args)
    }
}

 

tommycake50 So mine would look like

Code:java

    @Override
      public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
      {
          Player player = (Player) sender;
          if(sender instanceof Player){
              Material m = player.getPlayer().getLocation().getBlock().getType();
              if(command = "command"){
                    if(dissallowedmaterials.contains(material)){
                        return false;
                    }else{
                        getServer().getPluginManager().getPlugin("essentials").onCommand(sender, command, label, args)
                    }
                }
          }
        return false;
      }
}
 

I seem to be getting alot of errors? http://puu.sh/4skj2.png

I have a feeling I'm doing this TERRIBLY wrong. Lol

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

your plugin will NOT block any command ... your "onCommand" section will only become active if a player executes a command that belongs to your plugin ... due to "tp" "tpa"and so on belong to other plugins, it will not trigger your section untill you'll list all of them in your plugin.yml ... even if you would, you just send the player a message "Error: You can't use this command here!"
but this message will not prevent the sever from executing this command ... It will display your message and run the command anyway ...

the only way to block the commands of other plugins is a "PlayerCommandPreprocessEvent"

here is a quick example :

Code:java

 
    //list of all liquids
    private List<Material> liquid = Arrays.asList(new Material[] {
        Material.WATER,
        Material.STATIONARY_WATER,
        Material.LAVA,
        Material.STATIONARY_LAVA
        });
 
    //list of all commands to block
    private List<String> block = Arrays.asList(new String[] {
        "tp",
        "tpa",
        "tphere",
        "tpahere",
        });
 
    // the block event itself
    @EventHandler(priority = EventPriority.LOW)
    public void blockCommand(PlayerCommandPreprocessEvent evt) {
        Player player = evt.getPlayer();
        Material material = player.getPlayer().getLocation().getBlock().getType();
        String command = evt.getMessage();
        command = command.split(" ")[0];
        command = command.replace("/", "");
 
        if(liquid.contains(material) && block.contains(command)){
            evt.setCancelled(true);
            player.sendMessage("Can't do this here!");
        }

 

InflamedSebi Okay, so here's what I got. What would go in the commandSender ?

Code:java

package me.PimpDuck.ACCommandDisable;
 
import java.util.Arrays;
import java.util.List;
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    Logger log = Logger.getLogger("Minecraft");
 
    @Override
    public void onEnable(){
        log.info("[ACCommandDisable] has been enabled!");
    }
 
    @Override
    public void onDisable(){
        log.info("[ACCommandDisable] has been disabled!");
    }
 
      //list of all liquids
    private List<Material> liquid = Arrays.asList(new Material[] {
        Material.WATER,
        Material.STATIONARY_WATER,
        Material.LAVA,
        Material.STATIONARY_LAVA
        });
 
    //list of all commands to block
    private List<String> block = Arrays.asList(new String[] {
        "tp",
        "tpa",
        "tphere",
        "tpahere",
        });
 
    // the block event itself
    @EventHandler(priority = EventPriority.LOW)
    public void blockCommand(PlayerCommandPreprocessEvent evt) {
        Player player = evt.getPlayer();
        Material material = player.getPlayer().getLocation().getBlock().getType();
        String command = evt.getMessage();
        command = command.split(" ")[0];
        command = command.replace("/", "");
    }
 
    @Override
      public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
      {
          Player player = (Player) sender;
          if(sender instanceof Player){
              // what would I put here ?
          }
        return false;
      }
}
 

 

You dont need the whole

Code:java

 @Override
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
{
Player player = (Player) sender;
if(sender instanceof Player){
// what would I put here ?
}
return false;
}

stuff ...

You can use a listener ...
the will hook up into the server and become active every time something special happens ... in your case, every time a player executes a command.

there are a few steps to do, before you can use Listener ...
first you have to enable/register them in the server
than implement them correctly ...

some examples can be found here

btw you did not copy my whole code ... there are missing 3 lines the code box has a scrollbar
and this was an example ... this might throw errors under some special circumstances ...but it should work if u implement it correctly ...

just make sure u know how to use listener/the event API

 

InflamedSebi Ohh okay. I'm not sure how to do this but okay ._.

 

just read the bukkit wiki about events ... this is pretty simple and powerfull! ... its worth every minute u spent to it ... btw i commented my code:

Code:java

    //create a list of all liquid materials, so u can access the list instead of checking every single material
    private List<Material> liquid = Arrays.asList(new Material[] {
        Material.WATER,
        Material.STATIONARY_WATER,
        Material.LAVA,
        Material.STATIONARY_LAVA
        });
 
    //also create a list of all command that should be blocked, which makes the code cleaner :)
    private List<String> block = Arrays.asList(new String[] {
        "tp",
        "tpa",
        "tphere",
        "tpahere",
        });
 
    // this is the listener!
    // it will be executed, everytime a player tries to send a command
    @EventHandler(priority = EventPriority.LOW)
    public void blockCommand(PlayerCommandPreprocessEvent evt) {
        // first get the player
        Player player = evt.getPlayer();
 
        // get the material
        Material material = player.getPlayer().getLocation().getBlock().getType();
 
        // now get the command
        String command = evt.getMessage();
 
        // due to the command can be something like "/tp Inflamedsebi evilGamer66"
        // so we have to clean it up
        // we split it up on each whitspace (you shuold know arrays to understand this!)
        String[] splitcommand = command.split(" ");
 
        // the array now looks like"[/tp][Inflamedsebi][evilGamer66]"
        // and we just want to filter the basic command so we the the 1st segment (number 0)
        command = splitcommand[0];
 
        // now we just have to replace the "/" with nothing :)
        command = command.replace("/", "");
 
        // now check if the player material is a liquid AND (&&) the command is part of the blocked ones
        if(liquid.contains(material) && block.contains(command)){
 
            // if true we will cancel this event, so the player can not call this command
            evt.setCancelled(true);
 
            // just infor the player about the canceling
            player.sendMessage("Can't do this here!");
        }
 
 
 
    }
 

 

InflamedSebi The commands I wanted to block were "tpa, etpa, back, eback, tpahere, etpahere"

InflamedSebi Oh I got it. I implemented listener and registered the events on the onEnable() thanks

EDIT by Moderator: merged posts, please use the edit button instead of double posting.