Solved Update checker: only works on reload

I'm adding an update checker to my plugin. So far I have this:

Code:java

 
Server server = Bukkit.getServer();
ConsoleCommandSender console = server.getConsoleSender();
 
    public void onEnable(){
        PluginManager plm = this.getServer().getPluginManager();
        plm.registerEvents(new JoinListener(), this);
        getConfig().options().copyDefaults(true);
        saveConfig();
 
        this.updateChecker = new UpdateChecker(this, "/*link to download*/");
        this.updateChecker.updateNeeded();
        if(getConfig().getString("checkupdate") == "true"){
            if(this.updateChecker.updateNeeded() == true){
                console.sendMessage(ChatColor.GREEN + "[E] A new version is available: " + this.updateChecker.getVersion());
                console.sendMessage(ChatColor.GREEN + "[E] Get it from: " + this.updateChecker.getLink());
            }
            if(this.updateChecker.updateNeeded() == false){
                console.sendMessage(ChatColor.GREEN + "[E] E is up to date! (Version " + this.updateChecker.getVersion() + ")");
            }
        }
        console.sendMessage(ChatColor.GREEN + "[E] Enabled E v" + this.updateChecker.getVersion());
    }

In UpdateChecker.class:

Code:java

public class UpdateChecker {
 
    private E plugin;
    private URL filesFeed;
 
    private String version;
    private String link;
 
    public UpdateChecker(E plugin, String url){
        this.plugin = plugin;
 
        try{
            this.filesFeed = new URL(url);
        }catch (MalformedURLException e){
            e.printStackTrace();
        }
    }
 
    public boolean updateNeeded(){
        try{
            InputStream input = this.filesFeed.openConnection().getInputStream();
            Document document = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(input);
 
            Node latestFile = document.getElementsByTagName("item").item(0);
            NodeList children = latestFile.getChildNodes();
 
            this.version = children.item(1).getTextContent().replaceAll("[a-zA-Z ]",  "");
            this.link = children.item(3).getTextContent();
 
            if(plugin.getDescription().getVersion().equals(this.version)){
                return false;
            }
        }catch (Exception e){
            e.printStackTrace();
        }
        return true;
    }
 
    public String getVersion(){
        return this.version;
    }
 
    public String getLink(){
        return this.link;
    }
 
}

It's entirely based off of BetterPHP's tutorial on update checking. When I followed along with the tutorial, everything worked fine... but as soon as I add color, I get this error:

Code:

2013-09-09 22:07:16 [INFO] [E] Enabling E v1.5.1
2013-09-09 22:07:16 [SEVERE] Error occurred while enabling E v1.5.1 (Is it up to date?)
java.lang.NullPointerException
    at me.michaelkrauty.E.E.onEnable(E.java:48)
    at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:217)
    at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:457)
    at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:381)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.loadPlugin(CraftServer.java:282)
    at org.bukkit.craftbukkit.v1_6_R2.CraftServer.enablePlugins(CraftServer.java:264)
    at net.minecraft.server.v1_6_R2.MinecraftServer.l(MinecraftServer.java:313)
    at net.minecraft.server.v1_6_R2.MinecraftServer.f(MinecraftServer.java:290)
    at net.minecraft.server.v1_6_R2.MinecraftServer.a(MinecraftServer.java:250)
    at net.minecraft.server.v1_6_R2.DedicatedServer.init(DedicatedServer.java:151)
    at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java:391)
    at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:582)

However, if I reload the server, the update checker works just fine, and prints the appropriate messages to the console as it should (with color)

Any ideas on how to fix this? Any help is appreciated.

 

What's line 48?

 

michaelkrauty
Some hints to you code in general:
- String should be compared with equals (First Code, Line 13)
- 'if ( something == true)' is redundant. if needs a true or false in it, so if somthing it true, there is no need to check it. 'if (something)' is enough
- If you want to do something for the opposite of an if-condition, dont check against false, just use else. 'if (something) { [code for true] } else { [code for false] }
- I think First Code, Line 12 can be removed.

For your problem: What chasechocolate said.

 

Line 48 in the main class is

Code:java

console.sendMessage(ChatColor.GREEN + "[E] E is up to date! (Version " + this.updateChecker.getVersion() + ")");

I don't get what's wrong with that...

And now the error points out line 49

Code:java

/*47*/            if(!this.updateChecker.updateNeeded()){
/*48*/                console.sendMessage(ChatColor.GREEN + "[E] E is up to date! (Version " + this.updateChecker.getVersion() + ")");
/*49*/            }

I just got it...

Code:java

 
        Server server = Bukkit.getServer();
        ConsoleCommandSender console = server.getConsoleSender();

had to be IN onEnable()
Thanks for the help

EDIT by Moderator: merged posts, please use the edit button instead of double posting.