How to get location in a sphere instead of a square?

Okay, so my plugin is like the essentials /near but the distance is editable in the config. My problem I'm having is this. Lets say the distance is set to 100. Well, if I go north, east, south, or west past 100 blocks it doesn't let me see any further (Like it's suppose to) but lets say I go diagonal from the player. Once I do this even though I have it set to 100 it lets me see up to like 160??? I think this is because it's getting the location in a square. How would I make it get the location in a sphere so this doesn't happen? My code is all here: https://github.com/PimpDuck/DCNear

Please help, and thanks

chasechocolate It seems like you're the only person experienced enough and knows how to do this... Could you help? :/ This is the last bug that needs fixed then the plugins done

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

A friend made me this method.

Code:java

    private static List<Location> circle(Location loc, int radius, int height, boolean hollow, boolean sphere, int plusY){
        List<Location> circleblocks = new ArrayList<Location>();
        int cx = loc.getBlockX();
        int cy = loc.getBlockY();
        int cz = loc.getBlockZ();
 
        for(int x = cx - radius; x <= cx + radius; x++){
            for (int z = cz - radius; z <= cz + radius; z++){
                for(int y = (sphere ? cy - radius : cy); y < (sphere ? cy + radius : cy + height); y++){
                    double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
 
                    if(dist < radius * radius && !(hollow && dist < (radius - 1) * (radius - 1))){
                        Location l = new Location(loc.getWorld(), x, y + plusY, z);
                        circleblocks.add(l);
                    }
                }
            }
        }
 
        return circleblocks;
    }

PimpDuck

 

kreashenz So how exactly would this work with my code? All my code is here: https://github.com/PimpDuck/DCNear If you helped it would mean ALOT. I mean, this is the last bug on my plugin then I'm done

 

Just try..

// In the command
circle(player.getLocation(), 50, 20, false, true, 0);

 

kreashenz I'm not sure what you mean by "in the command" Can you be a little more specific?

 

PimpDuck

// command name
// check if the sender is a player
// player has permission
circle(player.getLocation(), 50, 20, false, true, 0);
}
}
}

 

kreashenz I added

Code:

  private static List<Location> circle(Location loc, int radius, int height, boolean hollow, boolean sphere, int plusY){
            List<Location> circleblocks = new ArrayList<Location>();
            int cx = loc.getBlockX();
            int cy = loc.getBlockY();
            int cz = loc.getBlockZ();
 
            for(int x = cx - radius; x <= cx + radius; x++){
                for (int z = cz - radius; z <= cz + radius; z++){
                    for(int y = (sphere ? cy - radius : cy); y < (sphere ? cy + radius : cy + height); y++){
                        double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
 
                        if(dist < radius * radius && !(hollow && dist < (radius - 1) * (radius - 1))){
                            Location l = new Location(loc.getWorld(), x, y + plusY, z);
                            circleblocks.add(l);
                        }
                    }
                }
            }
 
            return circleblocks;
        }

to my class. Now it looks like

Code:java

package me.PimpDuck.DCNear;
 
 
 
import java.util.*;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
 
public class CommandClass implements CommandExecutor {
 
List<String> nearby = new ArrayList<String>();
 
private Main plugin;
 
public CommandClass(Main instance)
{
this.plugin = instance;
}
 
private static List<Location> circle(Location loc, int radius, int height, boolean hollow, boolean sphere, int plusY){
List<Location> circleblocks = new ArrayList<Location>();
int cx = loc.getBlockX();
int cy = loc.getBlockY();
int cz = loc.getBlockZ();
 
for(int x = cx - radius; x <= cx + radius; x++){
for (int z = cz - radius; z <= cz + radius; z++){
for(int y = (sphere ? cy - radius : cy); y < (sphere ? cy + radius : cy + height); y++){
double dist = (cx - x) * (cx - x) + (cz - z) * (cz - z) + (sphere ? (cy - y) * (cy - y) : 0);
 
if(dist < radius * radius && !(hollow && dist < (radius - 1) * (radius - 1))){
Location l = new Location(loc.getWorld(), x, y + plusY, z);
circleblocks.add(l);
}
}
}
}
 
return circleblocks;
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd, String command, String[] args) {
if(cmd.getName().equalsIgnoreCase("near")){
if ((sender instanceof Player)) {
Player player = (Player) sender;
double range = 0;
if (player.hasPermission("dcnear.god") || player.hasPermission("dcnear.ub3r") || player.hasPermission("dcnear.legend") || player.hasPermission("dcnear.super") || player.hasPermission("dcnear.*")) {
 
if (args.length > 1) {
player.sendMessage(ChatColor.DARK_BLUE + "[DCNear] " + ChatColor.DARK_RED + "Too many arguments!");
return false;
}
if (args.length == 1 && player.hasPermission("dcnear.*")) {
try {
range = Double.parseDouble(args[0]);
} catch (NumberFormatException nfe) {
player.sendMessage(ChatColor.DARK_BLUE + "[DCNear] " + ChatColor.DARK_RED + "Argument must be a number!");
return false;
}
}
if (args.length == 0 && player.hasPermission("dcnear.god")) {
range = this.plugin.getConfig().getDouble("god");
}
if(args.length == 0 && player.hasPermission("dcnear.ub3r")){
range = this.plugin.getConfig().getDouble("ub3r");
}
if(args.length == 0 && player.hasPermission("dcnear.legend")){
range = this.plugin.getConfig().getDouble("legend");
}
if(args.length == 0 && player.hasPermission("dcnear.super")){
range = this.plugin.getConfig().getDouble("super");
}
 
if (range != 0 ) {
Location start_loc = player.getLocation();
StringBuilder sb = new StringBuilder();
for (Entity nearbyEntity : player.getNearbyEntities(range, range, range)) {
if (nearbyEntity instanceof Player) {
nearby.add(((Player) nearbyEntity).getName());
Location end_loc = nearbyEntity.getLocation();
int distance = (int) start_loc.distance(end_loc);
sb.append(((Player) nearbyEntity).getName()).append(" (").append(ChatColor.DARK_RED).append(distance).append("m").append(ChatColor.WHITE).append("), ");
}
}
String message;
if (sb.length() > 0) {
message = sb.toString().substring(0, (sb.length() - 2));
} else {
message = "none";
}
player.sendMessage(ChatColor.GOLD + "Players nearby: " + ChatColor.WHITE + message);
}
} else {
sender.sendMessage(ChatColor.DARK_BLUE + "[DCNear] " + ChatColor.DARK_RED + "You do not have permission use this command!");
return false;
}
} else {
sender.sendMessage(ChatColor.DARK_BLUE + "[DCNear] " + ChatColor.DARK_RED + "Only in game players can use this command!");
return false;
}
return true;
}
return false;
}
}

So looking at this code, where would I put that statement without causing errors and so everything else still works fluently.

 

kreashenz http://forums.bukkit.org/threads/post-your-most-advanced-code.148664/#post-1688525

 

chasechocolate Do you see any way of fixing it? :/ Like I said, I'm pretty much done except this

 

PimpDuck I'm just gonna submit a pull request to the repo, and hopefully you will be able to see/understand what I am doing

 

chasechocolate Oh that would be great and mean alot man

chasechocolate Thanks man, it works. I owe you alot. You're a great guy and deserve your staff position!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

chasechocolate Wow! Haha, my friend must have gotten it from you. Thanks for that, it helped me a lot in a plugin

 

Sorry for taking so long to reply to you PimpDuck. I replied to you in your other thread. It was a simple edit:


You originally had this:

Code:java

for (Entity nearbyEntity : player.getNearbyEntities(range, range, range)) {
    if (nearbyEntity instanceof Player) {
        Location end_loc = nearbyEntity.getLocation();
        int distance = (int) start_loc.distance(end_loc);
 
        if(distance <= range){
            sb.append(((Player) nearbyEntity).getName()).append("(").append(ChatColor.DARK_RED).append(distance).append("m").append(ChatColor.WHITE).append("), ");
        }
    }
}

And it could have been changed simply to this:

Code:java

for (Player nearbyPlayer : player.getServer().getOnlinePlayers()) {
    Location end_loc = nearbyPlayer.getLocation();
    int distance = (int) player.getLocation().distance(end_loc);
 
    if(distance <= range){
        sb.append(((Player) nearbyEntity).getName()).append("(").append(ChatColor.DARK_RED).append(distance).append("m").append(ChatColor.WHITE).append("), ");
    }
}