Solved I have a bug with the damage of throwing shuriken!

I tried to make a throw shuriken, and I did.
But, there is a problem, the problem is another player does not get damage from a shuriken.

My listener code:

Code:java

public class MyPlayerListener implements Listener {
 
    public static Test plugin;
 
    public MyPlayerListener(Test instance) {
        plugin = instance;
    }
 
    Player shurikenPlayer;
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        int blockId = player.getItemInHand().getType().getId();
        if (blockId == 399 && event.getAction() == Action.RIGHT_CLICK_AIR || blockId == 399 && event.getAction() == Action.RIGHT_CLICK_BLOCK) {
            final Item item = player.getWorld().dropItem(player.getEyeLocation(), new ItemStack(Material.NETHER_STAR));
            item.setVelocity(player.getLocation().getDirection().multiply(1.75D));
            item.setPickupDelay(Integer.MAX_VALUE);
            player.getInventory().removeItem(new ItemStack(Material.NETHER_STAR, 1));
            player.updateInventory();
            item.getWorld().playSound(item.getLocation(), Sound.STEP_SNOW, 5, 5);
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
 
                @Override
                public void run() {
                    item.remove();
                    item.getWorld().playSound(item.getLocation(), Sound.DIG_GRAVEL, 1, 1);
                }
            }, 20);
        }
    }
 
    @EventHandler
    public void onPlayerMove(PlayerMoveEvent event) {
        Player player = event.getPlayer();
        for (Entity entity : player.getNearbyEntities(1, 1, 1)) {
            if (entity.getType() == EntityType.DROPPED_ITEM) {
                if (entity instanceof Item) {
                    if (((Item) entity).getItemStack().getType() == Material.NETHER_STAR) {
                        if (player != null) {
                            shurikenPlayer.damage(4.0D);
                        }
                    }
                }
            }
        }
    }

Thanks for who try to help me!

 

this

Code:java

if (player != null) {
                            shurikenPlayer.damage(4.0D);
                        }

replace it with

Code:java

player.damage(4.0D);

 

Conarnar Another player receives damage, but I also get damage when I move and throw.

 

Instead of using PlayerMoveEvent make a BukkitRunnable that keeps track of the shuriken and detects players near it and damage them. Add a delay in the beginning so that You don't get damaged if you throw it.

 

Conarnar Can you make for me a code example, not that I understood you, sorry.

 

Code:java

new BukkitRunnable() {
public void run {
for (Entity entity: item.getNearbyEntities(1, 1, 1)) {
if (entity.getType() == EntityType.PLAYER) {
item.remove();
((Player) entity).damage(4.0D);
cancel();
return;
}
}
}
}.runTaskTimer(plugin, 2, 1);
 

put it after you spawn the item

 

Conarnar Now when a player throws a shuriken as he moved forward with the throw, he gets damage, the shuriken that hits it a bit if I'm not mistaken, but it gets damage.
So how do we fix it?

My code now:

Code:java

    @SuppressWarnings("deprecation")
    @EventHandler
    public void onPlayerInteract(PlayerInteractEvent event) {
        Player player = event.getPlayer();
        int blockId = player.getItemInHand().getType().getId();
        if (blockId == 399 && event.getAction() == Action.RIGHT_CLICK_AIR || blockId == 399 && event.getAction() == Action.RIGHT_CLICK_BLOCK) {
            final Item item = player.getWorld().dropItem(player.getEyeLocation(), new ItemStack(Material.NETHER_STAR));
            item.setVelocity(player.getLocation().getDirection().multiply(1.75D));
            item.setPickupDelay(Integer.MAX_VALUE);
            player.getInventory().removeItem(new ItemStack(Material.NETHER_STAR, 1));
            player.updateInventory();
            item.getWorld().playSound(item.getLocation(), Sound.STEP_SNOW, 5, 5);
            new BukkitRunnable() {
 
                @Override
                public void run() {
                    for (Entity entity: item.getNearbyEntities(1, 1, 1)) {
                        if (entity.getType() == EntityType.PLAYER) {
                            ((Player) entity).damage(4.0D);
                            cancel();
                            return;
                        }
                    }
                }
            }.runTaskTimer(plugin, 2, 1);
            Bukkit.getServer().getScheduler().scheduleSyncDelayedTask(plugin, new Runnable() {
 
                @Override
                public void run() {
                    item.remove();
                    item.getWorld().playSound(item.getLocation(), Sound.DIG_GRAVEL, 1, 1);
                }
            }, 20);
        }
    }

 

Actualy the player will be killed.
When you damaging the player remove the item drop and in the second runable just check if the item exist

 

Try replacing this bit:

Code:java

for (Entity entity: item.getNearbyEntities(1, 1, 1)) {
    if (entity.getType() == EntityType.PLAYER) {
        ((Player) entity).damage(4.0D);
        cancel();
        return;
    }
}

with this:

Code:java

for (Entity entity: item.getNearbyEntities(1, 1, 1)) {
    if (entity.getType() == EntityType.PLAYER) {
        if((Player) entity != player) { 
            ((Player) entity).damage(4.0D);
        } 
        cancel();
        return;
    }
}

 

creatorfromhell Thanks bro!

 

No problem.