PlayerCommandPreproccessEvent not letting me run commands not in plugin.yml

I am using the PlayerCommandPreproccessEvent to let commands that aren't in the plugin.yml run. It isn't going too well. I don't know if I should register the command or do what. The code is pretty short and should be able to be fixed pretty easy. I'll just put the part that handles the commands.

Code:java

public boolean PlayerCommandPreprocessEvent(Player player, String msg, org.bukkit.event.player.PlayerCommandPreprocessEvent event){
        ConfigurationSection cs = getConfig().getConfigurationSection("warpcmds");
        for (String s : cs.getKeys(false)) {
            ConfigurationSection cs2 = cs.getConfigurationSection(s);
            if (msg == cs2.getString("command")){
                if (player.hasPermission("WarpCommands." + cs2.getString("command"))) {
                    player.performCommand("warp " + cs2.getString("warpname"));
                    event.setCancelled(false);
                } else return false;
            }
        }
        return true;
    }

 

dingus007
... hope this helps

Code:java

 
HashMap<String, String> map = new HashMap<String, String>(); // map.put(warpname, command)
HashMap<String, Location> warps = new HashMap<String, Location>(); //map.put(warpname, location)
public boolean warp(Player p, String warpname){
if(warps.contains(warpname)){
e.getPlayer().teleport(warps.get(warpname);
return true;
}else{
return false;
}
}
@EventHandler
public void command(PlayerCommandPreprocessEvent e) {
for (Entry<String, String> en : map) {
if (e.getMessage().equalsIgnoreCase(en.getValue())) {
if(warp(e.getPlayer(), en.getKey()))
e.getPlayer().sendMessage("Warped To " + en.getKey());
else
e.getPlayer().sendMessage("Warp Doesn't Exist.. problem!");
} else {
}
}
}

 

if(msg == cs2.getString("command")) {

Never do this. Always compare Strings with equals or equalsIgnoreCase.

if(msg.equalsIgnoreCase(cs2.getString("command")) {

 

There were some errors I couldn't fix on my own, I put them in comments

Code:java

if(warps.contains(warpname)){ //The method contains(String) is undefined for the type HashMap<String,Location>
    e.getPlayer().teleport(warps.get(warpname)); //e cannot be resolved
    return true;
    }else{
    return false;}
    }
      @EventHandler
        public void command(PlayerCommandPreprocessEvent e) {
            for (Entry<String, String> en : map) { //Can only iterate over an array or an instance of java.lang.Iterable

Also, here is my imports:

Code:java

import java.util.HashMap;
import java.util.Map.Entry;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.configuration.ConfigurationSection;
import org.bukkit.entity.Player;
import org.bukkit.event.Event;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
import org.bukkit.plugin.java.JavaPlugin;

 

Code:java

if(warps.containsKey(warpname)){ //The method contains(String) is undefined for the type HashMap<String,Location> -- oops didn't do the write method
    p.teleport(warps.get(warpname)); //e cannot be resolved - oops... forgot to change the variable 
    return true; 
    }else{
    return false;}
    }
      @EventHandler
        public void command(PlayerCommandPreprocessEvent e) {
            for (Entry<String, String> en : map.entrySet()) { //Can only iterate over an array or an instance of java.lang.Iterable -- oops didn't use .entrySet()
 

 

Still doesn't work, I can't figure out why...

Code:java

package com.elements.warpcommands;
 
 
import java.util.HashMap;
import java.util.Map.Entry;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
 
public class WarpCommands extends JavaPlugin {
 
    public void sendMessage(Player player, String msg){
        player.sendMessage(ChatColor.GOLD + "[WarpCommands] " + ChatColor.WHITE + "You must be a player to execute this command");
    }
 
    public void onEnable() {
        System.out.println("Enabling WarpCommands");
        this.saveDefaultConfig();
    }
 
    public void onDisable() {
        System.out.println("Disabling WarpCommands");
    }
 
 
 
    HashMap<String, String> map = new HashMap<String, String>(); // map.put(warpname, command)
    HashMap<String, Location> warps = new HashMap<String, Location>(); //map.put(warpname, location)
    public boolean warp(Player p, String warpname){
        if(warps.containsKey(warpname)){ //The method contains(String) is undefined for the type HashMap<String,Location> -- oops didn't do the write method
            p.teleport(warps.get(warpname)); //e cannot be resolved - oops... forgot to change the variable
            return true;
            }else{
            return false;}
            }
              @EventHandler
            public void command(PlayerCommandPreprocessEvent e) {
            for (Entry<String, String> en : map.entrySet()) { //Can only iterate over an array or an instance of java.lang.Iterable -- oops didn't use .entrySet()
            if (e.getMessage().equalsIgnoreCase(en.getValue())) {
                if(warp(e.getPlayer(), en.getKey()))
                    e.getPlayer().sendMessage(ChatColor.GOLD + "Warped To " + ChatColor.WHITE + en.getKey());
                else
                    e.getPlayer().sendMessage(ChatColor.RED + "Warp doesn't exist!");
                } else {
                }
            }
        }
}
 

 

getCommand("commandName").register(((CraftServer)Bukkit.getServer()).getCommandMap())
This will require importing the craftbukkit library

 

Am I doing it right?

Code:java

for (Entry<String, String> en : map.entrySet()) {
            getCommand(en.getValue()).register(((CraftServer)Bukkit.getServer()).getCommandMap());
            if (e.getMessage().equalsIgnoreCase(en.getValue())) {
                if(warp(e.getPlayer(), en.getKey()))
                    e.getPlayer().sendMessage(ChatColor.GOLD + "Warped To " + ChatColor.WHITE + en.getKey());
                else
                    e.getPlayer().sendMessage(ChatColor.RED + "Warp doesn't exist!");
                } else {
                }
            }

 

You have to register the command in advance, not during the CommandPreprocessEvent. If the command isn't registered, the CommandPreprocessEvent is never called in the first place.

 

So I made this function outside of the PlayerCommandPreprocessEvent to register all commands in config, but it still doesn't work...

Code:java

    public void registerCommands() {
        ConfigurationSection cs = getConfig().getConfigurationSection("warpcmds");
        for (String s : cs.getKeys(false)) {
            ConfigurationSection cs2 = cs.getConfigurationSection(s);
            getCommand(cs2.getString("command")).register(((CraftServer)Bukkit.getServer()).getCommandMap());
        }
    }

 

Thats not true, my plugin use this event to execute dynamic defined commands and aliases and is working well. CommandPreprocessEvent triggers on any chat of players starting with /

dingus007
warp is a command that really exists and manages the warpnames, right? Then try to replace player.performCommand("warp " + cs2.getString("warpname")); with player.chat("/warp " + cs2.getString("warpname"));

 

That's not the problem I'm having. It teleports them fine if the warp exists, I just need to get some way of running commands without them being registered. I have already tried the above methods, so either I'm not doing something right or the code is non functional (which I doubt)

 

Oh, yes, PlayerCommandPreprocess does grab any command, even unregistered. It just doesn't hear commands that are performCommand(x)ed. Using player.chat(x) will work, as will simply calling your command function with a PlayerCommandPreprocessEvent that you create.

 

dingus007
You aren't registering the event in your onEnable
http://wiki.bukkit.org/Event_API_Reference#Registering_Events

 

oh oah oh