Vars in command don't reset after command?

I have something like that:

Code:

public class Define implements CommandExecutor {
    private Location p1, p2, p3, p4, loc, loc2, copy;
    private Player player;
    // private String playerName;
    private int size;
    private int[] dir;
    private int[] sizes = { 22, 48, 65, 139, 285, 502 };
    private boolean isBonus;
    private World world;
    private Block block, toRemove;
    final private BaseBlock[] fenceBlocks = { new BaseBlock(139, 0),
            new BaseBlock(139, 1), new BaseBlock(121, 0) };
//Rest of code

But I have one problem.... in some place I have debug messages with p1,p2,p3,p4. And when I type a command I still get locations from previous command ;/
Why? Variables don't reset after command? that feature of static but I don't use private static Location ;/ So... where is problem

 

The scope of the variables in question is class-wide, so they'll persist outside of the onCommand(...) method. You need to update them in your onCommand block; the variables aren't automatically updated simply because you implement CommandExecutor.

 

Aw... so i must reset ALL values ? ;/
p1=nul;
p2=null;
etc... ?

 

No need. Unless you absolutely need to save the variables listed above, limit their scope to the onCommand(...) method. And even if they are to be saved, I can't imagine why they'd ever need to be reset - only updated.

 

Most of that variables will be updated in code but p1,p2,p3 p4 is updated in loop end:
if p1 is null then set p1 to current loc else if p2 is null then set p1 to current loc else if p3... So I can't update it in code.

 

Can you paste your CommandExecutor in its entirety?

 

eeem.... ok but my code don't work anyway xD
That code to get 4 corners of Region (must have full fence). But I have problems with one or two walls ;/

Code:java

 
package com.gmail.bukkitSmerf.cmd;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Location;
import org.bukkit.World;
import org.bukkit.block.Block;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import com.gmail.bukkitSmerf.minelive.Util;
import com.sk89q.worldedit.blocks.BaseBlock;
 
public class Define implements CommandExecutor {
    private Location p1, p2, p3, p4, loc, loc2, copy;
    private Player player;
    // private String playerName;
    private int size;
    private int wall = 0;
    private int[] dir;
    private int[] sizes = { 22, 48, 65, 139, 285, 502 };
    private boolean isBonus;
    private World world;
    private Block block, toRemove;
    final private BaseBlock[] fenceBlocks = { new BaseBlock(139, 0),
            new BaseBlock(139, 1), new BaseBlock(121, 0) };
    private List<int[]> usedDir = new ArrayList<int[]>();
 
    private boolean noRegionReturn() {
        Util.sendMsg(
                "&4Nie wykryto wolnej dzialki.\n&cMusisz stanac obok dzialki i patrzac sie na plot wpisac ta komende. :)\n&bJesli jestes pewien ze wszystko robisz dobrze a blad dalej wystepuje napisz do &aBukkit&9Smerf&b-y",
                player);
        return true;
    }
 
    private void resetLoc() {
        loc2 = copy.clone();
    }
 
    private Location add(int[] i, boolean multi) {
        if (!multi)
            return loc.clone().add(i[0], (i.length == 2) ? 0 : i[1],
                    (i.length == 2) ? i[1] : i[2]);
        else {
            return (loc2.add(i[0], (i.length == 2) ? 0 : i[1],
                    (i.length == 2) ? i[1] : i[2]));
        }
    }
 
    private boolean isValid() {
        for (BaseBlock vaild : fenceBlocks) {
            if (block.getTypeId() == vaild.getId()
                    && block.getData() == vaild.getData())
                return true;
        }
        return false;
    }
 
    private boolean checkBlock(Block block) {
        if (this.block.getTypeId() == block.getTypeId()
                && this.block.getData() == block.getData())
            return true;
        return false;
    }
 
// I don't know why but usedDir.contains don't work.
    private boolean isBlocked(int[] dir) {
        for (int[] block : usedDir)
            if (block[0] == dir[0] && block[1] == dir[1] && block[2] == dir[2])
                return true;
        return false;
    }
 
    private int[] getDir() {
        int[] result;
        String kier = "";
        for (int[] lol : usedDir) {
            kier += "[" + lol[0] + ", " + lol[1] + ", " + lol[2] + "], ";
        }
 
        //debug
        Util.sendMsg("Wybieranie kierunku: (Zablokowane: " + kier + ")", player);
        if (checkBlock(add(new int[] { 1, 0 }, false).getBlock())
                && checkBlock(add(new int[] { -1, 0 }, false).getBlock())) {
            result = new int[] { 0, 1, 1 };
            usedDir.add(result);
            usedDir.add(new int[] { 0, 1, 0 });
            usedDir.add(new int[] { 0, 0, 1 });
 
            //debug
            Util.sendMsg("wybrano: [" + result[0] + ", " + result[1] + ", "
                    + result[2] + "]1, ", player);
            return result;
        } else if (checkBlock(add(new int[] { 1, 0 }, false).getBlock())
                && (checkBlock(add(new int[] { 0, 1 }, false).getBlock()) || checkBlock(add(
                        new int[] { 0, -1 }, false).getBlock()))) {
            result = new int[] { 0, 0, 1 };
            if (!isBlocked(result)) {
                usedDir.add(result);
                usedDir.add(new int[] { 0, 1, 0 });
            } else {
                if (checkBlock(add(new int[] { 0, 1 }, false).getBlock())) {
                    result = new int[] { 1, 0, 1 };
                } else {
                    result = new int[] { 1, 1, 0 };
                }
 
            }
 
            //debug
            Util.sendMsg("wybrano: [" + result[0] + ", " + result[1] + ", "
                    + result[2] + "]2, ", player);
            return result;
        } else if (checkBlock(add(new int[] { -1, 0 }, false).getBlock())
                && (checkBlock(add(new int[] { 0, 1 }, false).getBlock()) || checkBlock(add(
                        new int[] { 0, -1 }, false).getBlock()))) {
            result = new int[] { 0, 1, 0 };
            if (!isBlocked(result)) {
                usedDir.add(result);
                usedDir.add(new int[] { 0, 1, 0 });
            } else {
                if (checkBlock(add(new int[] { 0, 1 }, false).getBlock())) {
                    result = new int[] { 1, 0, 1 };
                } else {
                    result = new int[] { 1, 1, 0 };
                }
            }
 
            //debug
            Util.sendMsg("wybrano: [" + result[0] + ", " + result[1] + ", "
                    + result[2] + "]3, ", player);
            return result;
        } else if (checkBlock(add(new int[] { 0, -1 }, false).getBlock())
                && checkBlock(add(new int[] { 0, 1 }, false).getBlock())) {
            result = new int[] { 1, 1, 1 };
            usedDir.add(result);
            usedDir.add(new int[] { 1, 1, 0 });
            usedDir.add(new int[] { 1, 0, 1 });
 
            //debug
            Util.sendMsg("wybrano: [" + result[0] + ", " + result[1] + ", "
                    + result[2] + "]4, ", player);
            return result;
        } else
            return null;
 
    }
 
    private boolean isValidSize() {
        for (int size : sizes)
            if (this.size == size)
                return true;
        return false;
    }
 
    private boolean getWalls() {
        Util.sendMsg("3", player);
        for (wall = 1; wall < 5; wall++) {
 
            //debug
            Util.sendMsg("4 + " + wall, player);
            dir = getDir();
            if (dir == null)
                return noRegionReturn();
            else if ((dir[1] + dir[2] != 2) && p1 == null) {
                usedDir.clear();
                p1 = loc;
                Util.sendMsg("LOL", player);
                continue;
            }
            boolean isZFade = (dir[0] == 1);
 
            //debug
            Util.sendMsg("5 + DIR: " + dir[0] + "," + dir[1] + "," + dir[2]
                    + ", " + isZFade, player);
            boolean next = false;
            for (int i = 1; i < 505; i++) {
                if (!next) {
                    if (checkBlock(add(
                            (isZFade) ? new int[] { 0, ((dir[1] == 0) ? 1 : -1) }
                                    : new int[] { ((dir[1] == 0) ? 1 : -1), 0 },
                            true).getBlock())) {
                        if (wall == 1)
                            size++;
                    } else {
                        loc2.subtract(((isZFade) ? 0 : (dir[1] == 0) ? 1 : -1),
                                0, ((!isZFade) ? 0 : (dir[1] == 0) ? 1 : -1));
                        if (p1 == null) {
                            Util.sendMsg("LOL2", player);
                            next = true;
                            p1 = loc2.clone();
                            continue;
                        } else if (p2 == null) {
                            p2 = loc2.clone();
                            break;
                        } else if (p3 == null) {
                            p3 = loc2.clone();
                            break;
                        } else if (p4 == null) {
                            p4 = loc2.clone();
                            break;
                        }
                    }
                } else {
                    resetLoc();
                    if (checkBlock(add(
                            (isZFade) ? new int[] { 0, ((dir[2] == 0) ? -1 : 1) }
                                    : new int[] { ((dir[2] == 0) ? -1 : 1), 0 },
                            true).getBlock()))
                        size++;
                    else {
                        p2 = loc2.clone();
                        break;
                    }
                }
            }
            loc = loc2.clone();
 
            //debug
            Util.sendMsg("6" + size, player);
            if (wall == 1)
                if (!isValidSize())
                    return noRegionReturn();
 
            //debug
            Util.sendMsg("7", player);
            Util.sendMsg("Sciania gotowa", player);
        }
 
        //debug
        Util.sendMsg("8", player);
        Util.sendMsg(
                "Wszystko gotowe!\nP1:"
                        + ((p1 != null) ? p1.getBlockX() + ", "
                                + p1.getBlockZ() : "")
                        + "\nP2:"
                        + ((p2 != null) ? p2.getBlockX() + ", "
                                + p2.getBlockZ() : "")
                        + "\nP3:"
                        + ((p3 != null) ? p3.getBlockX() + ", "
                                + p3.getBlockZ() : "")
                        + "\nP4:"
                        + ((p4 != null) ? p4.getBlockX() + ", "
                                + p4.getBlockZ() : ""), player);
        return true;
    }
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        if (sender instanceof Player) {
            isBonus = (args.length > 0 && (args[0].equalsIgnoreCase("true") || args[0]
                    .equalsIgnoreCase("1"))) ? true : false;
            player = (Player) sender;
            // playerName = player.getName();
            block = player.getTargetBlock(null, 5);
            world = player.getWorld();
 
            //debug
            Util.sendMsg("1", player);
            if ((block == null || block.getTypeId() == 1) || !isValid())
                return noRegionReturn();
            toRemove = block;
            size = 1;
            loc = block.getLocation();
            loc2 = loc.clone();
            copy = loc.clone();
 
            //debug
            Util.sendMsg("2", player);
            getWalls();
            resetVar();
        }
        return true;
    }
 
    private void resetVar() {
        p1 = null;
        p2 = null;
        p3 = null;
        p4 = null;
        loc = null;
        loc2 = null;
        copy = null;
        player = null;
        // playerName = null;
        size = 0;
        wall = 0;
        dir = null;
        isBonus = false;
        world = null;
        block = null;
        toRemove = null;
        usedDir.clear();
    }
}
 

Sorry for some Polish language

 

When are values supposed to be reset? After a region has been completed?

 

eeem All. But "sizes" and "fenceBlocks" don't must be reset.
And my code don't work NOT becouse I can't reset it, But I just don't know how to write code for find and check that walls/corners

 

I suspect that the problem is this:

You wrote code believing that it works like this:

1. You tell the game "please use this class when someone types this command."
2. A player types the command.
3. The game creates an instance of your class.
4. The game runs the onCommand() for that instance.
5. The game throws away the instance of your class and it gets orphaned away.
6. The player types another command.
7. The game makes a new instance of your class.
8. The game runs the onCommand() for that instance.
9. The game throws away the instance of your class and it gets orphaned away.
10. ...and so on...

But in reality it works like this:

1. You tell the game "please use this class when someone types this command."
2. The game makes an instance of your class and stores it somewhere.
3. A player types the command.
4. The game runs the onCommand() in the instance it already made.
5. The player types another command.
6. The game runs the onCommand() in the instance it already made.
7. ...and so on...

The difference between static and non-static variables is whether there's a different copy per-instance, or just one copy globally that they all share access to. But in this case since there will only ever be one instance of your class anyway, you don't see any difference.

I am NOT familiar with the details of how the system does what it does. I'm just guessing from what you're saying is happening that this is the reason.

 

Because the class implements CommandExecutor, this should never be the case. Rather, calling getCommand("define").setExecutor(new Define()) in the plugin's onEnable() method suffices.

bfgbfggf
One issue with tracking locations in the CommandExecutor itself is that you can only have data for one player at a time - it's not as if a new executor is instantiated every time a player runs a command. This is obviously problematic for a number of reasons, chief among which is that only one player can define a region at a time.

 

hyyym. Can I create second class eg: UseDefine.class and in Define.class add
new UseDefine(sender, args); (or new UseDefine().define(sender, args));
And all code paste to UseDefine.class ?
And that will by work for multiple players?

That will be work? ;/

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It's a stretch, and even in its best implementation will be inefficient and prone to malfunction. Why not just map the data to the appropriate player? Use a HashMap<Player, Location[]> where the Location array contains region boundaries.

 

Hyyym... what can happen when 2 player use command? (PS: weee code work. create WordGuard region when player looking at fence and type "/define" command )

 

If multiple players run the command they'll all contribute to the creation of the same arena.

 

hyym, but if I remove all Vars from eeem (I don't know how to name it) no-method space xD and put all to method and just send it to other methods then that problem will by fixed?
eg:

Code:

class...
private Location p1,p2,p3,p4;
private boolean method1(){
//some code using locations
}
public boolean onCommand(bla bla bla bla){
// some code using locations
method1();
}

Change to:

Code:

class...
private boolean method1(Location p1, Location p2, Location p3, Location p4){
//some code using locations
}
public boolean onCommand(bla bla bla bla){
Location p1,p2,p3,p4;
// some code using locations
method1(p1 ,p2, p3, p4);
}

 

If you put the variables in the onCommand(...) method, they'll expire as soon as the method returns, which renders them useless as a player can only define one corner of a region at once. I caved and wrote a class to show you what I've been trying to communicated. Note that only two regions are needed in order to create a region, and that only one of those locations needs to be stored.

Code:java

import java.util.HashMap;
 
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
import com.sk89q.worldedit.BlockVector;
import com.sk89q.worldguard.bukkit.WGBukkit;
import com.sk89q.worldguard.protection.regions.ProtectedCuboidRegion;
 
public class Define implements CommandExecutor {
 
    private HashMap<Player, Location> regionCorners;
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        if (!(sender instanceof Player)) {
            sender.sendMessage(ChatColor.RED + "Only players can define regions!");
            return true;
        }
        Player player = (Player) sender;
        if (!regionCorners.containsKey(player)) { // Player is defining the first corner
            regionCorners.put(player, player.getLocation());
            player.sendMessage(ChatColor.GREEN + "Set the first region corner to your current location. " +
                    "Repeat the command at another location to complete the region.");
            return true;
        }
        // Player has already defined one corner and is now setting the second
        Location corner1 = regionCorners.get(player),
                corner2 = player.getLocation();
        ProtectedCuboidRegion region = new ProtectedCuboidRegion("region_name_here", // Region name as a cmd arg?
                new BlockVector(corner1.getBlockX(), corner1.getBlockY(), corner1.getBlockZ()),
                new BlockVector(corner2.getBlockX(), corner2.getBlockY(), corner2.getBlockZ()));
        WGBukkit.getRegionManager(corner1.getWorld()).addRegion(region);
        player.sendMessage(ChatColor.GREEN + "Defined a new region!");
        return true;
    }
}
 

 

Thanks for that, but that not code for me In my code player just type code in random place of fence and get new region. And that very important for me - region must by poly-region. I also creating command to auto-connecting regions so that will by only possible with poly-region.
I just added boolean "isRun" and 2 players can't use that command. when I finish other code then I fix it