Solved The method getAttachedFace() is undefined for the type Sign

I've been posting problems I've been having like mad about my in dev plugin, but I come here every time I can't find my problem on google.

Anyways, the title kinda says it all, the method getAttachedFace() is undefined for Sign?

Here is the code for the event:

Code:java

public void onPlayerBreakBlock(BlockBreakEvent event) {
        Player player = event.getPlayer();
        Block block = event.getBlock();
        BlockState state = block.getState();
        Sign sign;
 
        if (state instanceof Sign) {
 
            sign = (Sign) state;
 
            if (!sign.getLine(0).equals("[MultiKit Shop]")) return;
 
            if (!player.getName().equals(sign.getLine(3))) {
 
                player.sendMessage(ChatColor.RED + "You may not break that shop!");
                event.setCancelled(true);
            } else {
                player.sendMessage(ChatColor.GREEN + "Shop unregistered.");
            }
        } else {
            BlockFace[] faces = {UP, EAST, NORTH, SOUTH, WEST};
            for (BlockFace face : faces) {
                Block b = block.getRelative(sign.getAttachedFace()); //Error is here
            }
        }
    }

Can someone tell me how to fix this, or why this is happening? Thanks again.

 

Check your imports, you should be importing org.bukkit.block.Sign.

 

chasechocolate

Yup, I'm importing org.bukkit.block.Sign.

 

TheBoy3 cast it to WallSign?

 

I would think even the normal sign is attached to the DOWN face, so that probably won't work.

Edit: You could try casting it to attachable, but the Sign class should have the method...

 

You might be forced to check the block data for it's orientation.

 

I'd do that, but I need to check if the sign is a wallsign first, and I can't use sign.isWallSign(), because org.bukkit.block.Sign doesn't have the method.

After some looking in the Javadocs, I found out that those methods are actually in org.bukkit.material.Sign because it implements Attachable, but I don't know how to get the methods from the class.

 

TheBoy3 did you try instanceof WallSign ?

 

Am I missing something?

org.bukkit.block.Sign does not have getAttachedFace() only org.bukkit.material.Sign does have it. So the compiler is right about that.

What you want is probably getting the blockface from the MaterialData which you can do by doing

Code:java

 
BlockFace signFace = sign.getData().getAttachedFace();
 

If im not mistaken.

 

I don't understand why I need to try that, because the getAttachedFace() already checks if it is a wall sign, and if it is, it returns BlockFace DOWN.

Thanks, I just figured that out, but now I'm having another problem with the code:

Code:java

@EventHandler
    public void onPlayerBreakBlock(BlockBreakEvent event) {
        Player player = event.getPlayer();
        Block block = event.getBlock();
        BlockState state = block.getState();
        Sign sign;
        org.bukkit.material.Sign materialsign;
 
        plugin.logger.info("Stage 1"); //Debug line
 
        if (state instanceof Sign) {
            sign = (Sign) state;
            if (!sign.getLine(0).equals("[MultiKit Shop]")) return;
 
            if (!player.getName().equals(sign.getLine(3))) {
 
                player.sendMessage(ChatColor.RED + "You may not break that shop!");
                event.setCancelled(true);
            } else {
                player.sendMessage(ChatColor.GREEN + "Shop unregistered.");
            }
        } else {
            plugin.logger.info("Stage 2"); //Debug line
            BlockFace[] faces = {UP, EAST, NORTH, SOUTH, WEST};
            List<Block> blocks = new ArrayList<Block>();
            for (BlockFace face : faces) {
                blocks.add(block.getRelative(face));
            }
            for (Block b : blocks) {
                if (b.getState() instanceof Sign) {
                    plugin.logger.info("Stage 3"); //Debug line
                    sign = (Sign) b.getState();
                    if (sign.getLine(0).equals("[MultiKit Shop]")) {
                        plugin.logger.info("Stage 4"); //Debug line
                        materialsign = (org.bukkit.material.Sign) sign.getData();
                        if (sign.getBlock().getRelative(materialsign.getAttachedFace()).equals(b)) {
                            plugin.logger.info("Stage 5"); //Debug line
                            if (!player.getName().equals(sign.getLine(3))) {
                                player.sendMessage(ChatColor.RED + "You may not break that shop!");
                                event.setCancelled(true);
                            } else {
                                player.sendMessage(ChatColor.GREEN + "Shop unregistered.");
                            }
                        }
                    }
                }
            }
        }
    }

I doesn't seem to go to stage 5, which means that sign.getBlock().getRelative(materialsign.getAttachedFace()).equals(b) seems to be returning false, can anyone tell me why?

P.S. This may not be the most efficient code.

 

TheBoy3
sign.getBlock().getRelative(materialsign.getAttachedFace()) gets the Block the Sign is attached to. b ist the Block of the Sign. So how should the Block of the Sign be equal to the Block next to the Sign?

 

maybe you want to use
.equals(block)
sign and b are at the same Location.

 

Tarestudio Adversarius

Lol, I was a bit wonked out when I wrote that code, thanks, it works now!

 

TheBoy3 And here is your method cleaned.

I would however suggest putting the logic into a class.

You may have different SignTypes in the future and this would save you a lot of logic problems...

Code:java

 
@EventHandler
public void onPlayerBreakBlock(BlockBreakEvent event) {
    Player player = event.getPlayer();
    Block block = event.getBlock();
    BlockState state = block.getState();
 
    plugin.logger.info("Stage 1"); //Debug line
 
    if (state instanceof Sign) {
        Sign sign = (Sign) state;
        if (!(sign.getLine(0).equals("[MultiKit Shop]")))
            return;
 
        if (player.getName().equals(sign.getLine(3))) {
            player.sendMessage(ChatColor.GREEN + "Shop unregistered.");
        } else {
            player.sendMessage(ChatColor.RED + "You may not break that shop!");
            event.setCancelled(true);
        }
 
        return; // stop here and return
    }
 
    plugin.logger.info("Stage 2"); //Debug line
    List<Block> blocks = new ArrayList<Block>(
        Arrays.asList(
            block.getRelative(BlockFace.UP),
            block.getRelative(BlockFace.EAST),
            block.getRelative(BlockFace.NORTH),
            block.getRelative(BlockFace.SOUTH),
            block.getRelative(BlockFace.WEST)
        )
    );
 
    for (Block b : blocks) {
        plugin.logger.info("Stage 3"); //Debug line
 
        // nothing to do here if the blockstate is not instance of sign
        if (!(b.getState() instanceof Sign))
            continue;
 
        plugin.logger.info("Stage 4"); //Debug line                    
        Sign sign = (Sign) b.getState();
        if ((!(sign.getLine(0).equals("[MultiKit Shop]"))) || (sign.getBlock().getRelative(sign.getData().getAttachedFace()).equals(block)))
            continue;
 
        plugin.logger.info("Stage 5"); //Debug line
        if (player.getName().equals(sign.getLine(3))) {
            player.sendMessage(ChatColor.GREEN + "Shop unregistered.");
            // unregister shop logic START
            // ...
            // unregister shop logic END
            return;
        } else {
            player.sendMessage(ChatColor.RED + "You may not break that shop!");
            event.setCancelled(true);
            return; // you can return/break from here and ignore the other blocks as this decision is final                
        }                                
    }
}
 

 

lycano I don't think the return before the last should be there, what if there is more than 1 shop attached to the block being broken.

 

ZachBora I don't know if thats required. If thats needed then it should be removed.