New Coder Needs A Bit Of Help..

I am having an issue with the mechanic of coins.. The only command that works is /roteco... Please help if you notice any mistakes.

Code:java

package me.rot.RotZone;
 
import java.util.logging.Logger;
 
 
 
 
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Economy extends JavaPlugin{
 
        public final Logger logger = Logger.getLogger("Minecraft");
        public static Economy plugin;
        int counter = 0;
 
        @Override
        public void onDisable() {
                PluginDescriptionFile pdfFile = this.getDescription();
                this.logger.info(pdfFile.getName() + " Has Been Disabled!");
        }
        @Override
        public void onEnable(){
                PluginDescriptionFile pdfFile = this.getDescription();
                this.logger.info(pdfFile.getName() + " Version " + pdfFile.getVersion() + " Has Been Enabled ");
        }
 
 
 
        //is operator code
 
        public boolean onCommand(CommandSender sender, Command cmd,
                        String commandLabel, String[] args){
                Player player = (Player) sender;
                if(commandLabel.equalsIgnoreCase("RotEco")){
                        if(args.length == 0){
                            if(player.isOp()){
 
                                        player.sendMessage("----" + ChatColor.GOLD + "RotEco (EventAdmin)" + ChatColor.WHITE + "----");
                                        player.sendMessage(ChatColor.AQUA + "/Coins" + ChatColor.WHITE + " | " + ChatColor.GREEN + "Shows your balance!" );
                                        player.sendMessage(ChatColor.AQUA + "/RInfo" + ChatColor.WHITE + " | " + ChatColor.GREEN + " Displays information about the economy system in the RotZone!!!" );
                                        player.sendMessage(ChatColor.AQUA + "/RGive" + ChatColor.WHITE + " | " + ChatColor.GREEN + "Gives winners of events tokens, dont abuse or you will be banned from the RotZone" );
                        }else if(commandLabel.equalsIgnoreCase("Coins")){
 
                                player.sendMessage(ChatColor.AQUA + "You Have 0 coins");
                                }else if (counter == 1){
                                        player.sendMessage("You have 1 coin!");
                                }else{
                                        player.sendMessage("You have" + counter + "coins!");
                                }
 
                                }else if(commandLabel.equalsIgnoreCase("RInfo")){
                                        player.sendMessage(ChatColor.AQUA + " This Plugin was made and devoloped by rotciv157, This plugin adds an economy based system to the RotZone, Coins can be used to buy ranks, perks, and upgrades. Type /RotEco For more commands!!!");
 
                                }else if
                                        (commandLabel.equalsIgnoreCase("RGive" + player.getName() ));
                        }if(args.length == 1){
                                if(player.getServer().getPlayer(args[0]) != null){
                                        Player targetPlayer = player.getServer().getPlayer(args[0]);
                                        if(player.isOp()){
                                                counter++;
                                                targetPlayer.sendMessage(ChatColor.GREEN + "You have recieved a coin from " + ChatColor.GREEN + player.getName());
                                                targetPlayer.sendMessage(ChatColor.GREEN + "You have" + counter + " Coins");
 
 
                                        //is not operator code
 
 
 
 
                }else
 
                        if(commandLabel.equalsIgnoreCase("RotEco")){
 
                        player.sendMessage("----" + ChatColor.GOLD + "RotEco" + ChatColor.WHITE + "----");
                        player.sendMessage(ChatColor.AQUA + "/Coins" + ChatColor.WHITE + " | " + ChatColor.GREEN + "Shows your balance!" );
                        player.sendMessage(ChatColor.AQUA + "/RInfo" + ChatColor.WHITE + " | " + ChatColor.GREEN + " Displays information about the economy system in the RotZone!!!" );
 
                        }else if(commandLabel.equalsIgnoreCase("Coins")){
                player.sendMessage(ChatColor.AQUA + "You Have" +  counter +  "Coins!");
 
                }else if(commandLabel.equalsIgnoreCase("RInfo")){
                        player.sendMessage(ChatColor.AQUA + " This Plugin was made and devoloped by rotciv157, This plugin adds an economy based system to the RotZone, Coins can be used to buy ranks, perks, and upgrades. Type /RotEco For more commands!!!");
 
                }else if(commandLabel.equalsIgnoreCase("Coins")){
                        if (counter == 0){
                        player.sendMessage(ChatColor.AQUA + "You Have 0 coins");
                        }else if (counter == 1){
                                player.sendMessage("You have 1 coin!");
                        }else{
                                player.sendMessage("You have" + counter + "coins!");
                        }
 
 
 
 
 
 
 
}
                }
                }
 
                return false;
}
        }
 

 

can you show your plugin.yml?

 

Could you please elaberate on what the 'problem' is? (Is this your first plugin?)

 

Here you go...

Code:

name: RotZone Economy
main: me.rot.RotZone.Economy
version: 1.0
description: >
            Youtube Plugin.
commands:
  RotEco:
    description: Econmy Commands
  Coins:
    description: Shows balance
  RInfo:
    description: Show Information for the RotEco Plugin
  RGive:
    description: Gives Player coins

I have done other simple plugins before, like broadcasting. But... The issue is that /coins and /rgive don't work.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You have some bracketing issues. If you fix where your brackets are, I'm sure it would work. Just make sure the your if blocks end where you want them to and you don't start an else-if block somewhere you don't want to.

 

Yes, but what is the goal of the plugin.

 

A small economy system to be able to add coins to players who win games, ect I am with thegarfish.

 

What Rotciv said.

 

Bracket issues could you help me find were??

 

So how is the plugin used? Is it an Economy plugin, a Game, ??? (The current code is not how Economy related functions are done)

 

Like mini games, When you win a mini game, I can manually add 1 coin to the winning player

 

This. You need to fix the indentation of your code. Use one tab per indent (press tab), and try to be consistent with things like where your {'s and }'s go, how you lay out your "else if"s, and most relevantly, which 'if' an else is following. You probably think this is just trivial and you don't need to do it to solve the problem, but I can promise you will have much less problems like these when you adopt some sort of coding style rather than letting it get this messy.

 

Your command cannot possibly equal both "RotEco" and "Coins". That is, however, what your code is looking for. Start by fixing that.

 

The plugin will be used in order to reward players who win events. A player wins the event, and event admin gives him a coin. Coins will eventually be spent on thinks withing the zone.

So the entire reason it isn't working is bracket issues?

 

Pretty much. I can see at least one bracketing mistake in your code which would have been avoided by more careful laying-out.
(Not to mention code like this is a nightmare for others to read, which will put others off helping you.)

 

One huge problem is this code does not do what you want. The counter variable would act on all players, you need to save player's coin totals in a config and read and write to that. Also you need to fix your bracketing.

Bracketing and Code

He might as well add an alias to his plugin.yml

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Could you explain how to properly make a config?