Help with /who command

How can i do /who command, but when i try to do this, in every line, is only 1 player name. I'm newb on bukkit. Here is my code:

Code:java

 if (cmd.getName().equalsIgnoreCase("quem")) {
    player.sendMessage(ChatColor.WHITE + "Atualmente há " + Bukkit.getOnlinePlayers().length + " jogadores online");
    player.sendMessage(ChatColor.RED + "Admin" + "" + ChatColor.GRAY + ", " + ChatColor.ITALIC + "" + ChatColor.DARK_PURPLE + "" + ChatColor.ITALIC + "Mod+" + ChatColor.RESET + ChatColor.GRAY + ", " + ChatColor.DARK_PURPLE + "Mod" + ChatColor.GRAY + ", " + ChatColor.GOLD + "Pro" + ChatColor.GRAY + ", " + ChatColor.BLUE + "Mvp" +  ChatColor.GRAY + ", " + ChatColor.GREEN + "Vip");
    for (Player online : player.getServer().getOnlinePlayers()) {
        String playername = online.getDisplayName();
        String virgula = ",";
        player.sendMessage(virgula + playername);

 

Hi there

First of all, your second sendMessage(), the one where you write "Admin" etc. what's that for?
It seems like it's a static string that won't change, so create a variable for that, and send the variable instead.

Also, the way you're sending player names, it will be one per line. I'm not sure if it's what you intended.

How many players are on your server when you try the command?

 

You are sending each player as an individual message since you are doing it in the for-loop. What you want to do is add the name to a StringBuilder and send the StringBuilder's String to the client:

Code:java

 
StrBuilder message = new StrBuilder(); //StringBuilder implementation out of apache commons (bundled with bukkit), provides some additional stuff
for (Player online : player.getServer().getOnlinePlayers()) {
    ret.appendSeparator(", "); //additional stuff I was talking about
    ret.append(online.getName());
}
player.sendMessage(message.toString());
 

 

You have player.sendMessage() in a loop and that starts a new line every time. You can try adding all names to a single string and then sending the message.

 

GaaTavares

player.sendMessage sends a line, and each subsequent player.sendMessage will send a new line.

What you need to do, is have a "String players;" above the for loop. Then go through the for loop and do:

players = players + playername + ", ";

Then after the for loop, send the player the string.

 

The second line is the server ranks: adm,mod+,pro,vip, etc..

 

In that case, wouldn't it be more useful to get the groups from your permissions plugin, preferably through Vault?