Solved Inventory Manipulation Not Working

So im still learning and i went onto the bukkit plugin tutorial page to see how to do inventory manipulation i copy and pasted the code but its not working ? Heres the beginning of my code

Code:java

public class Signs extends JavaPlugin{
 
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Signs plugin;
 
    @Override
    public void onDisable()
    {
        PluginDescriptionFile pdffile = this.getDescription();
        this.logger.info(pdffile.getName() + " Has Been Disabled ");
    }
 
 
    @Override
    public void onEnable()
    {
        PluginDescriptionFile pdffile = this.getDescription();
        this.logger.info(pdffile.getName() + " Version : " + pdffile.getVersion() + " Has Been Enabled ");
        getConfig().options().copyDefaults(true);
        saveConfig();
    }
 
    public void onPlayerJoin(PlayerJoinEvent evt) {
        Player player = evt.getPlayer(); // The player who joined
        PlayerInventory inventory = player.getInventory(); // The player's inventory
        ItemStack itemstack = new ItemStack(Material.DIAMOND, 64); // A stack of diamonds
 
        if (inventory.contains(itemstack)) {
            inventory.addItem(itemstack); // Adds a stack of diamonds to the player's inventory
            player.sendMessage("Welcome! You seem to be reeeally rich, so we gave you some more diamonds!");
        }
    }

someone please help me as im still a beginner and want to learn so much more.

 

Hello Notorious-Riddler,
Im pretty sure you have an title mistake in your code: :3

Code:java

if (inventory.contains(itemstack)) {
// if the player has an stack of diamonds
 
inventory.addItem(itemstack);
// give him another stack diamonds
 
player.sendMessage("Welcome! You seem to be reeeally rich, so we gave you some more diamonds!");
// + send him a message
}

try using:

Code:java

if (inventory.contains(itemstack) == false) { // or: if(!inventory.contains(itemstack){ ...
// if the player hasn't an stack of diamonds
 
inventory.addItem(itemstack);
// give him another stack diamonds
 
player.sendMessage("Welcome! You seem to be reeeally rich, so we gave you some more diamonds!");
// + send him a message
}

//edit:
and add the @EventHandler annotation to your

Code:java

public void onPlayerJoin(PlayerJoinEvent evt) {
//so it lookes like that:
 
@EventHandler()
public void onPlayerJoin(PlayerJoinEvent evt) {

and last but not least :3 don't forget to register your listener in your onEnable method

 

Hello MP5K !

thanks for the code but it still doesn't work here is my code now :

Code:java

public class Signs extends JavaPlugin{
 
    public final Logger logger = Logger.getLogger("Minecraft");
    public static Signs plugin;
 
    @Override
    public void onDisable()
    {
        PluginDescriptionFile pdffile = this.getDescription();
        this.logger.info(pdffile.getName() + " Has Been Disabled ");
    }
 
 
    @Override
    public void onEnable()
    {
        PluginDescriptionFile pdffile = this.getDescription();
        this.logger.info(pdffile.getName() + " Version : " + pdffile.getVersion() + " Has Been Enabled ");
        getConfig().options().copyDefaults(true);
        saveConfig();
    }
 
    public void onPlayerJoin(PlayerJoinEvent evt) {
        Player player = evt.getPlayer(); // The player who joined
        PlayerInventory inventory = player.getInventory(); // The player's inventory
        ItemStack itemstack = new ItemStack(Material.DIAMOND, 64); // A stack of diamonds
 
        if (inventory.contains(itemstack) == false) { // or: if(!inventory.contains(itemstack){ ...
            // if the player hasn't an stack of diamonds
 
            inventory.addItem(itemstack);
            // give him another stack diamonds
 
            player.sendMessage("Welcome! You seem to be reeeally rich, so we gave you some more diamonds!");
            // + send him a message
            }
    }

 

Add @EventHandler above the inventory method

 

MrSnare It still doesn't work !

 

Code:java

public class Signs extends JavaPlugin{
 
        public final Logger logger = Logger.getLogger("Minecraft");
        public static Signs plugin;
 
        @Override
        public void onDisable()
        {
            PluginDescriptionFile pdffile = this.getDescription();
            this.logger.info(pdffile.getName() + " Has Been Disabled ");
        }
 
 
        @Override
        public void onEnable()
        {
            PluginDescriptionFile pdffile = this.getDescription();
            this.logger.info(pdffile.getName() + " Version : " + pdffile.getVersion() + " Has Been Enabled ");
            getConfig().options().copyDefaults(true);
            saveConfig();
            getServer().getPluginManager().registerEvents(this, this);
        }
 
        @EventHandler
        public void onPlayerJoin(PlayerJoinEvent evt) {
            Player player = evt.getPlayer(); // The player who joined
            PlayerInventory inventory = player.getInventory(); // The player's inventory
            ItemStack itemstack = new ItemStack(Material.DIAMOND, 64); // A stack of diamonds
    }
}

That should work but it needs extra imports

 

MP5K
That first suggestion is just bullshit and totally not relevant. Lol.

 

callum.thepro Thanks man that worked !

 

Your welcome, good to see another plugin working

 

Wow Harsh..

 

It was true though...