Help with programming

Well i was coding my event handlers arent working and also how can i get the integers of people on

Code:

package me.jr.pvp;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Pvp extends JavaPlugin implements Listener {
    public static int gameloop = 0;
    public static int timeinseconds = 0;
    public static boolean canStart;
 
    @Override
    public void onEnable() {
        timeinseconds = 120;
        canStart = false;
        gameloop = getServer().getScheduler().scheduleSyncRepeatingTask(this,
                new GameLoop(), 20l, 20l);
    }
 
    public void onDisable() {
        getServer().getScheduler().cancelTask(gameloop);
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        return false;
   
    }
    @EventHandler(priority = EventPriority.HIGHEST)
    public void onPlayerJoin(PlayerJoinEvent event) {
        canStart = Bukkit.getOnlinePlayers().length >= 1;
    }
 
    @EventHandler
    public void onPlayerLeave(PlayerQuitEvent event) {
        canStart = Bukkit.getOnlinePlayers().length - 1 >= 1;
 
    }
}

that is my pvp class and my other class is like this

Code:java

package me.jr.pvp;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Effect;
import org.bukkit.Location;
import org.bukkit.Sound;
import org.bukkit.entity.Player;
 
public class GameLoop implements Runnable {
 
 
    public void run() {
        if (Pvp.timeinseconds >= 60 && Pvp.timeinseconds % 60 == 0){
        timeuntilstart(true);
        }
 
    if (Pvp.timeinseconds <= 30 && Pvp.timeinseconds % 15 == 0 && Pvp.timeinseconds > 0){
timeuntilstart(true);
}
 
    if (Pvp.timeinseconds <= 10 && Pvp.timeinseconds > 0){
    timeuntilstart(false);
    note();
 
}
 
    if (Pvp.timeinseconds == 0){
    if (Pvp.canStart)
        Bukkit.broadcastMessage("Game started");
    else {
        Bukkit.broadcastMessage(ChatColor.RED + "" + ChatColor.ITALIC + "Not enough players! Resetting timer!");
        resetnote();
        Pvp.timeinseconds = 121;
    }
    }
    if (Pvp.timeinseconds > 0){
    Pvp.timeinseconds--;
    }
        }
    private void note() {
        for (Player player : Bukkit.getOnlinePlayers()){
            player.playSound(player.getLocation(), Sound.NOTE_PIANO, 10, 1);
        }
            }
    private void resetnote() {
        for (final Player player : Bukkit.getOnlinePlayers()){
            final Location l = player.getLocation();
        new Thread(new Runnable() {
 
            @Override
            public void run() {
                try {
        for (int i = 0; i < 4; i++){
    player.playEffect(l, Effect.CLICK1, 1);
            Thread.sleep(450);
        }   
            }catch (Exception e){
                e.printStackTrace();
        }
          }
            }).start();   
        }
    }
 
    private void timeuntilstart(boolean extraArgs) {
 
    if (Pvp.timeinseconds % 30 == 0 && Pvp.timeinseconds >= 30){
 
    Bukkit.broadcastMessage(Pvp.timeinseconds + "" + ChatColor.GOLD + " seconds until start!");
 
    }else if (Pvp.timeinseconds < 30){
 
            Bukkit.broadcastMessage(Pvp.timeinseconds + "" + ChatColor.GOLD + " seconds until start!");
    }
    }
}
 

please respond asap!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

xepisolonxx A few notes:

1. Wrong section. This should be in Bukkit Development.
2. You didn't register your Listeners class.

 

Bukkit.getOnlinePlayers().length is the amount of players on.. which you appear to be using already ?

You also need to register your events in your onEnable() method:

Code:

getServer().getPluginManager().registerEvents(this, this);

 

thank you so much!

i have another promblem when it reaches zero for timer it spams message how can i fix it becuase i tried setting it different number for time and tried set canStart false but doesnt work

Sorry idk how to post in other tread im new.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Moved to Plugin Development.