Godmode bug ( My fault )

I may have posted a couple things about god mode, but I still CAN'T GET IT!!!! I've tried 4 different events, cancelled them all, done this and that, and yet only one of them works, but not even completely.. What this one does, is cancels the event ONE time.. I am godmode for 1 hit, and then it removes.. I got no idea what the hell this is, or how it was caused.. Please help me.. Thanks

Code:

package me.kreashenz.minecraftrp.Commands;
 
import java.util.ArrayList;
 
import me.kreashenz.minecraftrp.MCRP;
import me.kreashenz.minecraftrp.Utilities.Functions;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageEvent;
 
public class God implements CommandExecutor, Listener {
 
    ArrayList<String> godmode = new ArrayList<String>();
 
    public MCRP plugin;
    public God(MCRP plugin){this.plugin=plugin;}
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        if(cmd.getName().equalsIgnoreCase("god")){
            if(sender instanceof Player){
                if(sender.hasPermission("mcrp.god")){
                    if (godmode.contains(sender.getName()))
                    {
                        sender.sendMessage("§cGod mode §6disabled§c.");
                        godmode.remove(sender.getName());
                    } else {
                        sender.sendMessage("§cGod mode §6enabled§c.");
                        godmode.add(sender.getName());
                    }
                } else sender.sendMessage(Functions.noPerm());
            } else sender.sendMessage("§cYou must be a player to use this command.");
        }
        return true;
    }
 
    @EventHandler(priority = EventPriority.MONITOR)
    public void onGodMode(EntityDamageEvent e){
        if (e.getEntity() instanceof Player){
            Player p = (Player) e.getEntity();            
            if (!godmode.contains(p.getName())){
                godmode.add(p.getName());
                e.setCancelled(true);
            } else godmode.remove(p.getName());
        }
    }
    // This part is blocked off, because I was testing.
    /*       
    @EventHandler(priority = EventPriority.MONITOR)
    public void onGodModeCheck(EntityDamageByEntityEvent e){
        if (e.getEntity() instanceof Player){
            Player p = (Player) e.getEntity();            
            if (!godmode.contains(p.getName())){
                e.setCancelled(true);
                godmode.add(p.getName());
            } else godmode.remove(p.getName());
        }
    }
     */
}

 

You're checking if the player is not in the list. If he's not in the list, you add him to the list, and cancel the damage. When the player IS in the list, you remove him from it. Why?

 

Use highest priority, not monitor. Monitor should not change the event. Also, it looks like your listener just gives someone god mode if they don't have it, and removes it if they do. Try this in your listener:

Code:

if(godmode.contains(p.getName())) {
    e.setCancelled(true);
}

 

jorisk322 hockeygoalie5 I added that part if hes on the list, then remove, because I'm stupid, and I thought that if they typed it again, it would remove them.
[EDIT] And now its COMPLETELY stopped working. This is what I mean, you do one thing, and it stops it, you do another thing, it works, but 1 time.. Confusing as hell.

Also, were you talking about the command, or the event, because I just realized.. Haha

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

The event

 

Code:

 
  @EventHandler(priority = EventPriority.HIGHEST)
    public void onGodMode(EntityDamageEvent e){
        if (e.getEntity() instanceof Player){
            Player p = (Player) e.getEntity();           
            if (godmode.contains(p.getName())){
                e.setCancelled(true);
            } 
        }
    }

I would check more then 1 event. Theirs a couple you will needa cancell

 

ConflictRealms What would those couple be?

 

When I give a user godmode, I use 1 line of code

Code:

player.setNoDamageTicks(9999999999);

 

ZeusAllMighty11 AHAHA! Fair enough, I guess I could use that for a while.. What if the time runs out, the player will be removed from god mode, how do I keep them permanently in godmode.. Should I use </> for it?

 

What about looping it every 9999999999 seconds

 

Yeah, I don't know how to loop seconds.. Lol! I know some of the hard stuff, but none of the easy stuff.. Pretty stupid. I learnt Arrays before I learnt HashMaps

 

Just everytime they log in or out, set it again... ?

 

ZeusAllMighty11 Could I use an if statement, so if the timer goes under (say) 20, it just sets back to 20?

ZeusAllMighty11 New code :

Code:java

package me.kreashenz.minecraftrp.Commands;
 
import java.util.ArrayList;
 
import me.kreashenz.minecraftrp.MCRP;
import me.kreashenz.minecraftrp.Utilities.Functions;
 
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
 
public class God implements CommandExecutor, Listener {
 
    ArrayList<String> godmode = new ArrayList<String>();
 
    public MCRP plugin;
    public God(MCRP plugin){this.plugin=plugin;}
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        Player player = (Player)sender;
        if(cmd.getName().equalsIgnoreCase("god")){
            if(sender instanceof Player){
                if(sender.hasPermission("mcrp.god")){
                    if (godmode.contains(sender.getName())){
                        if(player.getNoDamageTicks() < 20){
                            player.setNoDamageTicks(999999999);
                        }
                        sender.sendMessage(Functions.getPrefix() + "§cGod mode §6disabled§c.");
                        godmode.remove(sender.getName());
                    } else {
                        if(player.getNoDamageTicks() > 1){
                            player.setNoDamageTicks(0);
                        }
                        sender.sendMessage(Functions.getPrefix() + "§cGod mode §6enabled§c.");
                        godmode.add(sender.getName());
                    }
                } else sender.sendMessage(Functions.noPerm());
            } else sender.sendMessage("§cYou must be a player to use this command.");
        }
        return true;
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You mixed up enabled and disabled but sure