How to ignore messages from commands?

I want to know how to be able to ignore messages from commands, like /broadcast, /say, and other server broadcasting things. Would I need to check if the message equals something, or starts with something, because I don't know if that'd work, coz I haven't tried this before.. To be honest, is this actually easy, or am I just stupid, and can't think of better ways to do this. Thanks..

 

You need the playerCommandPreprocessingEvent, to check if it is the command you want to block or not, and to act consequently.

 

How do you check the command, it only checks messages.. ( I haven't used this before, and I'm reading the javadoc now )

 

Well, check if the message starts with "/"+commandname

 

Ahhh, but how would it catch the senders name, not the person who's trying to block the commands.. I am kinda new to this, so explain a little more vague.

 

event.getPlayer is the player who sent the message/command.

 

Ahh, LOLOLOL, I'm stupid Ok I will finish the command and get back to you.

Nitnelave Sorry, but I need an example one, I got lost on what I was doing while I was AFK..

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:

@EventHandler
public void onPreCommand(PlayerCommandPreprocessEvent e){
    Player sender = e.getPlayer();
    if(e.getMessage().startsWith("/spawn")){
        sender.sendMessage("There is no spawn! muahaha");
        sender.setHealth(2);
    }
}

 

@ZuesAllMighty11 Ahaha, Ok, but why set their health to 1 heart.. That's just mean Thanks ! If I add a if(e.getPlayer().isOp())e.setCancelled(true); will that cancel out command, or just that one?

 

Explain what you are trying to do, im confused?

 

x0pk1n Basically if a player types the /onduty or /offduty command, they will/will not receive /report messages. I guess I coulda said this before, but my explaining skills are retarded, aren't they?

 

If you add that line, you will basically prevent op from using any command or talking to anyone...

 

kreashenz So what code have you got? As this isn't a request forum, it is the develpment forum.

 

x0pk1n If this was the request forum then there wouldn't be much of java talk at all

 

GodzOfMadness If this was a development forum, he would have show us what he has and is trying.

 

x0pk1n Well if you read the thread you would know that he didn't know how to cover a certain aspect so he came on the "development forum" for help

 

GodzOfMadness Then where is the code he has tried for this aspect?

 

x0pk1n

 

x0pk1n GodzOfMadness I was trying, and I think I got it, but I can't test it, because.. Well, I don't know why its not working, but I can just type /duty and it doesn't actually do anything.. Here is my whole Duty ( /onduty | /offduty ) code, that I have made so far.

Code:java

 
package me.kreashenz.minecraftrp.Commands;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
 
import me.kreashenz.minecraftrp.MCRP;
import me.kreashenz.minecraftrp.Utilities.Functions;
 
public class Duty implements Listener, CommandExecutor {
 
    public MCRP plugin;
    public Duty(MCRP plugin){this.plugin=plugin;}
    public static Boolean onDuty = Boolean.valueOf(false);
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        if(cmd.getName().equalsIgnoreCase("duty")){
            if(sender instanceof Player){
                if(sender.hasPermission("mcrp.duty")){
                    if(args.length==0){
                        if(Boolean.valueOf(false)){
                            Boolean.valueOf(true);
                            sender.sendMessage("§eYou are now §con-duty§e, and will recieve Reports.");
                            Bukkit.broadcastMessage("§c" + sender.getName() + "§e is now §con-duty§e, and will be taking reports!");
                        } else if(Boolean.valueOf(true)){
                            Boolean.valueOf(false);
                            sender.sendMessage("§eYou are now §coff-duty§6, and will not recieve Reports.");
                            Bukkit.broadcastMessage("§c" + sender.getName() + "§e is now §coff-duty§e, and will be taking reports!");
                        }
                    }
                } else sender.sendMessage(Functions.noPerm());
            } else sender.sendMessage("§çYou must be player to use this command.");
        }
        return true;
    }
    @EventHandler
    public void onPreCommand(PlayerCommandPreprocessEvent e){
        if(e.getMessage().startsWith("/report")){
            if(Boolean.valueOf(true)){
                e.setMessage(null);
            } else if(Boolean.valueOf(false)){ e.setMessage(e.getMessage());}
        }
    }
}

 

Boolean.valueof(true) is the exact same thing as simply true, only more confusing. So when you do if(Boolean.valueof(false)), this code will never be executed... I think you're missing something like if player.isOnDuty(), player.setOnDuty(true); etc...
Did you register the command in your plugin.yml? And did you register the commandExecutor in your main onEnable ?

 

Nitnelave Yes, and yes. I just get confused when using the if(Boolean.valueOf(true)){..

 

Well, if(true) is always executed. It's not really a test. I wouldn't be surprised if the compiler removed it.

 

Nitnelave So basically what you're saying, ( or what I'm interpreting ) is that I should replace if(Boolean.valueOf(true)){ with if(true) ?

 

Code:

package me.kreashenz.minecraftrp.Commands;
 
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerCommandPreprocessEvent;
 
import me.kreashenz.minecraftrp.MCRP;
import me.kreashenz.minecraftrp.Utilities.Functions;
 
public class Duty implements Listener, CommandExecutor {
 
    public MCRP plugin;
    public Duty(MCRP plugin){this.plugin=plugin;}
    public List<String> onDuty = new List<String>();
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        if(cmd.getName().equalsIgnoreCase("duty")){
            if(sender instanceof Player){
                if(sender.hasPermission("mcrp.duty")){
                    if(args.length==0){
                        if(!onDuty.contains(sender.getName()){
                            onDuty.add(sender.getName());
                            sender.sendMessage("§eYou are now §con-duty§e, and will recieve Reports.");
                            Bukkit.broadcastMessage("§c" + sender.getName() + "§e is now §con-duty§e, and will be taking reports!");
                        } else {
                           onDuty.remove(sender.getName());
                            sender.sendMessage("§eYou are now §coff-duty§6, and will not recieve Reports.");
                            Bukkit.broadcastMessage("§c" + sender.getName() + "§e is now §coff-duty§e, and will not be taking reports!");
                        }
                    }
                } else sender.sendMessage(Functions.noPerm());
            } else sender.sendMessage("§çYou must be player to use this command.");
        }
        return true;
    }
    @EventHandler
    public void onPreCommand(PlayerCommandPreprocessEvent e){
        if(e.getMessage().startsWith("/report")){
        for (Player p : Bukkit.getOnlinePlayers()) {
         if (p.isOp() && onDuty.contains(p.getName()) {
         p.sendMessage("[Report] "+e.getMessage().replace("/report", ""));
         }
        }
    }
    }
}

As always, not tested

 

molenzwiebel Uhm, da hell is this? I got an error on public List.. Cannot instantiate the type List<String>

 

kreashenz This is the right code, and it should be

Code:

public List<String> onDuty = new ArrayList<String>();

 

molenzwiebel Ok, /duty turns you on/off but the messages aren't getting blocked.. I've haven't tried while Deopped, because I don't even think permissions are working.. How do I test if permissions are working?

 

add e.setCancelled(true); to the preprocessevent after you make sure the message is /report

 

It looks like you're trying to take unnecessary steps here. You want a player's /report to only go to on duty OPs? Why don't you keep a list of on duty OPs and add/remove OPs to the list when they use /onduty or /offduty, then in the /report command listener just send the message to on duty OPs. Something like this for /report:

Code:

// Where onDuty is a List of on duty OPs, and message is the report.
for(Player p : onDuty) {
    p.sendMessage(message);
}

That's it. It only on duty OPs will receive the message, and there's no need to take extra steps to make sure off duty OPs don't.

 

hockeygoalie5 What would this onDuty list be.. Something like, List<Player> duty = onDuty.????