Standards for onCommand

A lot of times onCommand's for plugins tend to get very crowded with if statements for various sub-commands, and I was wondering, how do others deal with this?

 

I dealt with it by creating classes solely for each family of commands. I had about 4 classes. Each was a CommandExecutor. In onEnable, I just spread out the commands manually.

Then, within each class, the onCommand was simply a delegator. It caught the command, decided which one it was, then continued on into a separate method within that class. This way, you can localize the code for each command and you know, a little more specifically, what causes any errors.

For the methods, I had the parameters as, CommandSender sender, String[] args. I handled the player-getting and args parsing within the individual methods.

 

I create a different method for each subcommand and call that from the onCommand.

 

I'm curious, what do you guys think of this?

Code:

        if(args.length == 0)
        {
            return this.usage(cs,args);
        }
        else
        {
            try {
                return (Boolean) Class.forName("SomeCommandExecutor")
                        .getMethod(args[0].toLowerCase()).invoke(this,cs,args);
            }
            catch(Exception e)
            {
                return false;
            }
        }

Then you would just create methods named after the first arg.

I suppose it lacks in support of first parameter aliases, but it seemed like an idea worth trying out.

*edit* fixing code

 

Just make sure to put the arg into lowercase first, and make all your methods's names lowercase.

 

Oh good point, heh.

 

Mmh nice, short, and functional. Me likes

 

If's everywhere

 

Practically speaking I don't know if there's much of a difference, the If's are probably even faster... But after trying this method out, I like the organization of it.

 

If you want you can try out my CommandMethod library at https://github.com/Ranzdo/MethodCommand/wiki .

It deals with this problem and it have worked very good for me.

 

Ranzdo I don't see the point of using that many lines while you can do in way less lines, using less RAM and taking (probably) less time than your excessive method